Opened 17 years ago

Closed 17 years ago

Last modified 8 years ago

#1272 closed defect (invalid)

LAME 3.96.1 missing configure options

Reported by: rjdymond@… Owned by: blfs-book@…
Priority: normal Milestone:
Component: BOOK Version: SVN
Severity: minor Keywords:
Cc:

Description

The section for LAME 3.96.1 mentions that mp3x is an optional installed program, but doesn't mention that you need to pass --enable-mp3x to ./configure in order to get it.

In addition, NASM is listed as an optional dependency, but there is no mention of the fact that you MUST pass --enable-nasm to ./configure in order to use it, because it won't be enabled by default. (This option is useful, because it gives lame a small performance boost.)

Change History (6)

comment:1 by Randy McMurchy, 17 years ago

Resolution: invalid
Status: newclosed

The policy on optional dependencies is to only list the parameters if they are difficult to find, or hard to deduce from the existing documentation.

In this case, where these parameters are found by simply doing ./configure --help, we wouldn't put this in the book. Readers are expected to use the existing documentation to help them figure out for themselves what should and should not be passed to configure to suit there individual needs.

Marking as invalid.

comment:2 by rjdymond@…, 17 years ago

Fair enough on the policy, but I thought --enable-nasm was worth mentioning for two reasons:

(i) ./configure --help doesn't tell you whether default=yes or no for --enable-nasm (it does for most other options) (ii) The INSTALL file for lame says that if ./configure detects nasm then additional speed improvements get compiled in. But this is misleading, because even if ./configure does detect nasm, the additional speed improvements won't get compiled in unless you explicitly pass --enable-nasm.

This is my experience anyway, and I admit I could just be overpicky!

comment:3 by kpfleming@…, 17 years ago

Standard procedure for all configure script help output is that '-enable-foo' in the help output means it defaults to off, and '-disable-foo' means it defaults to on. There is not normally any need for the help output to explicitly state the default.

comment:4 by rjdymond@…, 17 years ago

I agree that would be a good standard to follow (i.e. to default to no/off for options not explicitly given), but the lame configure script doesn't follow that standard. If you want to know whether --enable-nasm is required, ./configure --help turns out to be inconclusive (because some optional features default to yes/on, so you're left in doubt about the others), and the advice in INSTALL is just incorrect.

In light of this, would it be so bad to give a hint about --enable-nasm?

comment:5 by kpfleming@…, 17 years ago

No, that would not be terrible, but keep in mind the precedent it would set (now the editors would have to review the configure --help output for every single package to find similar cases).

I would highly suggest making a patch to the LAME distribution to send upstream to modify the configure --help output to be inline with what most other packages do.

comment:6 by bdubbs@…, 8 years ago

Milestone: old

Milestone old deleted

Note: See TracTickets for help on using tickets.