Opened 5 years ago
Closed 5 years ago
#12823 closed enhancement (fixed)
NetworkManager-1.20.8
Reported by: | Douglas R. Reno | Owned by: | Douglas R. Reno |
---|---|---|---|
Priority: | normal | Milestone: | 9.1 |
Component: | BOOK | Version: | SVN |
Severity: | normal | Keywords: | |
Cc: |
Description
New point version
Overview of changes since NetworkManager-1.20.6 =============================================== This is a new stable release of NetworkManager. Notable changes include: * Fix handling of system CA certificates in the ifcfg parser. * Handle ReachableTime and RetransTimer from IPv6 Router Advertisements. * Fixed setting of MTU according to its parent device for some device types. * Various fixes for the initramfs configuration genertor.
Change History (6)
comment:1 by , 5 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 5 years ago
I'm continuing to have problems with the tests. Here's what I've tried so far:
- Adding in kernel configuration to my build that wasn't present (Bonding support, Dummy Network Device, and Ethernet Teaming support).
- Backporting all upstream commits since release to it in case one of them was at fault (none of them were)
- Verifying manually that I had all of the dependencies installed.
- Checking for upstream bugs on mailing lists, GitLab issues, and GitLab Merge Requests.
I'm at a loss for this one. The only tests which are failing in a way that is reproducible is the Linux-platform specific tests, which I'm not sure is a good thing.
It looks like an assertion is failing because it's getting one more IPv6 route than it was expecting. I remember reading about Linux v5.3+ changing the API for IPv6 implementation on Phoronix, but I tried it on a system with a 5.1.11 kernel and have encountered similar problems.
What do you guys suggest? I can mark the test suite as "not working" or document the failures, but I'm not confident that this doesn't signify a problem. Can someone else reproduce this?
Ok: 53 Expected Fail: 0 Fail: 4 Unexpected Pass: 0 Skipped: 0 Timeout: 0 The output from the failed tests: 19/57 platform/test-cleanup-linux FAIL 0.22 s (killed by signal 6 SIGABRT) --- command --- /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/tools/run-nm-test.sh --called-from-make /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build --launch-dbus=auto /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build/src/platform/tests/test-cleanup-linux --- stdout --- # random seed: R02Scfe3fffb1254ed7f17dcdb60567b80a5 nmtst: initialize nmtst_get_rand() with NMTST_SEED_RAND=0 1..1 Bail out! test:ERROR:../src/platform/tests/test-cleanup.c:95:test_cleanup_internal: assertion failed (routes6->len == 3): (4 == 3) --- stderr --- ** test:ERROR:../src/platform/tests/test-cleanup.c:95:test_cleanup_internal: assertion failed (routes6->len == 3): (4 == 3) ------- 21/57 platform/test-link-linux FAIL 0.32 s (killed by signal 6 SIGABRT) --- command --- /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/tools/run-nm-test.sh --called-from-make /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build --launch-dbus=auto /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build/src/platform/tests/test-link-linux --- stdout --- # random seed: R02Scb0885d4ce4f501dfee035b66a9d5647 nmtst: initialize nmtst_get_rand() with NMTST_SEED_RAND=0 1..76 # Start of link tests ok 1 /link/bogus ok 2 /link/loopback ok 3 /link/internal ok 4 /link/external # Start of software tests ok 5 /link/software/bridge ok 6 /link/software/bond ok 7 /link/software/team # NetworkManager-MESSAGE: <warn> [1575351933.8067] platform-linux: do-add-link[nm-test-device/vlan]: failure 95 (Operation not supported - Unknown device type) Bail out! test:ERROR:../src/platform/tests/test-link.c:366:test_software: assertion failed: (software_add (link_type, DEVICE_NAME)) --- stderr --- NetworkManager-Message: 23:45:33.806: <warn> [1575351933.8067] platform-linux: do-add-link[nm-test-device/vlan]: failure 95 (Operation not supported - Unknown device type) ** test:ERROR:../src/platform/tests/test-link.c:366:test_software: assertion failed: (software_add (link_type, DEVICE_NAME)) ------- 25/57 platform/test-route-linux FAIL 0.22 s (killed by signal 6 SIGABRT) --- command --- /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/tools/run-nm-test.sh --called-from-make /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build --launch-dbus=auto /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build/src/platform/tests/test-route-linux --- stdout --- # random seed: R02S4d639f97789715a088f11bbdef46d450 1..16 # Start of route tests nmtst: initialize nmtst_get_rand() with NMTST_SEED_RAND=0 ok 1 /route/ip4 Bail out! test:ERROR:../src/platform/tests/test-route.c:399:test_ip6_route: assertion failed (routes->len == 3): (4 == 3) --- stderr --- ** test:ERROR:../src/platform/tests/test-route.c:399:test_ip6_route: assertion failed (routes->len == 3): (4 == 3) ------- 44/57 devices/test-acd FAIL 0.22 s (killed by signal 6 SIGABRT) --- command --- /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/tools/run-nm-test.sh --called-from-make /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build --launch-dbus=auto /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build/src/devices/tests/test-acd --- stdout --- # random seed: R02S7008e5502f4cf5b67aad651b654e53f9 1..3 # Start of acd tests nmtst: initialize nmtst_get_rand() with NMTST_SEED_RAND=0 Bail out! test:ERROR:../src/platform/tests/test-common.c:1207:nmtstp_link_veth_add: assertion failed: (success) --- stderr --- RTNETLINK answers: Operation not supported ** test:ERROR:../src/platform/tests/test-common.c:1207:nmtstp_link_veth_add: assertion failed: (success) ------- Full log written to /sources/NetworkManager-1.20.8/NetworkManager-1.20.8/build/meson-logs/testlog.txt FAILED: meson-test /usr/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed.
comment:3 by , 5 years ago
On my 5.1.11 build, I have confirmed that the tests now pass.
I'll add two things to the NetworkManager page:
- Documentation to the tests to say that the Linux Platform Specific tests fail with kernel 5.3+ (which has been confirmed to rewrite parts of the IPv6 API implementation - it's returning 4 routes instead of 3 and NM's tests don't like that)
- Kernel configuration information for the tests - you need bonding support and the dummy networking test driver.
comment:4 by , 5 years ago
Testing manually with nmtui shows that all is well. Proceeding with the commit
comment:5 by , 5 years ago
Here's the kernel configuration needed.
Device Drivers --->
[ * ] Network device support ---> [CONFIG_NETDEVICES]
[ * ] Bonding driver support [CONFIG_BONDING] [ * ] Dummy net driver support [CONFIG_DUMMY] [ * ] Ethernet team driver support [CONFIG_NET_TEAM]
The teaming support might be optional, but it doesn't affect anything except for allowing a test to pass farther. It doesn't need libteam and uses "ip link add link [ address MAC ] [ NAME ] type team" to do it's job on a virtual interface.
Two more gnome updates