webkitgtk-2.26.4

[Douglas R. Reno]

New point version (security release)

What's new in the WebKitGTK 2.26.4 release?
===========================================

  - Always use a light theme for rendering form controls.
  - Fix the build with WPE renderer disabled.
  - Fix the build with OpenGL disabled.
  - Fix the build with GCC 10.
  - Fix several crashes and rendering issues.

Security Advisory

------------------------------------------------------------------------
WebKitGTK and WPE WebKit Security Advisory                 WSA-2020-0002
------------------------------------------------------------------------

Date reported           : February 14, 2020
Advisory ID             : WSA-2020-0002
WebKitGTK Advisory URL  : https://webkitgtk.org/security/WSA-2020-0002.html
WPE WebKit Advisory URL : https://wpewebkit.org/security/WSA-2020-0002.html
CVE identifiers         : CVE-2020-3862, CVE-2020-3864, CVE-2020-3865,
                          CVE-2020-3867, CVE-2020-3868.

Several vulnerabilities were discovered in WebKitGTK and WPE WebKit.

CVE-2020-3862
    Versions affected: WebKitGTK before 2.26.4 and WPE WebKit before
    2.26.4.
    Credit to Srikanth Gatta of Google Chrome.
    Impact: A malicious website may be able to cause a denial of
    service. Description: A denial of service issue was addressed with
    improved memory handling.

CVE-2020-3864
    Versions affected: WebKitGTK before 2.26.4 and WPE WebKit before
    2.26.4.
    Credit to Ryan Pickren (ryanpickren.com).
    Impact: A DOM object context may not have had a unique security
    origin. Description: A logic issue was addressed with improved
    validation.

CVE-2020-3865
    Versions affected: WebKitGTK before 2.26.4 and WPE WebKit before
    2.26.4.
    Credit to Ryan Pickren (ryanpickren.com).
    Impact: A top-level DOM object context may have incorrectly been
    considered secure. Description: A logic issue was addressed with
    improved validation.

CVE-2020-3867
    Versions affected: WebKitGTK before 2.26.4 and WPE WebKit before
    2.26.4.
    Credit to an anonymous researcher.
    Impact: Processing maliciously crafted web content may lead to
    universal cross site scripting. Description: A logic issue was
    addressed with improved state management.

CVE-2020-3868
    Versions affected: WebKitGTK before 2.26.4 and WPE WebKit before
    2.26.4.
    Credit to Marcin Towalski of Cisco Talos.
    Impact: Processing maliciously crafted web content may lead to
    arbitrary code execution. Description: Multiple memory corruption
    issues were addressed with improved memory handling.

[Douglas R. Reno]

Do we still want to keep the bubblewrap sandbox option disabled? It seems that it was fixed in trunk, and can be backported via a very simple sed:

​https://bugs.webkit.org/show_bug.cgi?id=202071

Originally, the rationale for disabling it was that we were unable to access files on the local filesystem. That was fixed by removing an unnecessary security check.

All we'd need to do is apply the following one-line change to our Source/WebCore/page/SecurityOrigin.cpp file:

​https://trac.webkit.org/changeset/255824/webkit

-#if !PLATFORM(IOS_FAMILY)
+#if !PLATFORM(IOS_FAMILY) && !ENABLE(BUBBLEWRAP_SANDBOX)

[Douglas R. Reno]

Let's not turn the sandbox on, it needs xdg-dbus-proxy. We can re-examine the sandbox after release.

[Bruce Dubbs]

2080.7 Elapsed Time -  webkitgtk-2.26.4
SBU=20.006
18880 /usr/src/webkit/webkitgtk-2.26.4.tar.xz SIZE (18.437 MB)
631936 kilobytes BUILD SIZE (617.125 MB)
md5sum : 60f881729f3b71244b7f6e58790073e0  /usr/src/webkit/webkitgtk-2.26.4.tar.xz

[Douglas R. Reno]

I'm curious about the build size difference here. I have:

WebKitGTK+-2.26.4 UPDATE NOTES
Ticket #13136
------------------------------------------------

Download URL:
        HTTP:	https://webkitgtk.org/releases/webkitgtk-2.26.4.tar.xz
Download Size: 18 MB
MD5SUM: 60f881729f3b71244b7f6e58790073e0

Elasped Time: 1986.0
Installed Files Size: 725 MB (107 MB installed)
SBU Value: 20 SBU

DEPENDENCY CHANGES: NONE

INSTALLED FILES CHANGES: NONE

TYPO FIXES: 
	-DUSE_WOFF2=ON: Add "This adds support for additional fonts."

Fixed at r

I'm about ready to submit these

[Bruce Dubbs]

I used:

   cmake -DCMAKE_BUILD_TYPE=Release  \
         -DCMAKE_INSTALL_PREFIX=/usr \
         -DCMAKE_SKIP_RPATH=ON       \
         -DPORT=GTK                  \
         -DLIB_INSTALL_DIR=/usr/lib  \
         -DUSE_LIBHYPHEN=OFF         \
         -DENABLE_MINIBROWSER=ON     \
         -DUSE_WOFF2=OFF             \
         -DUSE_WPE_RENDERER=OFF      \
         -DENABLE_BUBBLEWRAP_SANDBOX=OFF \
         -Wno-dev -G Ninja .. 

[Douglas R. Reno]

Fixed at r22754