Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#13830 closed enhancement (fixed)

thunderbird-78.0.1

Reported by: Bruce Dubbs Owned by: Douglas R. Reno
Priority: normal Milestone: 10.0
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

New point version.

Change History (9)

comment:1 by Douglas R. Reno, 14 months ago

Owner: changed from blfs-book to Douglas R. Reno
Status: newassigned

comment:2 by Douglas R. Reno, 14 months ago

What’s New
new

OpenPGP: Key revocation, extending key expiration, and secret key backup
Fixes

fixed

Drag & Drop multiple attachments to macOS Finder created duplicate files
fixed

Faceted search date and relevance settings not saved
fixed

FileLink attachments included as a link and file when added from a network drive via drag & drop
fixed

About Thunderbird dialog keyboard shortcuts did not work
fixed

CC'd recipients sometimes displayed collapsed in header pane
fixed

Incremental search in contacts sidebar did not always display local results when an LDAP server was also in use
fixed

Contacts sidebar search results cleared after removing a contact
fixed

OpenPGP: Messages with long Armor Header lines did not display
fixed

OpenPGP: Messages containing non-UTF-8 text were not supported
fixed

Various UI and theming fixes
fixed

Chat: Participants list did not display operator flags

comment:3 by ken@…, 14 months ago

Some initial comments on what is in the book for 78.0, since for unrelated reasons I'm trying to compile this new version with rustc-1.45.0 OK (I'm wondering if moving to a newer rust before our next release would be useful.)

  1. I'm dubious that offering -j1 in MOZ_MAKE_FLAGS will affect much of the build (compare what is in firefox).
  1. I note that pulseaudio is disabled - I have no opinion in whether that is a good thing to do (no audio on the test machine), but it isn't upstream's default.
  1. Critically, --disable-gconf is no longer accepted, just like in firefox-78.

Meanwhile, 78.0.1 failed when using my own CFLAGS (-O3 -march=native -fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong) in configure:

0:09.08 DEBUG: clang-10: error: unknown argument: '-fstack-clash-protection'
 0:09.08 DEBUG: configure: failed program was:
 0:09.08 DEBUG: #line 3727 "configure"
 0:09.08 DEBUG: #include "confdefs.h"
 0:09.08 DEBUG:
 0:09.08 DEBUG: int main() {
 0:09.08 DEBUG:
 0:09.08 DEBUG: ; return 0; }
 0:09.08 DEBUG: configure: error: compiler is incompatible with sanitize options

Obviously that first message, rather than the 'incompatible', is what matters. I had thought clang accepted that now, but apparently not (even ubuntu has used that flag for a while).

My build with CC=gcc CXX=g++ and rustc-1.45.0 has now started, Will report if it succeeds or fails.

comment:4 by Douglas R. Reno, 14 months ago

That's a good point. I just noticed the --disable-gconf failure. Regarding pulseaudio, should I then move it to Recommended or Required and drop the instructions in the mozconfig file? I can remove the MOZ_MAKE_FLAGS stuff from the mozconfig file when submitting this (just doing testing now).

It builds fine for me without any special cflags, but I'm not using rustc-1.45 :)

Actually, would copying what's in the mozconfig regarding Pulseaudio/ALSA in Firefox work?

Last edited 14 months ago by Douglas R. Reno (previous) (diff)

comment:5 by ken@…, 14 months ago

Yes, what is in firefox should work.

I forgot to note my original point! : ./mach is now a python script, not python2 (for current BLFS, it can be described as python3)

And since you are working on it, I guess you can ignore the email I sent you ;-)

comment:6 by Douglas R. Reno, 14 months ago

/me adjusts that command explanation :)

I got your email and replied to it, no worries :)

in reply to:  3 ; comment:7 by ken@…, 14 months ago

Replying to ken@…:

My build with CC=gcc CXX=g++ and rustc-1.45.0 has now started, Will report if it succeeds or fails.

Failed.

68:13.27    Compiling gkrust v0.1.0 (/scratch/working/thunderbird-78.0.1/toolkit/library/rust)
74:30.29     Finished release [optimized] target(s) in 73m 05s
74:33.40 toolkit/library/build/symverscript.stub
75:53.38 toolkit/library/build/libxul.so
75:53.38 /usr/bin/ld: /scratch/working/thunderbird-78.0.1/obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/libgkrust.a(gkrust-ff3610aaae1efd41.gkrust.eljv7470-cgu.0.rcgu.o): in function `dbus::message::Message::append_items':
75:53.38 /scratch/working/thunderbird-78.0.1/third_party/rust/dbus/src/message.rs:694: undefined reference to `dbus_message_iter_init_append'
75:53.38 /usr/bin/ld: /usr/bin/ld: DWARF error: mangled line number section (bad file number)
75:53.38 /usr/bin/ld: DWARF error: mangled line number section (bad file number)
75:53.38 /usr/bin/ld: DWARF error: invalid abstract instance DIE ref
75:53.38 /scratch/working/thunderbird-78.0.1/third_party/rust/dbus/src/message.rs:694: undefined reference to `dbus_message_iter_init_append'
(etc)

At the moment I'm unsure if this is a gcc or rustc-1.45.0 problem. So, for the book using our current rustc and clang seems to be the way to go to get this in.

comment:8 by Douglas R. Reno, 14 months ago

Resolution: fixed
Status: assignedclosed

Fixed at r23418

in reply to:  7 comment:9 by ken@…, 14 months ago

Replying to ken@…:

Replying to ken@…:

At the moment I'm unsure if this is a gcc or rustc-1.45.0 problem. So, for the book using our current rustc and clang seems to be the way to go to get this in.

Seems to be a mozconfig problem. Until at least tb-68 it was possible to copy the book's mozconfig and build it, even if dbus-glib was present.

With 78.0.1 the switch to disable dbus is accepted, but appears to only stop the library being referenced. Headers are pulled in (possibly by one of the other deps, not yet investigated) and soem rust dbus crates get compiled.

Note: See TracTickets for help on using tickets.