Opened 3 years ago

Closed 3 years ago

#14142 closed enhancement (fixed)


Reported by: ken@… Owned by: ken@…
Priority: normal Milestone: 10.1
Component: BOOK Version: SVN
Severity: normal Keywords:

Description (last modified by Xi Ruoyao)

This does build using system llvm-11.

At the moment I have not managed to build firefox-esr, or thunderbird. I am hopeful that the gentoo patches for firefox will allow it to build both of these, but I've got a lot of work to do in editing the patches to apply directly, instead of creating extra patch files, e.g. the start of the next hunk that I need to edit:

@@ -486,36 +578,45 @@ impl Group {
+     }
+ }
+-impl fmt::Display for Group {
++impl Display for Group {
++    // We attempt to match libproc_macro's formatting.
++    // Empty parens: ()
++    // Nonempty parens: (...)
++    // Empty brackets: []
++    // Nonempty brackets: [...]
++    // Empty braces: { }
++    // Nonempty braces: { ... }
+     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+-        let (left, right) = match self.delimiter {
++        let (open, close) = match self.delimiter {
+             Delimiter::Parenthesis => ("(", ")"),

The '+ ' are unchanged lines, '+-' deleted lines, '++' added lines', but it's easy to get carried away when editing this.

I expect firefox-78.4.0 to be available on Monday, so I'll be testing the candidate for that before then on older systems.

At the moment, it looks as if the 78.3 series (ff, tbird) need three patches, but 78.4 ff has the first two already applied.

Change History (8)

comment:1 by ken@…, 3 years ago

Owner: changed from blfs-book to ken@…
Status: newassigned

comment:2 by Xi Ruoyao, 3 years ago

Description: modified (diff)

Modified the description to make it to show correct :)

comment:3 by ken@…, 3 years ago

I've now sorted out the patches from gentoo, and confirmed that both firefox and thunderbird will build, and also that they both still build on rustc-1.42.0 even with the patches (there is no requirement for people to upgrade to 1.47.0 until they upgrade to llvm-11). But 1.47.0 does also build on llvm-10.0.1.

Unfortunately, the main part of the patches (gentoo's third, or 0038) is huge. For firefox-78.4 that is the only patch required, but for 78.3 (which thunderbird is still using) all three will be needed (gentoo 0036, 0037, 0038 in that order).

Will build a fresh system to do measurements and final checking, and will then use whichever version of thunderbird is latest.

For the rustc tests I'm down to two failures:

    [run-make] run-make-fulldeps/long-linker-command-lines
    [run-make] run-make-fulldeps/sysroot-crates-are-unstable

The latter is an existing failure, and I see that gentoo apply a patch to disable that (along with several other tests which they regard as broken, e.g. on aarch64) - no point in doing that in BLFS. The long-linker-command-lines test maybe passes if the TMPDIR envvar is set (a closed issue from mac OS, labelled as unreplicated or soemthing like that).

comment:5 by ken@…, 3 years ago

Resolution: fixed
Status: assignedclosed

comment:6 by ken@…, 3 years ago

Closed in error (wrong ticket).

comment:7 by ken@…, 3 years ago

Resolution: fixed
Status: closedreopened

Odd, I clicked on reopen but it lost that.

comment:8 by ken@…, 3 years ago

Patch for firefox-78.4.0, and hopefully for thunderbird-78.4.0 (not yet tested on thunderbird) uploaded to pending testing.

comment:9 by ken@…, 3 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.