Opened 9 months ago

Closed 9 months ago

#14189 closed enhancement (fixed)

libreoffice-7.0.3.1

Reported by: Bruce Dubbs Owned by: Douglas R. Reno
Priority: normal Milestone: 10.1
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

New point version.

Change History (10)

comment:1 by Douglas R. Reno, 9 months ago

Owner: changed from blfs-book to Douglas R. Reno
Status: newassigned

comment:2 by Douglas R. Reno, 9 months ago

This is prelimiary, but I think I have a way to work around the system ICU problem:

sed -i "30a sed -i 's/TRUE/true/' src/lib/EBOOKCharsetConverter.cpp" external/libebook/ExternalProject_libebook.mk

That modifies the commands that Libreoffice uses to build libebook to include that sed.

in reply to:  2 comment:3 by ken@…, 9 months ago

Replying to renodr:

This is prelimiary, but I think I have a way to work around the system ICU problem:

sed -i "30a sed -i 's/TRUE/true/' src/lib/EBOOKCharsetConverter.cpp" external/libebook/ExternalProject_libebook.mk

That modifies the commands that Libreoffice uses to build libebook to include that sed.

Very cool if it works. You might need a 'g' on the sed, the error report was

EBOOKCharsetConverter.cpp:127:7: error: 'TRUE' was not declared in this scope
  127 |       TRUE, TRUE, &status)
      |       ^~~~

Knowing how to change the external files it downloads is a useful development.

in reply to:  2 comment:4 by Bruce Dubbs, 9 months ago

Replying to renodr:

This is prelimiary, but I think I have a way to work around the system ICU problem:

sed -i "30a sed -i 's/TRUE/true/' src/lib/EBOOKCharsetConverter.cpp" external/libebook/ExternalProject_libebook.mk

That modifies the commands that Libreoffice uses to build libebook to include that sed.

It looks to me that you have to take both make and bash syntax into account in the outside sed. It is very tricky to get the backslashes correct. This worked for me:

sed -i 30a\
"\\\\t\tsed -i 's/TRUE/true/' src/lib/EBOOKCharsetConverter.cpp \\\\" \
external/libebook/ExternalProject_libebook.mk

comment:5 by Bruce Dubbs, 9 months ago

Actually it is bash AND sed AND make syntax that need to be taken into account.

Switching quotes makes it a little simpler:

sed -i 30a\
'\\t\tsed -i "s/TRUE/true/g" src/lib/EBOOKCharsetConverter.cpp \\' \
external/libebook/ExternalProject_libebook.mk

comment:6 by Douglas R. Reno, 9 months ago

List of fixed bugs

Bugs fixed compared to 7.0.2 RC2

    ofz#25774 keep ParseCMAP within legal area [Caolán McNamara]
    ofz#25855 overflow in nTmpOffset [Caolán McNamara]
    ofz#25868 timeout, encoding conversion only sane in 0..SAL_MAX_UINT16 range [Caolán McNamara]
    ofz#25881 use std::vector with bounds checking accessor [Caolán McNamara]
    ofz#25908 detect if the SwFrameFormat is deleted [Caolán McNamara]
    ofz#25989 cmap parsing [Caolán McNamara]
    ofz#26122 allow NINSIZE input full elements [Caolán McNamara]
    tdf#64711 Impress is closed on slide show with all hidden slides in presentation or group [Caolán McNamara]
    tdf#67007 UI: Name Box does not show a name in sheet scope when selecting a range [Eike Rathke]
    tdf#77236 FILESAVE: DOCX: Shape color changed to white after roundtrip [Regényi Balázs]
    tdf#100492 SVG export adds extra arrow heads [Samuel Mehrbrodt]
    tdf#105875 FILEOPEN: DOCX: Shape rotation is wrong (see comment 3) [Regényi Balázs]
    tdf#115436 Kenyan Shilling missing as a currency [Eike Rathke]
    tdf#121323 Crash dragging button after un-grouping compound group [Caolán McNamara]
    tdf#122560 Mysql Native Connector - failure to connect to mysql 8 server instance with SHA2 caching [Julien Nabet]
    tdf#122759 AutoFilter list is created not case sensitive but filtering is case sensitive [Attila Szűcs]
    tdf#124013 FILESAVE XLSX Background fill of shapes disappear [Regényi Balázs]
    tdf#124430 Child Textbox separates from shape when align action is used [Bakos Attila]
    tdf#126830 Icons not showing in menus [Maxim Monastirsky]
    tdf#127579 FILEOPEN DOCX: Hyperlink color and underlining gets lost when saving to DOCX [Xisco Fauli]
    tdf#128174 Master password dialog misplaced [Ayhan Yalçınsoy]
    tdf#128212 FILEOPEN PPTX text with z-Rotation has wrong position [Gülşah Köse]
    tdf#129685 FILEOPEN: PPTX: Incorrect paragraph alignment in shape [Miklos Vajna]
    tdf#130445 Toolbar created at Document Scope does not save associated icons. [Maxim Monastirsky]
    tdf#133377 FILESAVE DOCX: Date Document properties mangled during FileOpen/FileSave using Word 2007-365 .docx format [Bartosz Kosiorek]
    tdf#133482 Changing the data table of a graph enlarges the window. [Caolán McNamara]
    tdf#133771 When saving an encrypted document, unchecking 'Save with password' has no effect, encryption is kept [Vasily Melenchuk]
    tdf#133931 KDE5/QT5 VCL & dark theme: Calc: every other function name in Function Wizard list is unreadable [Jan-Marek Glogowski]
    tdf#134351 Wrong Auto Filter Result if all the records are selected [Xisco Fauli]
    tdf#134566 Can't input Japanese characters in Header and Footer Dialog. [Caolán McNamara]
    tdf#134598 Calc's Fill Format Mode function not available after New and Cancel (comment 9) [Caolán McNamara]
    tdf#134784 Paragraph spacing of first paragraph in a text frames is set to 0,42 cm when importing/opening docx [László Németh]
    tdf#134939 Font size fields (and other fields) keep losing focus (GTK3) [Caolán McNamara]
    tdf#135202 LO 6.4.6.1 and 7.0.1 fail with error 1045 when accessing MySQL database using native connector [Julien Nabet]
    tdf#135260 Backspace has only effect on one character after rejecting all changes [Michael Stahl]
    tdf#135370 LO does not refresh screen with Skia/Vulkan and nVidia cards [Luboš Luňák]
    tdf#135518 Locale en-HK is not supported [Eike Rathke]
    tdf#135733 Crash undo paste & cut (swlo!SwDoc::IsInWriterfilterImport) since 7.0 or 7.1) [Michael Stahl]
    tdf#135916 Scroll to top (to cursor) after applying page style at page break (comment 2) [Caolán McNamara]
    tdf#135952 Using 'points' in PNG export dialog causes absurdly large images and possible crash [Luboš Luňák]
    tdf#136036 Garbled icons on Libreoffice 7.0 x64, Windows 10 build 19041.450 (Vulkan) [Luboš Luňák]
    tdf#136176 Wrong object position after filesave and fileopen/reload if slant is used on a vertically flipped object in draw [Regina Henschel]
    tdf#136222 Linear and Axial gradients looks ugly with Skia [Luboš Luňák]
    tdf#136238 Deleting a very very large cross page table (26 pages) very very slow [Xisco Fauli]
    tdf#136267 FILEOPEN XLSX index instead of content of category value in data label in column chart [Balazs Varga]
    tdf#136385 Shapes moves to different position after undo of anchor to page [Michael Stahl]
    tdf#136407 Libre Office Launcher gets weird artifacts around the recent file images (Vulkan) [Luboš Luňák]
    tdf#136430 Crash when tying to move chart data label [Balazs Varga]
    tdf#136441 FILESAVE: Saxparse error on file open (word/footnotes.xml line 2) after save to DOCX & file reload [Justin Luth]
    tdf#136445 RTF import: comment/annotation anchor is in wrong cell (covered cell even) in table [Michael Stahl]
    tdf#136455 GTK3: Unable to open Standard Filter in a file with large quantity of data rows [Caolán McNamara]
    tdf#136520 Text/background Color Palettes can no longer be torn off [Caolán McNamara]
    tdf#136551 FILEOPEN DOTX Template rendered with only one element, missing text and shapes [Miklos Vajna]
    tdf#136555 StartCenter is inconsistent with dark theme(s) [Jan-Marek Glogowski]
    tdf#136573 Ability to move chart data labels with keyboard arrows [Tünde Tóth]
    tdf#136577 [EDITING] "Replace All" does not undo properly if the replacement string is empty [Michael Stahl]
    tdf#136620 FILESAVE: DOC: TextWrap is lost after RT [Michael Stahl]
    tdf#136650 FILEOPEN DOCX Chart with data labels enabled at datapoint level show percentage values as fraction [Balazs Varga]
    tdf#136682 Delete all comments not working after using Format All Comments [Caolán McNamara]
    tdf#136705 UI: Paragraph style dialog oversized because of large tab list [Caolán McNamara]
    tdf#136708 Textbox shrinks to content size on DOC export [Michael Stahl]
    tdf#136728 Crash deleting a table [Xisco Fauli]
    tdf#136799 SVG icons not appearing in Styles tab in sidebar [Caolán McNamara]
    tdf#136830 Imported PPTX group shapes positions are not correct [nd101]
    tdf#136836 EMF import from PPTX: visual problems with large image [Miklos Vajna]
    tdf#136924 Column icons are wrong in dark mode [Jan-Marek Glogowski]
    tdf#136951 i18n: add locale data for Võro [vro-EE] [Mihkel Tõnnov]
    tdf#136983 Wrong setting for DOC properties [Justin Luth]
    tdf#136985 Crash after resolving comment, undoing and opening redo steps [Caolán McNamara]
    tdf#137009 Default time format for French locales in African countries is wrong [Julien Nabet]
    tdf#137016 Crash in: libatk-bridge-2.0.so.0.0.0, when EDITING Relationships [Caolán McNamara]
    tdf#137023 FILEOPEN: PPTX: Text is center aligned instead of left [Miklos Vajna]
    tdf#137038 UI: Crash reporter dialog size is relatively large for German language [Caolán McNamara]
    tdf#137071 Underline not visible in presentation mode if text is also highlighted [Caolán McNamara]
    tdf#137091 XLSX: Error 507 when opened with Turkish locale [Eike Rathke, Xisco Fauli]
    tdf#137165 UI: Data label changes position after closing the Position and Size dialog [Balazs Varga]
    tdf#137180 FILEOPEN RTF Bulleted list has wrong indentation [Miklos Vajna]
    tdf#137201 EDITING: Unable to type to manually change font family when text is partially or fully selected (GTK3) [Caolán McNamara]
    tdf#137209 gtk3: "New Address List" dialog gets broken [Caolán McNamara]
    tdf#137245 Image disappears after AutoFormat applies a paragraph border [Michael Stahl]
    tdf#137248 Calc - AutoCalculate malfunction, always F9 (ReCalculate) necessary [Eike Rathke]
    tdf#137250 with gtk3, keyboard ineffective in Format > Page > Page > Paper Format [Caolán McNamara]
    tdf#137274 Writer: Deleting Comment disables Comments in Navigator [Caolán McNamara]
    tdf#137294 Special Character dialog -- Search operation not updated according to the active font name entry [Caolán McNamara]
    tdf#137345 Transition duration time is set in milliseconds instead of seconds [Caolán McNamara]
    tdf#137369 Some links.txt target point to nonexistent icons [Rizal Muttaqin]
    tdf#137393 Add New Noto CJK font names(V2.001) in front of the previous Noto CJK font names for CJK locale on VCL.xcu [Kevin Suo]
    tdf#137417 FILEOPEN: SMARTART: Incorrect size of shapes [Miklos Vajna]
    tdf#137432 Value of object property is not shown in the Watch window after disable "Use Skia for all rendering" [Caolán McNamara]
    tdf#137446 resize of horizontal line via dialog in Calc introduces faulty 180deg rotation [Regina Henschel]
    tdf#137594 Chinese conversion run all the way through column 1024. [Mark Hung]
    tdf#137608 Maximum page number of 9999 when inserting a manual break with custom page number [Caolán McNamara]

comment:7 by Douglas R. Reno, 9 months ago

Another icu-68 related problem is encountered in libcdr. I've fixed it in a similar way:

libcdr_utils.cpp: In function ‘short unsigned int {anonymous}::getEncoding(const unsigned char*, unsigned int)’:
libcdr_utils.cpp:111:35: error: ‘TRUE’ was not declared in this scope
  111 |     ucsdet_enableInputFilter(csd, TRUE);
sed -i 29a\
'\\t\t&&sed -i "s/TRUE/true/g" src/lib/libcdr_utils.cpp \\' \
external/libcdr/ExternalProject_libcdr.mk

Note that the tarballs for the external projects are downloaded to external/tarballs. There has to be an '&&' there in order for the sed to work because otherwise it gets pulled into the export in the previous line.

comment:8 by Douglas R. Reno, 9 months ago

Yet another icu-68 problem is discovered in libreoffice itself:

/sources/libreoffice-7.0.3.1/libreoffice-7.0.3.1/i18npool/source/calendar/calendar_gregorian.cxx: In member function ‘virtual void i18npool::Calendar_gregorian::setLocalDateTime(double)’:
/sources/libreoffice-7.0.3.1/libreoffice-7.0.3.1/i18npool/source/calendar/calendar_gregorian.cxx:350:40: error: ‘TRUE’ was not declared in this scope
  350 |     body->getTimeZone().getOffset( fR, TRUE, nZoneOffset, nDSTOffset, status );

This one shouldn't be as difficult though:

sed -i 's/TRUE/true/' i18npool/source/calendar/calendar_gregorian.cxx

comment:9 by Douglas R. Reno, 9 months ago

With the changes here, I have a successful build with system ICU!

comment:10 by Douglas R. Reno, 9 months ago

Resolution: fixed
Status: assignedclosed

Fixed at r23865

Note: See TracTickets for help on using tickets.