Fix cheese to build with vala-0.52.x

[Douglas R. Reno]

While rebuilding all of the packages in the GNOME Applications chapter, I've encountered an issue with Cheese:

[26/39] Compiling Vala source ../src/vapi/libcanberra-gtk3.vapi ../src/cheese-application.vala ../src/cheese-countdown.vala ../src/cheese-effects-manager.vala ../src/cheese-main.vala ../src/cheese-preferences.vala ../src/cheese-window.vala
FAILED: src/cheese.p/cheese-application.c src/cheese.p/cheese-countdown.c src/cheese.p/cheese-effects-manager.c src/cheese.p/cheese-main.c src/cheese.p/cheese-preferences.c src/cheese.p/cheese-window.c 
valac -C --debug --debug --pkg posix --pkg gstreamer-1.0 --target-glib ' 2.38.0' --pkg glib-2.0 --pkg gio-2.0 --pkg gdk-pixbuf-2.0 --pkg clutter-1.0 --pkg gtk+-3.0 --pkg clutter-gtk-1.0 --pkg libcanberra /sources/cheese-3.38.0/cheese-3.38.0/src/vapi/eogthumbnav.vapi --pkg gnome-desktop-3.0 /sources/cheese-3.38.0/cheese-3.38.0/src/vapi/config.vapi /sources/cheese-3.38.0/cheese-3.38.0/src/vapi/cheese-thumbview.vapi /sources/cheese-3.38.0/cheese-3.38.0/src/vapi/cheese-common.vapi --color=always --directory src/cheese.p --basedir ../src --gresources=../data/org.gnome.Cheese.gresource.xml ../src/vapi/libcanberra-gtk3.vapi ../src/cheese-application.vala ../src/cheese-countdown.vala ../src/cheese-effects-manager.vala ../src/cheese-main.vala ../src/cheese-preferences.vala ../src/cheese-window.vala
../src/cheese-window.vala:57.5-57.44: warning: [GtkChild] fields must be declared as `unowned'
    private GtkClutter.Embed viewport_widget;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:59.5-59.32: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Widget main_vbox;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:63.5-63.36: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Box thumbnails_right;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:65.5-65.37: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Box thumbnails_bottom;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:67.5-67.50: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Widget leave_fullscreen_button_box;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:69.5-69.41: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Button take_action_button;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:71.5-71.46: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Image take_action_button_image;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:73.5-73.50: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.ToggleButton effects_toggle_button;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:75.5-75.35: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Widget buttons_area;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:77.5-77.43: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Button switch_camera_button;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-window.vala:226.7-226.18: warning: `Gtk.show_uri' has been deprecated since 3.22
../src/cheese-window.vala:1138.59-1138.85: warning: `Clutter.BinAlignment.CENTER' is deprecated
../src/cheese-window.vala:1139.59-1139.85: warning: `Clutter.BinAlignment.CENTER' is deprecated
../src/cheese-window.vala:1238.23-1238.33: error: Access to private member `GLib.GenericArray.len' denied
      for (i = 0; i < cameras.len; i++)
                      ^^^^^^^^^^^
../src/cheese-window.vala:1240.40-1240.52: error: The name `index' does not exist in the context of `GLib.PtrArray?' (glib-2.0)
          next = (Cheese.CameraDevice )cameras.index (i);
                                       ^^^^^^^^^^^^^
../src/cheese-window.vala:1248.19-1248.29: error: Access to private member `GLib.GenericArray.len' denied
      if (i + 1 < cameras.len)
                  ^^^^^^^^^^^
../src/cheese-window.vala:1250.40-1250.52: error: The name `index' does not exist in the context of `GLib.PtrArray?' (glib-2.0)
          next = (Cheese.CameraDevice )cameras.index (i + 1);
                                       ^^^^^^^^^^^^^
../src/cheese-window.vala:1254.40-1254.52: error: The name `index' does not exist in the context of `GLib.PtrArray?' (glib-2.0)
          next = (Cheese.CameraDevice )cameras.index (0);
                                       ^^^^^^^^^^^^^
../src/cheese-window.vala:1291.11-1291.21: error: Access to private member `GLib.GenericArray.len' denied
      if (cameras.len > 1)
          ^^^^^^^^^^^
../src/cheese-preferences.vala:32.5-32.47: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.ComboBox photo_resolution_combo;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:34.5-34.47: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.ComboBox video_resolution_combo;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:36.5-36.37: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.ComboBox source_combo;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:41.5-41.48: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Adjustment brightness_adjustment;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:43.5-43.46: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Adjustment contrast_adjustment;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:45.5-45.41: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Adjustment hue_adjustment;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:47.5-47.48: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.Adjustment saturation_adjustment;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:50.5-50.44: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.SpinButton burst_repeat_spin;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:52.5-52.43: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.SpinButton burst_delay_spin;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:55.5-55.43: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.CheckButton countdown_check;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:57.5-57.39: warning: [GtkChild] fields must be declared as `unowned'
    private Gtk.CheckButton flash_check;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/cheese-preferences.vala:364.9-364.19: error: Access to private member `GLib.GenericArray.len' denied
    if (devices.len > camera_model.iter_n_children (null))
        ^^^^^^^^^^^
../src/cheese-preferences.vala:366.35-366.47: error: The name `index' does not exist in the context of `GLib.PtrArray?' (glib-2.0)
      dev = (Cheese.CameraDevice) devices.index (devices.len - 1);
                                  ^^^^^^^^^^^^^
../src/cheese-preferences.vala:453.13-453.23: error: Access to private member `GLib.GenericArray.len' denied
        if (devices.len > 0)
            ^^^^^^^^^^^
../src/cheese-preferences.vala:279.13-279.24: warning: `Gtk.show_uri' has been deprecated since 3.22
../src/cheese-application.vala:511.13-511.24: warning: `Gtk.show_uri' has been deprecated since 3.22
Compilation failed: 9 error(s), 26 warning(s)
ninja: build stopped: subcommand failed.
7.9 Elasped Time - cheese-3.38.0
renodr [ /sources ]$ 

Looking at gitlab, it looks like ​https://gitlab.gnome.org/GNOME/cheese/-/merge_requests/41/diffs#d365d8ff91f49ea30d0abdb0f198cb8772c53f83 might do the trick.

[Douglas R. Reno]

I've added the patch that I came up with to both Git and SVN

[Douglas R. Reno]

Fixed at r24455

[Bruce Dubbs]

Milestone renamed