Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15203 closed enhancement (fixed)

polkit-qt-0.114.0

Reported by: Bruce Dubbs Owned by: Bruce Dubbs
Priority: normal Milestone: 11.0
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

New minor version.

Change History (5)

comment:1 by Bruce Dubbs, 4 years ago

Owner: changed from blfs-book to Bruce Dubbs
Status: newassigned

comment:2 by Bruce Dubbs, 4 years ago

There are no notes on what has changed, but a diff of source looks like a general cleanup of the code. The license has changed to LGPL-2.0.

It may be related to polkit vulnerability CVE-2021-3560, but I cannot verify that.

comment:3 by Bruce Dubbs, 4 years ago

Resolution: fixed
Status: assignedclosed

Fixed at commit 1d37205060c65980c7fb03c1714a9d025283c5e6

Package Updates.
    Update to Text-CSV-2.01 (Perl module).
    Update to polkit-qt-1-0.114.0.

comment:4 by Douglas R. Reno, 4 years ago

Make it compile without deprecated method 
Support API documentation generation with kapidox 
API dox: reference KDE Frameworks, no longer KDE Development Platform 
Use more nullptr 
Use Q_DECLARE_OPERATORS_FOR_FLAGS in same namespace as flags definition
   Having the macro's definition of the operator| in the namespace of the
   flags argument improves/unbreaks things for the argument-dependent
   lookup of unqualified function names, e.g. when flags are combined in
   calls of other methods, but there is some other operator| defined in the
   namespace of the current code.
   Given Q_DECLARE_OPERATORS_FOR_FLAGS creates inlined functions, this
   should be a source and binary compatible change.
   Qt did similar for Qt 5.12 in
   https://codereview.qt-project.org/c/qt/qtbase/+/225348
Make use of PkgConfig to find dependencies
   It provides imported targets which makes everything much nicer and allows to drop            
   the custom find modules
Fix typos 
Port from Q_ENUMS to Q_ENUM
   Q_ENUM is new in Qt 5.5, replacing Q_ENUMS. It automatically declares
   the passed enum as a QMetaType, so we can stop doing that manually.
Remove .arcconfig
   Phabricator is dead, use gitlab instead.
Let cmake set the C++ standard
   This raises the required cmake version to 3.1, which shouldn't be a
   problem and actually avoids a warning with newer cmakes about
   dropping compatibility with cmake < 2.8.12.
Enable CMAKE_AUTOUIC and CMAKE_AUTORCC
   Not only saves a few lines it also helps when porting to Qt6, because
   we don't need to handle the version contained in the macro name.
Remove unused cmake macro files
   MacroPushRequiredVars.cmake:
   usage dropped in baebdf2
   MacroWriteBasicCMakeVersionFile.cmake & BasicFindPackageVersion.cmake.in:
   usage dropped in c0d8692
   InstallSettings.cmake:
   usage dropped in fda675b
   FindGLIB2.cmake:
   usage dropped in f909181
Convert license statements to SPDX expressions
   Also add/move license files as required by REUSE specification
Use QStringLiteral 
Fully qualify slot argument 
Port away from legacy LINK_PUBLIC & LINK_PRIVATE 
Use more nullptr 
Use more override 
Remove unneeded/unused include_directories 
Remove unused include 
Remove module prefix from Qt includes of non-oublic headers 
Link polkit-qt-test to agent lib target, an include is used 
Remove module prefix from Qt includes in public headers 
Remove outdated template FindPolkitQt.cmake
   Left-over from times before CMake config files were adopted
Use individual export headers/macros per each library
   While with compilers on the unixoid systems the visibility technologies
   results in Q_DECL_EXPORT & Q_DECL_IMPORT being set to the same value,
   an attribute for visibility, this would break once some compiler does
   do things like on windows.
Generate version & config file in core build dir
   Used only by core library, so avoid additional include dir with
   the toplevel build dir
Set include dirs for linking libraries during build by target interface 
   Include headers in example & test like external consumer would
   By linking to the targets the build specific indlude dirs for the
   respective libraries are provided, and the headers being in the
   respective library's toplevel dir matches the case of the installed
   variant
   Makes copying code of the example easier, less to adapt when using
   outside of the project.
Use target_sources to directly set sources instead of helper vars
   Needs CMake 3.11 for add_library() supporting no sources initially passed.
Drop PolkitQt1::version*() API declaration, never implemented
   Seems the version header once was inspired by kdelibs'
   kdecore/util/kdeversion.h.cmake but missed out the cpp counterpart.
   Given no-one has ever complained about the missing runtime-version check
   option, just dropping it then.
Use feature_summary() 
Bump version for upcoming release 

Lots of license changes, build system fixes, and code maintenance, but nothing too major here

comment:5 by Bruce Dubbs, 4 years ago

Milestone: 10.211.0

Milestone renamed

Note: See TracTickets for help on using tickets.