Attachments (2)
Change History (12)
comment:1 by , 18 years ago
comment:2 by , 15 years ago
| Milestone: | future → 6.4 |
|---|---|
| Owner: | changed from to |
I've long thought this format was mostly unused. But the gnome devs disagree (recent gtk+ requires you to use --without-libjasper if you don't have the shared version installed), and it crops up in other places - ghostscript-8.63, ImageMagick, kdelibs-4.1.x). Surprisingly, when I looked at its use in ghostscript, google told me it was used in Amazon ebooks.
With the recent vulnerabilities, I think we ought to have a patched and current version in the book (the vulnerabilities only mention the current version, but debian patch the older version they also ship). Changing to 6.4.
follow-up: 4 comment:3 by , 15 years ago
So, I (finaly) have a patch that adds Jasper. Satisfied, Ken?
Also fixed in this patch:
- Fixed URW fonts location for kdelibs
- Updated Ghostscript to 8.63
- Updated GSView to 4.9
Please use my patch, the XML is valid.
follow-up: 5 comment:4 by , 15 years ago
Replying to willimm:
So, I (finaly) have a patch that adds Jasper. Satisfied, Ken?
Also fixed in this patch:
- Fixed URW fonts location for kdelibs
- Updated Ghostscript to 8.63
- Updated GSView to 4.9
Please use my patch, the XML is valid.
I'm not Ken, and I'll certainly leave this to the BLFS editors to really verify your patch, but one thing I noticed is that your patch does not include the jasper.xml file. Might wanna redo it.
comment:5 by , 15 years ago
Replying to thomasp@…:
I'm not Ken, and I'll certainly leave this to the BLFS editors to really verify your patch, but one thing I noticed is that your patch does not include the jasper.xml file. Might wanna redo it.
Redone it. Added jasper to the patch.
by , 15 years ago
| Attachment: | blfs-wi-fixes.2.patch added |
|---|
Vairous fixes, including the addition of Jasper.
by , 15 years ago
| Attachment: | blfs-wi-fixes.patch added |
|---|
Vairous fixes, including the addition of Jasper.
follow-up: 7 comment:6 by , 15 years ago
| Status: | new → assigned |
|---|
Normally, these comments would be better in email, but I don't have your address. Sorry for filling up the mailboxes of everyone else subscribed to -book.
As Bruce said, too many different things in one patch makes it hard to revue. I see you've attached something to the ghostscript and URW fonts tickets, but they're not mine.
For gsview, I'm not touching it because it is a gtk+-1.2 application.
Specific comments on the JasPer part of the patch:
- The ftp download cannot be right if it has a different size and md5sum.
- The md5sum and size (for the http version) don't match mine, I think you probably forgot to update them from whatever you copied.
- I don't install the static lib (that's standard for me, as you'll notice), but I can't agree your buildsize and time. The SBU time I won't quibble about, I expect it to vary from machine to machine and from build-host to build-host, but the size suggests you haven't counted the documentation although you install it. I also think the README file isn't worth installing (it just says what the two pdf files are), but that is a matter of choice.
- In dependencies you don't mention xorg. I also have an optional pair of switches for people who install it in uncommon prefixes. I also have differences of style - doesn't seem worth listing exactly what a dependency provides if everyone is likely to have it anyway.
- I don't agree that the utility programs are restricted to jpeg2000 images: they all appear to be for bmp, jps, jpc, jpg, pgx, pnm, mif, ras (according to the pdf) and certainly imginfo [ -f ] and jiv do work on jpg files.
Other than that, and ignoring changelog entries until the commit is made, it looks good. I was already working on this, but I see now that trac thinks I only own it. For the future, an email offering to create a patch *before* you spend a lot of time on it, will reduce wasted effort. Setting ticket to accepted.
I'm out of time tonight, updating the package will have to wait.
follow-up: 8 comment:7 by , 15 years ago
Replying to ken@…:
Normally, these comments would be better in email, but I don't have your address. Sorry for filling up the mailboxes of everyone else subscribed to -book.
As Bruce said, too many different things in one patch makes it hard to revue. I see you've attached something to the ghostscript and URW fonts tickets, but they're not mine.
OK.
For gsview, I'm not touching it because it is a gtk+-1.2 application.
Have it your way, mac.
Specific comments on the JasPer part of the patch:
- The ftp download cannot be right if it has a different size and md5sum.
- The md5sum and size (for the http version) don't match mine, I think you probably forgot to update them from whatever you copied.
I didden't update both because I am too lazy to do that. (BTW, I started with the Giflib XML file for the Jasper page.)
- I don't install the static lib (that's standard for me, as you'll notice), but I can't agree your buildsize and time. The SBU time I won't quibble about, I expect it to vary from machine to machine and from build-host to build-host, but the size suggests you haven't counted the documentation although you install it. I also think the README file isn't worth installing (it just says what the two pdf files are), but that is a matter of choice.
Yea, I will mention --disable-static later in my patch.
- In dependencies you don't mention xorg. I also have an optional pair of switches for people who install it in uncommon prefixes. I also have differences of style - doesn't seem worth listing exactly what a dependency provides if everyone is likely to have it anyway.
I will also do that too.
- I don't agree that the utility programs are restricted to jpeg2000 images: they all appear to be for bmp, jps, jpc, jpg, pgx, pnm, mif, ras (according to the pdf) and certainly imginfo [ -f ] and jiv do work on jpg files.
I will update it.
Other than that, and ignoring changelog entries until the commit is made, it looks good. I was already working on this, but I see now that trac thinks I only own it. For the future, an email offering to create a patch *before* you spend a lot of time on it, will reduce wasted effort. Setting ticket to accepted.
I'm out of time tonight, updating the package will have to wait.
OK.
comment:8 by , 15 years ago
Replying to willimm:
I will update it.
You'll be wasting your time. I'm ready to commit my own version (and, I forgot to add that I didn't see any reference to the patch in your version).
JasPer latest version jasper-1.701.0 from http://www.ece.uvic.ca/~mdadams/jasper/
Dependencies: Unzip, IJG JPEG (http://www.ijg.org), Xorg or XFree86, OpenGL, GLUT and DMalloc (http://dmalloc.com).
If there are incompatibilities with jpeg library it is possible to pass the --disable-libjpeg switch and in case OpenGL is not installed --disable-opengl; can use dmalloc for debugging with the --enable-dmalloc switch.