Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#16195 closed defect (fixed)

unneeded instructions in SCons-4.3.0

Reported by: Joe Locash Owned by: Bruce Dubbs
Priority: normal Milestone: 11.2
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

In the build instructions:

sed -i 's:build/doc/man/::' setup.cfg

is no longer needed.

Nor is

cp scons{,ign}.1 /usr/share/man/man1

since the install does it.

Change History (10)

comment:1 by Xi Ruoyao, 2 years ago

Summary: SCons-4.3.0unneeded instructions in SCons-4.3.0
Type: taskenhancement

Don't make the title looks like a new release.

comment:2 by Douglas R. Reno, 2 years ago

Type: enhancementdefect

comment:3 by Bruce Dubbs, 2 years ago

Owner: changed from blfs-book to Bruce Dubbs
Status: newassigned

comment:4 by Bruce Dubbs, 2 years ago

I agree that the sed for setup.cfg is no longer aplicable, but without the cp command the .1 files end up in /usr/lib/python3.10/site-packages/SCons-4.3.0-py3.10.egg/

The --install-data=/usr/share/man/man1 option does not do anything.

We probably need to do

mv /usr/lib/python3.10/site-packages/SCons-4.3.0-py3.10.egg/*.1 \
   /usr/share/man/man1

The current instructions do not install scons-time.1.

comment:5 by Bruce Dubbs, 2 years ago

Resolution: fixed
Status: assignedclosed

Fixed at commit 32f5b6fad4f523208330df45efeccb1d7ae171dd

Package updates. 
    Update to gtk+-3.24.33.
    Update to pipewire-0.3.48.
    Update to UnRar-6.1.6.

Refine instructions for SCons-4.3.0.

comment:6 by Joe Locash, 2 years ago

This ticket is closed but I don't see any *.1 files getting installed in /usr/lib/python3.10/site-packages/SCons-4.3.0-py3.10.egg ?

When I do a build. I also do a DESTDIR install and save it to compare to what was installed. There are no .1 files in that backup either.

comment:7 by Bruce Dubbs, 2 years ago

For a DESTDIR install, you need pass $DEST to setup and to manually create $DEST/usr/share/man/man1/

BUILDDIR=/build/scons
DEST=$BUILDDIR/install

sed -i 's/env python/&3/' SCons/Utilities/*.py

python3 setup.py install --prefix=$DEST/usr  --optimize=1 

mkdir -p $DEST/usr/share/man/man1
mv $DEST/usr/lib/python3.10/site-packages/SCons-4.3.0-py3.10.egg/*.1 \
             $DEST/usr/share/man/man1

comment:8 by Joe Locash, 2 years ago

For a python DESTDIR build I prefer using "python3 setup.py --root=$DEST ..".

I didn't realize you removed --install-data=/usr/share/man/man1 from the book. That does indeed install the man pages in /usr/share/man/man1.

comment:9 by Bruce Dubbs, 2 years ago

When I tested, --install-data did nothing for me. I could not find where the files were installed.

comment:10 by Joe Locash, 2 years ago

Try this:

sed -i 's/env python/&3/' SCons/Utilities/*.py
python3 setup.py install --root=dest --optimize=1 --install-data=/usr/share/man/man1                        

then ls -R dest/ to see what would get installed.

Note: See TracTickets for help on using tickets.