Opened 2 years ago

Closed 2 years ago

#16276 closed enhancement (fixed)

apache-httpd patch: do not change owner to root

Reported by: pierre Owned by: pierre
Priority: normal Milestone: 11.2
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description (last modified by pierre)

The httpd-blfs_layout patch changes install instructions so that all files are installed as root. This prevents using a DESTDIR install as a normal user. This is not what upstream intents. And this is not what current practice is in other packages.

Note that if installing as root, there is no need to use "install -o" or "chown root" anyway.

So we should remove that from the patch. Rediffing is needed for 2.54.3 anyway since the patch does not apply.

Change History (3)

comment:1 by pierre, 2 years ago

Description: modified (diff)

It is somewhat stupid to change owner only of certain files and not all the installed files, actually...

comment:2 by pierre, 2 years ago

Ooops, sorry, there are files installed without changing the owner, and these need to be fixed. But not by using chown/install -o. I think what should be done is replace "cp -p" with "cp --preserve=mode", or remove the "-p" and use chmod if needed. Actually files installed with -p do not seem to have special permissions... The only result is as if installed with "--preserve=timestamps", but frankly, is it needed? The previous patch was using "install" instead of "cp" at some places, so the timestamps were lost too.

comment:3 by pierre, 2 years ago

Resolution: fixed
Status: assignedclosed

Fixed patch at commit 4d0e033cc6b in the patch repo.

Fixed at commits e6ec6d6b40 and 710cd22f3.

Note: See TracTickets for help on using tickets.