gst-plugins-{bad,ugly} now needs -Dgpl=enabled

[Joe Locash]

Noticed that some plugins weren't built when building these packages. Some plugins now require -Dgpl=enabled to be passed to meson. From the NEWS file:

Explicit opt-in required for build of certain plugins with (A)GPL dependencies

Some plugins have GPL- or AGPL-licensed dependencies and those plugins
will no longer be built by default unless you have explicitly opted in
to allow (A)GPL-licensed dependencies by passing -Dgpl=enabled to Meson,
even if the required dependencies are available.

[Bruce Dubbs]

Can you determine which plugins are affected by this? It sounds like we just need to add an entry in the Command Explanations sections documenting which plugins are affected.

[Xi Ruoyao]

For gst-plugins-bad, the affected plugins are x265 and faad. (There are other plugins affected, but in BLFS we don't have dependencies to build them anyway.)

[Joe Locash]

From ​https://gitlab.freedesktop.org/gstreamer/gstreamer

Building plugins with (A)GPL-licensed dependencies

Some plugins have GPL- or AGPL-licensed dependencies and will only be built
if you have explicitly opted in to allow (A)GPL-licensed dependencies by
passing -Dgpl=enabled to Meson.

List of plugins with (A)GPL-licensed dependencies (non-exhaustive) in gst-plugins-bad:

  dts (DTS audio decoder plugin)
  faad (Free AAC audio decoder plugin)
  iqa (Image quality assessment plugin based on dssim-c)
  mpeg2enc (MPEG-2 video encoder plugin)
  mplex (audio/video multiplexer plugin)
  ofa (Open Fingerprint Architecture library plugin)
  resindvd (Resin DVD playback plugin)
  x265 (HEVC/H.265 video encoder plugin)

List of plugins with (A)GPL-licensed dependencies (non-exhaustive) in gst-plugins-ugly:

  a52dec (Dolby Digital (AC-3) audio decoder plugin)
  cdio (CD audio source plugin based on libcdio)
  dvdread (DVD video source plugin based on libdvdread)
  mpeg2dec (MPEG-2 video decoder plugin based on libmpeg2)
  sidplay (Commodore 64 audio decoder plugin based on libsidplay)
  x264 (H.264 video encoder plugin based on libx264)

For plugins-bad I also noticed rsvg wasn't built.

[Xi Ruoyao]

Replying to Joe Locash:

List of plugins with (A)GPL-licensed dependencies (non-exhaustive) in gst-plugins-ugly:

  a52dec (Dolby Digital (AC-3) audio decoder plugin)
  cdio (CD audio source plugin based on libcdio)
  dvdread (DVD video source plugin based on libdvdread)
  mpeg2dec (MPEG-2 video decoder plugin based on libmpeg2)
  sidplay (Commodore 64 audio decoder plugin based on libsidplay)
  x264 (H.264 video encoder plugin based on libx264)

I guess at least for ugly we need to add -Dgpl=enabled: if it's disabled, literally no plugins will be built for BLFS.

And for ffmpeg we already enabled those GPL dependencies. So I think it's consistent to just add -Dgpl=enabled for both gst-bad and gst-ugly.

[Bruce Dubbs]

Thanks for the research. I'll use that to update the book.

[Bruce Dubbs]

Upon review, this needs to go with #16233. Reassigning.

[Bruce Dubbs]

Fixed at commit 34f274f32c650baf7d657397446b3cba0f64ccf9