Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16432 closed enhancement (fixed)

Add libreoffice patch to fix build failures with poppler-22.04.0

Reported by: Douglas R. Reno Owned by: pierre
Priority: normal Milestone: 11.2
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

Change History (12)

comment:1 by ken@…, 3 years ago

I mailed Marty off-list, he did create the patch himself but it only works with poppler-22.04, anyone who is trying to build current LO on older poppler will find it doesn't work.

I spent some time trying to get it suitable for upstream - in theory (according to my understanding) that just means formatting the changes as

#if POPPLER_CHECK_VERSION(22, 4, 0)

(do new version)

#else

(do current version with code for 22.03 and earlier)

#endif

but I think I did that correctly and ended up with a different error on the first item ! Still mulling it over, no ideas at the moment.

comment:2 by martyj19, 3 years ago

That's not exactly accurate. If you are trying to build LO against older poppler you simply don't apply that patch.

comment:3 by pierre, 3 years ago

There is a patch at freebsd (similar to Marty's, but with the #if): https://cgit.freebsd.org/ports/commit/?id=d9b5ef800dbd0366eae81b03bfa89689ec73c6f7 Note that it also includes the fix for 22.03. Will try it.

Last edited 3 years ago by pierre (previous) (diff)

comment:4 by Bruce Dubbs, 3 years ago

I am waiting for a new release from upstream. It should be available any day now.

comment:5 by pierre, 3 years ago

I checked the libreoffice development repository, and none of those patches are there...

comment:6 by Bruce Dubbs, 3 years ago

OK. If you want to add the patches, go ahead. I'll note that we get releases from

https://download.documentfoundation.org/libreoffice/src/

And there is 7.3.3/libreoffice-7.3.3.2.tar.xz as of 29-Apr-2022, but we check for

https://download.documentfoundation.org/libreoffice/stable/

and 7.3.2 is still listed there. 7.3.3 is also in testing/.

comment:7 by pierre, 3 years ago

The sed for bison is not needed anymore

comment:8 by pierre, 3 years ago

There is a problem with java-18: it fails to build libreoffice java part...

comment:9 by pierre, 3 years ago

Seems there is a patch upstream; https://cgit.freedesktop.org/libreoffice/core/commit/?id=19de5d97efbb80e9767bc6b873bcc2c263a721de

I think it is enough to export ANT_OPTS="-Djava.security.manager=allow"

But this need testing...

Alternatively the whole patch can be used

Last edited 3 years ago by pierre (previous) (diff)

comment:10 by pierre, 3 years ago

exporting ANT_OPTS allowed building. I think I'll be able to update libreoffice as soon as it comes out (version 7.3.3).

comment:11 by pierre, 3 years ago

Owner: changed from blfs-book to pierre
Status: newassigned

7.3.3.2 is out. This is the same md5sum as the tarball I have tested... taking this ticket together with the update one.

comment:12 by pierre, 3 years ago

Resolution: fixed
Status: assignedclosed

This one is fixed: commit 0370cf446d in the patches repo.

Last edited 3 years ago by pierre (previous) (diff)
Note: See TracTickets for help on using tickets.