firefox-91.0esr ftbfs with cbindgen >= 0.24.2.

[ken@…]

This was a bear to find - the error was very early,

 0:47.88 /scratch/working/firefox-91.10.0/firefox-build-dir/dist/include/mozilla/webrender/webrender_ffi_generated.h:24:33: error: redefinition of 'constexpr const uint64_t mozilla::wr::ROOT_CLIP_CHAIN'
 0:47.88    24 | constexpr static const uint64_t ROOT_CLIP_CHAIN = ~0;
 0:47.88       |                                 ^~~~~~~~~~~~~~~

but the build continued to

 10:12.90    Compiling gkrust v0.1.0 (/scratch/working/firefox-91.10.0/toolkit/library/rust)
14:05.14     Finished release [optimized] target(s) in 13m 35s
14:05.14 warning: the following packages contain code that will be rejected by a future version of Rust: cascade_bloom_filter v0.1.0 (/scratch/working/firefox-91.10.0/toolkit/components/cascade_bloom_filter), cert_storage v0.0.1 (/scratch/working/firefox-91.10.0/security/manager/ssl/cert_storage), rental v0.5.6
14:05.15 note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
14:05.30 make[2]: *** [/scratch/working/firefox-91.10.0/config/recurse.mk:34: compile] Error 2

This appears to be ​https://bugzilla.mozilla.org/show_bug.cgi?id=1773336 for which the recommended fix for 91esr is from comment 10: "Just remove the constant from webrender_ffi.h, or use an older cbindgen? Trunk builds with the newer cbindgen already."

i.e. already fixed in firefox 101.0 and later.

Not yet tested, and maybe also applies to thunderbird. Looks as if

sed -i '/ROOT_CLIP_CHAIN/d' gfx/webrender_bindings/webrender_ffi.h

should fix it. Will find out tomorrow. If it works, I'll label it as "apply a fix for cbindgen-0.24.2 and later".

[ken@…]

Thunderbird needs the same fix. For the avoidance of doubt, seamonkey is ok as-is.

[ken@…]

Fixed in c4e7ae24d81bf7c41dc5d56b9adf4bb3306d5d47 11.1-699

[ken@…]

Update: I misread the affected versions, the fix is in 103. The sed will still be needed in 102 (ask me how I know).