libXpm-3.5.15 (Xorg Library)

[Douglas R. Reno]

New security release, details in ​https://lists.x.org/archives/xorg-announce/2023-January/003312.html

[Xi Ruoyao]

We need --disable-open-zfile or it will require compress, which is not in LFS or BLFS.

[Xi Ruoyao]

Some tests fail like

ERROR: XpmCreate - Bail out! ERROR:TestAllFiles.h:80:TestAllFilesByType: assertion failed (err == NULL): Error opening directory ?/home/xry111/sources/xc/lib/libXpm-3.5.15/test/pixmaps/good/generated?: No such file or directory (g-file-error-quark, 4)
ERROR: XpmWrite - Bail out! ERROR:TestAllFiles.h:80:TestAllFilesByType: assertion failed (err == NULL): Error opening directory ?/home/xry111/sources/xc/lib/libXpm-3.5.15/test/pixmaps/good/generated?: No such file or directory (g-file-error-quark, 4)
ERROR: XpmRead - Bail out! ERROR:TestAllFiles.h:80:TestAllFilesByType: assertion failed (err == NULL): Error opening directory ?/home/xry111/sources/xc/lib/libXpm-3.5.15/test/pixmaps/good/generated?: No such file or directory (g-file-error-quark, 4)

It looks like they are related to --disable-open-zfile. But I don't want to add compress command into LFS/BLFS because nobody should use it in 2023 IMO.

[Bruce Dubbs]

It looks like they didn't get this right. I checked ./configure --help and it says:

--enable-open-zfile     Search for files with .Z & .gz extensions
                        automatically [default=auto]

But a simple ./configure gives:

checking for compress... no
configure: error: compress not found, set XPM_PATH_COMPRESS or use --disable-stat-zfile

It also looks like they are conflating .Z files and .gz files. Actually, I think gzip can handle .Z files.

[Xi Ruoyao]

Replying to Bruce Dubbs:

It looks like they didn't get this right. I checked ./configure --help and it says:

--enable-open-zfile     Search for files with .Z & .gz extensions
                        automatically [default=auto]

But a simple ./configure gives:

checking for compress... no
configure: error: compress not found, set XPM_PATH_COMPRESS or use --disable-stat-zfile

It also looks like they are conflating .Z files and .gz files. Actually, I think gzip can handle .Z files.

gzip provides the uncompress command, which can handle .Z files. But it looks like this package needs compress command as well (for writing .Z files?)

[Xi Ruoyao]

Replying to Xi Ruoyao:

Replying to Bruce Dubbs:

It looks like they didn't get this right. I checked ./configure --help and it says:

--enable-open-zfile     Search for files with .Z & .gz extensions
                        automatically [default=auto]

But a simple ./configure gives:

checking for compress... no
configure: error: compress not found, set XPM_PATH_COMPRESS or use --disable-stat-zfile

It also looks like they are conflating .Z files and .gz files. Actually, I think gzip can handle .Z files.

gzip provides the uncompress command, which can handle .Z files. But it looks like this package needs compress command as well (for writing .Z files?)

On my system there are no .Z files in /usr hierarchy.

[Xi Ruoyao]

I think we can just force XPM_PATH_COMPRESS=/usr/bin/compress, list compress as an external runtime optional dependency, and claim that the test suite does not work.

[Bruce Dubbs]

I tried XPM_PATH_COMPRESS=/usr/bin/gzip and it 'almost' worked.

make check failed. Then I tried 'sudo ln -s gzip /usr/bin/compress' and got it to 8 PASS and 1 ERROR.

[Xi Ruoyao]

Or maybe we can just install ​https://vapier.github.io/ncompress/ ?

I think it will be < 0.1 SBU.

[Bruce Dubbs]

I really dislike adding a package just for tests. We already have some packages that are not really useful (ed, reiserfsprogs, others).

I tried to find a place to raise an issue upstream, but couldn't find it.

I'd just as soon use './configure XPM_PATH_COMPRESS=/dev/null' and say that the checks are broken (they are).

[Xi Ruoyao]

Replying to Bruce Dubbs:

I really dislike adding a package just for tests. We already have some packages that are not really useful (ed, reiserfsprogs, others).

I tried to find a place to raise an issue upstream, but couldn't find it.

​https://gitlab.freedesktop.org/xorg/lib/libxpm/-/issues

I'd just as soon use './configure XPM_PATH_COMPRESS=/dev/null' and say that the checks are broken (they are).

[pierre]

Looks like there is now a MR that fixes the compress issue in tests: ​https://gitlab.freedesktop.org/xorg/lib/libxpm/-/merge_requests/11

I've not tested yet.

[Bruce Dubbs]

Looking at the Xorg Libraries page, we say that four packages have test suites, but those do not include libXpm. Let's just leave it that way and add --disable-open-zfile to the case statement.

I suppose we can add compress as an optional external dependency.

[Bruce Dubbs]

Used 'sed -i '/TestAll.*TRUE/s|^{||' test/TestAllFiles.h' to make the tests pass.}

Fixed at commit 4d91a5b021ad5ac7272e1100095f3a9f2ea618b3