Opened 15 months ago

Closed 7 months ago

#17618 closed enhancement (fixed)

cairo-1.18.0 (new download location)

Reported by: ken@… Owned by: Douglas R. Reno
Priority: normal Milestone: 12.1
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description (last modified by Xi Ruoyao)

New minor version.

I've just seen a report on pixls.us that latest cairo broke the curves tool on gimp https://discuss.pixls.us/t/what-happened-to-gimp-curves/35232 and that arch have fixed it with a revert in their 1.17.8-2 build:

# https://bugs.archlinux.org/task/77432
# https://gitlab.freedesktop.org/cairo/cairo/-/issues/639
git revert -n 47a21c6e30eef91db503a5a183d5c8cf558aaa56

Ignore the comment there that the revert doesn't fully fix it, comments 14,15 at pixls.us explains that.

Looks like it might be a bug in gimp code

https://gitlab.gnome.org/GNOME/gimp/-/issues/9132

but reverting whatever is in that commit as a tmeporary measure might be easier.

Change History (18)

comment:1 by ken@…, 15 months ago

There is a first attempt at a gimp fix referenced on that ticket, further fix proposed to avoid divide by zero.

comment:2 by Bruce Dubbs, 15 months ago

It's a gimp problem.

Please check the diff at https://gitlab.gnome.org/GNOME/gimp/-/commit/2d59d233efd4616b312bb3ca205af9fe86cb6998

sed -e '/(bg_color)/i    \
  y    = MAX (y,    0);  \
  bg_y = MAX (bg_y, 0);' \
    -i app/widgets/gimphistogramview.c

I checked that the sed above applies, but have not rebuilt gimp.

in reply to:  2 comment:3 by ken@…, 15 months ago

Replying to Bruce Dubbs:

It's a gimp problem.

Please check the diff at https://gitlab.gnome.org/GNOME/gimp/-/commit/2d59d233efd4616b312bb3ca205af9fe86cb6998

sed -e '/(bg_color)/i    \
  y    = MAX (y,    0);  \
  bg_y = MAX (bg_y, 0);' \
    -i app/widgets/gimphistogramview.c

I checked that the sed above applies, but have not rebuilt gimp.

Thanks. I thought we were using 1.17.8, but unless my local copy of the book has totally missed it we are still on 1.17.6. I've just posted on -dev about that, 1.17.8 is in a snapshots directory.

Now using meson, and the GL and GLES backends have been removed.

comment:4 by ken@…, 15 months ago

Resolution: invalid
Status: newclosed

If we are not going to use 1.17.8 then there is no way of testing if the sed will solve the problem, and no need. Closing as invalid.

comment:5 by pierre, 15 months ago

Milestone: 11.399-Waiting
Resolution: invalid
Status: closedreopened
Summary: gimp curves tool broken by cairo-1.17.8.gimp curves tool broken by cairo-1.17.8 (wait for cairo-1.17.8 to be released at GNOME).

Actually, only cairo-1.16.O is deemed stable by cairo website. But GNOME have been using the 1.17 series in their downloads. So I suspect cairo-1.17.8 will land into gnome downloads soon. Reopening, since we might want to keep an eye on this.

comment:6 by ken@…, 14 months ago

Meanwhile, we have updated to babl-0.1.102 and gegl-0.4.42.

With that version of babl, the installed pkgconfig file is now /usr/lib/pkgconfig/babl-0.1.pc instead of the previous /usr/lib/pkgconfig/babl.pc, causing gimp-2.10.23 to fail to configure:

Error: GIMP configuration failed.

  - Error: missing dependency babl >= 0.1.78

I think we want a separate ticket for gimp-2.10.34.

comment:7 by Xi Ruoyao, 7 months ago

Description: modified (diff)
Summary: gimp curves tool broken by cairo-1.17.8 (wait for cairo-1.17.8 to be released at GNOME).cairo-1.18.0 (we may need a gimp fix)

Cairo-1.18.0 is now available at https://gitlab.freedesktop.org/cairo/cairo/-/archive/1.18.0/cairo-1.18.0.tar.gz. It's clearly a stable release but I don't know if a tarball will be uploaded to download.gnome.org.

comment:8 by Xi Ruoyao, 7 months ago

Summary: cairo-1.18.0 (we may need a gimp fix)cairo-1.18.0

The gimp issue should be fixed in 2.10.34.

comment:9 by Xi Ruoyao, 7 months ago

The first stable cairo release in five years should be cause for celebration.

All the API added in the 1.17 development cycle is now considered stable, and will not change.

Many thanks to all the contributors for this release.

The cairo-sphinx tool has been removed; we could not find any instruction on how to use it, and no user answered our call for help. If you were using cairo-sphinx, please reach out to the cairo maintainers.

Cairo now implements Type 3 color fonts for PDF. Thanks to Adrian Johnson for his work on this feature.

Khaled Hosny contributed multiple documentation fixes, to ensure that the cairo API reference is up to date. Khaled also fixed multiple compiler warnings generated when building cairo.

The XML surface has been removed; it was disabled by default when building cairo, and we could not find any downstream distributor that would enable it.

The Tee surface is now automatically enabled. Downstream distributors of cairo have been enabling for years it in order to build Firefox.

Fujii Hironori and Adrian Johnson fixed multiple issues with the DWrite font backend.

John Ralls improved the Quartz surface; mainly, Quartz surfaces now use the main display ColorSpace, speeding up rendering operations.

Cairo now hides all private symbols by default on every platform; the old "slim" symbols hack to alias internally used symbols has been dropped, in favor of using -Bsymbolic-functions with toolchains that support it.

Uli Schlachter fixed multiple memory leaks in the code base and test suite, and helped with many reviews and general maintenance.

Marc Jeanmougin added new API to expose the Pixman dithering filter to cairo patterns; this is currently implemented only for image surfaces.

comment:10 by Xi Ruoyao, 7 months ago

Milestone: 99-Waiting12.1

comment:11 by Xi Ruoyao, 7 months ago

The autoconf-based building system is removed. We need to use meson instead.

comment:12 by Xi Ruoyao, 7 months ago

I'm trying to run the test suite with "ninja test". It seems very slow and always using only one CPU core.

comment:13 by Xi Ruoyao, 7 months ago

Many tests has already failed (in test/output directory under the build directory) so I think we should continue to say "the test suite does not provide meaningful result".

comment:14 by Xi Ruoyao, 7 months ago

The two sed commands are not needed anymore.

comment:15 by Xi Ruoyao, 7 months ago

Summary: cairo-1.18.0cairo-1.18.0 (new download location)

The upstream has said download.gnome.org won't be used for cairo anymore.

comment:16 by Douglas R. Reno, 7 months ago

Owner: changed from blfs-book to Douglas R. Reno
Status: reopenednew

comment:17 by Douglas R. Reno, 7 months ago

Status: newassigned

comment:18 by Douglas R. Reno, 7 months ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.