Opened 18 years ago

Closed 18 years ago

#1813 closed defect (fixed)

Librsvg mozilla plugin build broken if using nss/nspr

Reported by: richard@… Owned by: Randy McMurchy
Priority: normal Milestone:
Component: BOOK Version:
Severity: normal Keywords:
Cc:

Description

If firefox (and presumably mozilla) are built using a separate nss/nspr build, then the build of librsvg fails as the include file prtypes.h is not in /usr/include/firefox-1.5/nspr but in /usr/include/nspr (which is not in the -I list). I fixed it by editing the Makefile after configure, but this isn't the correct solution.

Attachments (1)

librsvg-2.12.7-system_nspr-1.patch (1.4 KB ) - added by Randy McMurchy 18 years ago.
librsvg patch to fix breakage when using system-installed NSPR

Download all attachments as: .zip

Change History (8)

comment:1 by Randy McMurchy, 18 years ago

Priority: normallow
Severity: majorminor

Downgrading this bug as the librsvg plugin for Firefox isn't even used by Firefox any more. Firefox renders SVG on its own without plugin help. Additionally, the SVG plugin built by librsvg is optional, only available if Firefox is installed. This BTW is a circular dependency, as well. This bug certainly can't be classified as a "major defect".

comment:2 by bdubbs@…, 18 years ago

Priority: lownormal
Severity: minornormal
Summary: Librsvg build broken if using nss/nsprLibrsvg mozilla plugin build broken if using nss/nspr

It appears that we need to pass --disable-mozilla-plugin when building with system nspr and firefox is installed. We need to investigate if it is appropriate for Mozilla. We also need to change Mozilla to Seamonkey and check that out too.

Upgrading to normal priority/severity. Updated summary.

comment:3 by Randy McMurchy, 18 years ago

Owner: changed from blfs-book@… to Randy McMurchy

Richard is 100% correct about the breakage and that it needs to be fixed. In fact, I was probably wrong to downgrade the bug, as any broken build could easily be considered a major defect. With this in mind, and considering these other points:

1a) disabling the build of the plugin is probably not the *best* solution, as there may be other browsers that can use it.

1b) disabling the plugin doesn't fix the problem with the librsvg package, it only avoids it

2) the librsvg package logic is bad in that it looks for the mozilla-config program, but doesn't use it correctly. If it were to simply used the cflags option of mozilla-config, this issue would not exist.

It would be best to just fix the librsvg program. However, we do also have to contend with the following:

1) We can't safely say that upstream needs to fix librsvg until the Firefox/Mozilla build of nspr actually works. Right now, in Firefox/Mozilla system-nspr cannot be used without patching the sources. We cannot expect librsvg devs to patch Mozilla/firefox for something that doesn't natively work

2) We do need to address that if you have Firefox installed, you probably shouldn't link the plugin to the firefox plugin dir.

Creating a patch for librsvg looks trivial. I will create that patch and attach it to this bug. Richard, my apologies for down- grading the bug without fully considering the situation. Because of my error in judgment there, I'd like to atone as best as possible by fixing this issue and putting it to rest. Patch is forthcoming.

comment:4 by Randy McMurchy, 18 years ago

Status: newassigned

by Randy McMurchy, 18 years ago

librsvg patch to fix breakage when using system-installed NSPR

comment:5 by Randy McMurchy, 18 years ago

I've attached a patch to this ticket. The patch works for Mozilla or Firefox with system-installed NSPR. I did not (cannot either) check it against a system using NSPR from the Mozilla sources. It should work. Someone to test this would be nice.

After this patch is confirmed by someone else to work, I will add it to the book, and update the book to change the section about linking the plugin to the firefox plugin directory to just the mozilla plugin directory.

comment:6 by Richard A Downing, 18 years ago

I confirm that:

1) The patch allows the package to configure and build on a separate NSS/NSPR built system.

2) The plugin is built, and Firefox-1.5 correctly reports it in about:plugins.

3) SVG is correctly rendered by Firefox-1.5, with the plugin installed.

comment:7 by Randy McMurchy, 18 years ago

Resolution: fixed
Status: assignedclosed

Added the patch to the BLFS librsvg instructions

Note: See TracTickets for help on using tickets.