Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18177 closed enhancement (fixed)

xorgproto-2023.2

Reported by: Bruce Dubbs Owned by: pierre
Priority: normal Milestone: 12.0
Component: BOOK Version: git
Severity: medium Keywords:
Cc:

Description

New version.

Change History (24)

comment:1 by pierre, 3 years ago

Owner: changed from blfs-book to pierre
Status: new → assigned

comment:2 by Xi Ruoyao, 3 years ago

Do we still need the -Dlegacy=true option? It looks like Arch and Gentoo don't use it.

comment:3 by pierre, 3 years ago

This is xorgproto-2023.2 as a quick-fix release to address the Present protocol version not being updated in xorgproto-2023.1.

Olivier Fourdan (2):

presentproto: Update version number to 1.3 xorgproto 2023.2

in reply to:  2 ; comment:4 by pierre, 3 years ago

Replying to Xi Ruoyao:

Do we still need the -Dlegacy=true option? It looks like Arch and Gentoo don't use it.

Using this options installs .pc and header files for:

        'evieproto',
        'fontcacheproto',
        'lg3dproto',
        'printproto',
        'trapproto',
        'windowswmproto',
        'xcalibrateproto',
        'xf86miscproto',
        'xf86rushproto',
        'xproxymngproto'

I think the only way to answer whether they are needed would be to try to build full xorg without this option. I'm not sure how many packages outside of xorg use protos' and if so, how many would use legacy protos...

But well, this is development... Let's remove it and see whether we get an error later.

in reply to:  4 comment:5 by Xi Ruoyao, 3 years ago

Replying to pierre:

Replying to Xi Ruoyao:

Do we still need the -Dlegacy=true option? It looks like Arch and Gentoo don't use it.

Using this options installs .pc and header files for:

        'evieproto',
        'fontcacheproto',
        'lg3dproto',
        'printproto',
        'trapproto',
        'windowswmproto',
        'xcalibrateproto',
        'xf86miscproto',
        'xf86rushproto',
        'xproxymngproto'

I think the only way to answer whether they are needed would be to try to build full xorg without this option. I'm not sure how many packages outside of xorg use protos' and if so, how many would use legacy protos...

But well, this is development... Let's remove it and see whether we get an error later.

I'll remove these .pc and headers files from my system and see if things will be broken.

comment:6 by pierre, 3 years ago

Fixed at 6167879d. The legacy option is removed. The option may be needed for old programs, but not for BLFS, I think.

comment:7 by pierre, 3 years ago

Resolution: → fixed
Status: assigned → closed

comment:8 by Tim Tassonis, 3 years ago

Resolution: fixed
Status: closed → reopened

libxkbfile-1.1.2 does not compile without -Dlegacy=true, so I think, we still need it.

in reply to:  8 ; comment:9 by Xi Ruoyao, 3 years ago

Replying to Tim Tassonis:

libxkbfile-1.1.2 does not compile without -Dlegacy=true, so I think, we still need it.

Hmm, but how Arch and Gentoo compiles libxkbfile? Let me figure it out...

in reply to:  9 comment:10 by Tim Tassonis, 3 years ago

Replying to Xi Ruoyao:

Replying to Tim Tassonis:

libxkbfile-1.1.2 does not compile without -Dlegacy=true, so I think, we still need it.

Hmm, but how Arch and Gentoo compiles libxkbfile? Let me figure it out...

Maybe, we don't need libxkbfile anymore, in this case it should be dropped from Xorg libraries. But I really wouldn't know that.

comment:11 by Tim Tassonis, 3 years ago

Just looked into arch quickly, I didn't see anything special regarding libxkbfile

comment:12 by Xi Ruoyao, 3 years ago

Well, this XKBgeom.h file is installed by both xorgproto (if -Dlegacy=true used) and libX11.

In xorg libraries, we install libX11 before libxkbfile. So the file should be existing. A package manager issue (failing to detect conflict files) issue I guess.

comment:13 by Tim Tassonis, 3 years ago

Are you sure about that?

in reply to:  13 comment:14 by Xi Ruoyao, 3 years ago

Replying to Tim Tassonis:

Are you sure about that?

I'm pretty sure about

Well, this XKBgeom.h file is installed by both xorgproto (if -Dlegacy=true used) and libX11.

In xorg libraries, we install libX11 before libxkbfile. So the file should be existing.

Not sure about "package manager issue".

comment:15 by pierre, 3 years ago

I can confirm my PM had not removed XKBgeom.h even though I uninstalled xorgproto-legacy.

comment:16 by pierre, 3 years ago

My PM does not complain on files installed by two different packages...

comment:17 by Xi Ruoyao, 3 years ago

A similar story happens to vldXvMC.h, which is installed by both "legacy" xorgproto and libXvMC. Arch has handled this mess: ​https://gitlab.archlinux.org/archlinux/packaging/packages/xorgproto/-/commit/7043db2f97a133e03bdc6b90af7c11bac2869426

comment:18 by Tim Tassonis, 3 years ago

Well, mine is quite a fascist about that, and glady LFS/BLFS are mostly clean in that regard.

comment:19 by Xi Ruoyao, 3 years ago

I just performed "package management" to remove the legacy things by

diff dest-with-legacy dest-without-legacy  -Naur | sudo patch -Np1 -d /

This obviously won't detect conflicting files, so I can reproduce the issue on my system. But after reinstalled libX11, libxkbfile builds fine.

in reply to:  18 ; comment:20 by Xi Ruoyao, 3 years ago

Replying to Tim Tassonis:

Well, mine is quite a fascist about that, and glady LFS/BLFS are mostly clean in that regard.

Is it possible yours consider two exactly same versions "not conflicting"? Maybe it's a very old header and it has not changed at all for a decade.

in reply to:  20 comment:21 by Tim Tassonis, 3 years ago

Replying to Xi Ruoyao:

Replying to Tim Tassonis:

Well, mine is quite a fascist about that, and glady LFS/BLFS are mostly clean in that regard.

Is it possible yours consider two exactly same versions "not conflicting"? Maybe it's a very old header and it has not changed at all for a decade.

No, mine really just keeps a simple list of absolute filenames for every installed package. If a new package is installed, the PM then just scans all filelists of every installed package and bombs out if there is a match. Config files are handled differently, of course.

The issue seems to be at my side that xorg libraries are a special case, as I only create one package for the whole page, and not per archive. Arch and Stuff however surely have packages for every single package in Xorg libraries.

So, at the first install, I have to do a full non-package manager DESTDIR install in order for the later packages to find the headers from the previous ones. After that, I do another PM based installed, which then overwrite those files (they are not yet part of a registered package).

Now, here, I did not do the first part, otherwise libX11 would have installed the now missing header.

I can fix that, so if libX11 really installs the header, I'm all fine with dropping -Dlegacy=true.

comment:22 by Tim Tassonis, 3 years ago

Just confirming this is actually the case:

timtas@elliot:~/src/lgl/src/lgl/xorg/010-xorg-xlib$ find xorg-xlib-dest -name XKBgeom.h
xorg-xlib-dest/opt/X11/include/X11/extensions/XKBgeom.h

So, for my part, the ticket can be closed again, -Dlegacy=true can go, if one follows the book, all seems fine.

comment:23 by Xi Ruoyao, 3 years ago

Resolution: → fixed
Status: reopened → closed

Closing, if something else blows up please reopen again.

comment:24 by Bruce Dubbs, 3 years ago

Milestone: 11.4 → 12.0

Milestone renamed

Note: See TracTickets for help on using tickets.