#18202 closed enhancement (fixed)
gedit-45.0
Reported by: | Bruce Dubbs | Owned by: | Bruce Dubbs |
---|---|---|---|
Priority: | normal | Milestone: | 12.0 |
Component: | BOOK | Version: | git |
Severity: | normal | Keywords: | |
Cc: |
Description ¶
Possibly a pre-release version.
Change History (14)
comment:1 by , 21 months ago
comment:2 by , 21 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 21 months ago
News in 45.0, 2023-06-23
- User manual: a few improvements.
- Translation updates.
News in 45.alpha, 2023-04-26
gedit now depends on libgedit-gtksourceview instead of GtkSourceView: https://github.com/gedit-technology/libgedit-gtksourceview https://gedit-technology.net/
Build system:
- Add inline_side_panel_switcher option.
- No longer generate the Vala *.vapi file, rely on the GIR instead.
- Maintenance: don't use deprecated Meson features.
The core of the application:
- Add Ctrl+comma shortcut to open the Preferences dialog.
- Documents Panel: improve how the filenames are ellipsized.
- A few API changes in GeditWindow and GeditTab, see the API reference manual.
- Bump API version to 45.
Plugins:
- Insert Date/Time: add keyboard shortcut.
General:
- Code refactorings, robustness improvements, use more Tepl features, bug fixes, etc.
- Documentation improvements.
- Update Flatpak manifest.
- Translation updates.
comment:4 by , 21 months ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed at commit f95f14cd43f5d7e85f8fcb0c5e48ea8af2a1d596
comment:5 by , 21 months ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I cannot understand how you could build this: meson.build has:
# Subprojects if not get_option('buildtype').contains('plain') run_command( 'git', '-C', meson.project_source_root(), 'submodule', 'update', '--init', '--recursive', check: true, ) endif
Since we pass --buildtype=release
, it does not contain plain
, and meson tries to run git. But there is no .git
directory, so it fails. The exact command is:
/usr/bin/git -C /sources/gedit/gedit-45.0 submodule update --init --recursive
and the error is:
fatal: not a git repository (or any parent up to mount point /)
comment:6 by , 21 months ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Sorry. I had -Dbuildtype=plain in my test script, but forgot to add it to the book.
comment:7 by , 21 months ago
Hmm, but won't --buildtype=plain produce a completely unoptimized build?
follow-up: 9 comment:8 by , 21 months ago
Bruce, the book had --buildtype=release
until you changed it yesterday. Maybe you changed it locally and forgot to commit... Anyway, Xi's concern may be solved by:
- keeping
--buildtype=release
- adding
sed -i s/plain/release/ meson.build
That's what I've done.
If it is ok with you, I'll change the book.
comment:9 by , 21 months ago
Replying to pierre:
Bruce, the book had
--buildtype=release
until you changed it yesterday. Maybe you changed it locally and forgot to commit... Anyway, Xi's concern may be solved by:
- keeping
--buildtype=release
- adding
sed -i s/plain/release/ meson.build
That's what I've done.
If it is ok with you, I'll change the book.
Or maybe we can just keep --buildtype=plain
but add -Ddebug=false -Doptimization=3
to emulate --buildtype=release
.
comment:10 by , 21 months ago
I found that I needed -Dbuildtype=plain, not --buildtype=plain, but now I'm not sure that makes a difference.
I do note that the file command gives me with "debug_info, not stripped"
Checking https://mesonbuild.com/Builtin-options.html, it defines buildtype as:
buildtype debug optimization plain false plain debug true 0 debugoptimized true 2 release false 3 minsize true s
I have not heard of optimization level of 'plain' before. A quick google does not give me anything relevant.
To be consistent with all the other meson instructions in the book, I think we should use the sed and --buildtype=release.
Pierre, do you want to make the change or do you want me to do it?
follow-up: 13 comment:12 by , 21 months ago
Replying to pierre:
Done the change at 73780d5928
Now is git really a "required" dependency? It looks strange to me.
comment:13 by , 21 months ago
Replying to Xi Ruoyao:
Replying to pierre:
Done the change at 73780d5928
Now is git really a "required" dependency? It looks strange to me.
I don't think so. I'll remove it.
It looks like 45.0 is out (there was already a 45.alpha), so I'd say this is probably an officially released package