Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18375 closed enhancement (fixed)

Generate security patch for WebKit's August 2nd Security Advisory

Reported by: Douglas R. Reno Owned by: Douglas R. Reno
Priority: high Milestone: 12.0
Component: BOOK Version: git
Severity: medium Keywords:
Cc:

Description

Since we are on unstable, we have to patch these for now until upstream sees it fit to release another unstable release. These have already been fixed in WebKitGTK-2.40.5, but we need to stay on unstable because of Intel GPU issues.

The following CVEs were fixed:

CVE-2023-38133 CVE-2023-38572 CVE-2023-38592 CVE-2023-38594 CVE-2023-38595 CVE-2023-38597 CVE-2023-38599 CVE-2023-38600 CVE-2023-38611

I've done a bunch of research via WebKit bug numbers and found the commits necessary to resolve these, and the unstable version of WebKit does not have any of them.

Change History (7)

comment:1 by Douglas R. Reno, 3 years ago

Owner: changed from blfs-book to Douglas R. Reno
Status: new → assigned

comment:2 by Douglas R. Reno, 3 years ago

Patch crafted out of the following commits and PRs:

Now waiting on it to build

comment:3 by Xi Ruoyao, 3 years ago

My backport is at ​https://github.com/xry111/WebKit/commits/webkitgtk-2.41.6-security. I've built 2.41.6 with GTK4 and these patches + the patch already in the book and the result seems working (I'm posting this comment in the MiniBrowser).

comment:4 by Douglas R. Reno, 3 years ago

Thank you Xi, I'm going to add one patch to it but the commits there all applied cleanly here. I had some problems with trying to get this working yesterday. For some reason, I would get duplicate case statement errors out of:

case PaintBehavior::DontShowVisitedLinks: ts << "DontShowVisitedLinks"; break;

in Source/WebCore/rendering/RenderLayer.cpp. Never did find out what was going on with that.

I'm also going to add

​https://github.com/WebKit/WebKit/commit/ec83f7580fdcc4a4ad7c1597053adc78dd0a922b - changes it so that the redirections cancel navigation instead of showing an error.

Last edited 3 years ago by Douglas R. Reno (previous) (diff)

comment:5 by Douglas R. Reno, 3 years ago

Resolution: → fixed
Status: assigned → closed

Fixed at 7b8b07f8b37e2209e47f247d933b212763b38cc2

I'll file an advisory tomorrow.

comment:6 by Douglas R. Reno, 3 years ago

SA-11.3-073 issued

in reply to:  2 comment:7 by Xi Ruoyao, 3 years ago

Correction of some bug numbers for future reference:

Replying to Douglas R. Reno:

Patch crafted out of the following commits and PRs:

Should be bug 256932.

Should be bug 257331.

Should be bug 256865.

Now waiting on it to build

Note: See TracTickets for help on using tickets.