#18804 closed enhancement (fixed)

node-v20.9.0

Reported by: Xi Ruoyao Owned by: Bruce Dubbs
Priority: normal Milestone: 12.1
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

Node.js 20 series is now LTS. Originally reported by Rahul via blfs-dev.

Change History (4)

comment:1 by Xi Ruoyao, 15 months ago

Unfortunately the sed for Python 3.12 is still needed.

comment:2 by Xi Ruoyao, 15 months ago

I got 2 test failures out of 3967:

=== release test-crypto-dh ===                                                
Path: parallel/test-crypto-dh
node:assert:635
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   message: 'Supplied key is too small'
-   message: 'error:02800080:Diffie-Hellman routines::invalid secret'
  }
    at Object.<anonymous> (/home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-crypto-dh.js:88:10)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: RangeError: Supplied key is too small
      at DiffieHellman.dhComputeSecret [as computeSecret] (node:internal/crypto/diffiehellman:156:29)
      at assert.throws.message (/home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-crypto-dh.js:89:9)
      at getActual (node:assert:756:5)
      at Function.throws (node:assert:902:24)
      at Object.<anonymous> (/home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-crypto-dh.js:88:10)
      at Module._compile (node:internal/modules/cjs/loader:1241:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
      at Module.load (node:internal/modules/cjs/loader:1091:32)
      at Module._load (node:internal/modules/cjs/loader:938:12)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12) {
    code: 'ERR_CRYPTO_INVALID_KEYLEN'
  },
  expected: { message: 'error:02800080:Diffie-Hellman routines::invalid secret' },
  operator: 'throws'
}

Node.js v20.9.0
Command: out/Release/node /home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-crypto-dh.js


=== release test-process-versions ===                                         
Path: parallel/test-process-versions
node:assert:1026
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /^\d+(?:\.\d+){2,3}(?:-.*)?$/. Input:

'1.3'

    at Object.<anonymous> (/home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-process-versions.js:64:8)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '1.3',
  expected: /^\d+(?:\.\d+){2,3}(?:-.*)?$/,
  operator: 'match'
}

Node.js v20.9.0
Command: out/Release/node /home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-process-versions.js


[04:24|% 100|+ 3967|-   2]: Done                                              

Failed tests:
out/Release/node /home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-crypto-dh.js
out/Release/node /home/xry111/sources/12.1/node-v20.9.0/test/parallel/test-process-versions.js

comment:3 by Bruce Dubbs, 15 months ago

Owner: changed from blfs-book to Bruce Dubbs
Status: newassigned

comment:4 by Bruce Dubbs, 15 months ago

Resolution: fixed
Status: assignedclosed

Fixed at commit ab18a098.

All tests passed for me:

[04:02|% 100|+ 3969|-   0]: Done                                              

All tests passed.
Note: See TracTickets for help on using tickets.