Opened 2 years ago

Closed 2 years ago

#19063 closed enhancement (fixed)

rustc-1.75.0

Reported by: Douglas R. Reno Owned by: Xi Ruoyao
Priority: normal Milestone: 12.1
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

New minor version

Change History (11)

comment:2 by Xi Ruoyao, 2 years ago

Per the release note, upstream is now building their dist binary with codegen-units = 1 in [rust] section. It makes the produced compiler binary and "std" library 1.5% faster, and IMO we'd do the same.

comment:3 by Xi Ruoyao, 2 years ago

And upstream has enabled lto = "thin" for dist build in the [rust] section since 1.66.0. It would make the compiler 4% faster.

comment:4 by Xi Ruoyao, 2 years ago

Owner: changed from blfs-book to Xi Ruoyao
Status: new → assigned

I'll do it.

Tasks:

  • Build rustc-1.75.0 with lto = "thin" and codegen-units = 1
    • Ok
  • Triage and document any new test failures
    • No new test failures.
  • Silence or document some new warnings emitted by x.py
  • Try to build librsvg
    • Ok
  • Try to build snapshot
    • Ok
  • Try to build spidermonkey
    • Ok
  • Try to build cbindgen
    • Ok
  • Try to build firefox
    • Ok
  • Try to build thunderbird
    • Ok
  • Try to build seamonkey
    • Ok
Last edited 2 years ago by Xi Ruoyao (previous) (diff)

comment:5 by Xi Ruoyao, 2 years ago

I get some "unexpected" thing running test with rust.lto=thin. I've created ​https://github.com/rust-lang/rust/pull/119414 waiting for a review.

comment:6 by Xi Ruoyao, 2 years ago

The tests ui/issues/issue-21763.rs and debuginfo/regression-bad-location-list-67992.rs still fail. No new failure observed.

in reply to:  5 comment:7 by Xi Ruoyao, 2 years ago

Replying to Xi Ruoyao:

I get some "unexpected" thing running test with rust.lto=thin. I've created ​https://github.com/rust-lang/rust/pull/119414 waiting for a review.

I've got an approve so I'll add it as a patch.

comment:8 by Douglas R. Reno, 2 years ago

Sounds good! Was that the last piece for this update?

in reply to:  8 ; comment:9 by Xi Ruoyao, 2 years ago

Replying to Douglas R. Reno:

Sounds good! Was that the last piece for this update?

The last piece is thunderbird. The build is still running (though it seems all Rust code has been already successfully compiled).

in reply to:  9 comment:10 by Xi Ruoyao, 2 years ago

Replying to Xi Ruoyao:

Replying to Douglas R. Reno:

Sounds good! Was that the last piece for this update?

The last piece is thunderbird. The build is still running (though it seems all Rust code has been already successfully compiled).

Done. Will push to trunk soon...

comment:11 by Xi Ruoyao, 2 years ago

Resolution: → fixed
Status: assigned → closed

Fixed at r12.0-1120-g948ffd7ba3.

Note: See TracTickets for help on using tickets.