Gwenview and kImageAnnotator problem

[Bruce Dubbs]

When running cmake for Gwenview it cannot find kImageAnnotator. I created a workaround that completely skips looking for kImageAnnotator.

If the book is followed and the kImageAnnotator package is installed, Gwenview builds fine, but if kImageAnnotator is not installed the package will fail during the build phase.

We need something to really fix the cmake routines so kImageAnnotator is actually tested for proper installation.

[Douglas R. Reno]

I've done some digging and have come up with a patch to CMakeLists.txt that now lets the package build correctly with both kColorPicker and kImageAnotator detected. :)

The patch diff:

--- gwenview-23.08.5.orig/CMakeLists.txt  2024-02-26 15:02:29.702754535 -0600
+++ gwenview-23.08.5/CMakeLists.txt 2024-02-26 15:09:48.012866877 -0600
@@ -166,11 +166,11 @@ if(NOT WITHOUT_X11)
 endif()

 if (QT_MAJOR_VERSION STREQUAL "5")
-    find_package(kImageAnnotator)
-    set_package_properties(kImageAnnotator PROPERTIES URL "https://github.com/ksnip/kImageAnnotator" DESCRIPTION "The kImageAnnotator library provides tools to annotate" TYPE REQUIRED)
-    if(kImageAnnotator_FOUND)
-        set(KIMAGEANNOTATOR_FOUND 1)
-        find_package(kColorPicker REQUIRED)
+    find_package(kImageAnnotator-Qt5)
+    set_package_properties(kImageAnnotator-Qt5 PROPERTIES URL "https://github.com/ksnip/kImageAnnotator" DESCRIPTION "The kImageAnnotator library provides tools to annotate" TYPE REQUIRED)
+    if(kImageAnnotator-Qt5_FOUND)
+        set(kImageAnnotator_FOUND 1)
+        find_package(kColorPicker-Qt5 REQUIRED)
         if(NOT kImageAnnotator_VERSION VERSION_LESS 0.5.0)
             set(KIMAGEANNOTATOR_CAN_LOAD_TRANSLATIONS 1)
         endif()

I'll have this in the book shortly

[Douglas R. Reno]

Fixed at de89edf0596156b9f683a545b9267de3356b546a