ffmpeg-7 causes other packages to fail

[Bruce Dubbs]

xine-lib - fixed
vlc - fixed

Add others and fixes here as we find them.

[Xi Ruoyao]

Also QtWebEngine (now we've worked around by using internal ffmpeg, but it's not a perfect solution)

[Bruce Dubbs]

mlt has been fixed to use ffmpeg-7 in mlt-7.24.0.

[Douglas R. Reno]

gst-libav fixed again at 1fc1afb4cfbf8625134c04731b61685fc1ee6218

[Douglas R. Reno]

For VLC, we might be able to use ​https://src.fedoraproject.org/rpms/vlc/raw/9a85bfff28de79454601ef1b24110cb78a8ddfef/f/0001-Add-compatibility-with-FFMPEG-7.0.patch

[Bruce Dubbs]

I tried that patch and it applied OK (along with the vlc-3.0.20-taglib-1.patch, but the build failed. I suspect though it is a gcc14 problem now:

export LUAC=/usr/bin/luac5.2 &&
export LUA_LIBS="$(pkg-config --libs lua52)" &&
export CPPFLAGS="$(pkg-config --cflags lua52)" &&

patch -Np1 -i $DIR/$PROGRAM-taglib-1.patch
patch -Np1 -i $DIR/$PROGRAM-fedora_ffmpeg7-1.patch

BUILDCC=gcc ./configure --prefix=/usr --disable-libplacebo &&
make

...

input/input.c: In function ‘InitTitle’:
input/input.c:910:19: error: assignment to ‘const input_title_t **’ from 
incompatible pointer type ‘input_title_t **’ [-Wincompatible-pointer-types]
  910 |     priv->title   = p_master->title;
      |                   ^

[Douglas R. Reno]

Replying to Bruce Dubbs:

I tried that patch and it applied OK (along with the vlc-3.0.20-taglib-1.patch, but the build failed. I suspect though it is a gcc14 problem now:

export LUAC=/usr/bin/luac5.2 &&
export LUA_LIBS="$(pkg-config --libs lua52)" &&
export CPPFLAGS="$(pkg-config --cflags lua52)" &&

patch -Np1 -i $DIR/$PROGRAM-taglib-1.patch
patch -Np1 -i $DIR/$PROGRAM-fedora_ffmpeg7-1.patch

BUILDCC=gcc ./configure --prefix=/usr --disable-libplacebo &&
make

...

input/input.c: In function ‘InitTitle’:
input/input.c:910:19: error: assignment to ‘const input_title_t **’ from 
incompatible pointer type ‘input_title_t **’ [-Wincompatible-pointer-types]
  910 |     priv->title   = p_master->title;
      |                   ^

Check this out for this: ​https://src.fedoraproject.org/rpms/vlc/blob/rawhide/f/4645.patch

[Bruce Dubbs]

Yes, that works. With

    patch -Np1 -i $DIR/$PROGRAM-taglib-1.patch
    patch -Np1 -i $DIR/$PROGRAM-fedora_ffmpeg7-1.patch
    patch -Np1 -i $DIR/$PROGRAM-gcc14-1.patch

the vlc build completes successfully. I have not tested it out though. There are 467 warnings.

[Xi Ruoyao]

xine-lib: ​https://src.fedoraproject.org/rpms/xine-lib/c/05b4a7f5965c5bf8b3918f8fb2b5e60a4fb0ba52

[Bruce Dubbs]

vlc has been fixed with two seds from fedora.

[Bruce Dubbs]

Added a sed to fix xine-lib. As far as I know that is the last ffmpeg-7 issue. Marking this as closed, but if we run into another ffmpeg-7, we should create another ticket.

[Douglas R. Reno]

​https://src.fedoraproject.org/rpms/xine-lib/raw/05b4a7f5965c5bf8b3918f8fb2b5e60a4fb0ba52/f/xine-lib-1.2.13-ffmpeg6-compatibility_2.patch and ​https://src.fedoraproject.org/rpms/xine-lib/raw/05b4a7f5965c5bf8b3918f8fb2b5e60a4fb0ba52/f/xine-lib-1.2.13-ffmpeg7-compatibility.patch for the xine-lib patches

[Douglas R. Reno]

I think I have a working patch based off the following commits from Arch:

• "771f4ae27e582123ff3500444718fc8f96186d74": ffmpeg compatibility update.
• "0a786d63bbdb2d780a9231f6772e84e743c72014": Try to silence some cast align warnings 4.
• "6f1000084f6084f49c95c202d12593e49916f58b": Try to silence some cast align warnings 5.
• "1e7b184008860c8be2289c3cefd9dee57f06193a": ffmpeg compatibility update 1.
• "73b833e7fe356cd2d9490dda4ebc9bfe16fce958": ffmpeg compatibility update 2.

The last two commits were from May 8th.

The patch that I have applies cleanly, but I'll need a little bit to test it as I'm currently waiting on an LLVM upgrade.

To get this patch, I basically did the following:

hg clone http://hg.code.sf.net/p/xine/xine-lib-1.2
cd xine-lib-1.2
hg diff -c 771f4ae27e582123ff3500444718fc8f96186d74 | tee /tmp/xine-1.patch
hg diff -c 0a786d63bbdb2d780a9231f6772e84e743c72014 | tee /tmp/xine-2.patch
hg diff -c 6f1000084f6084f49c95c202d12593e49916f58b | tee /tmp/xine-3.patch
hg diff -c 1e7b184008860c8be2289c3cefd9dee57f06193a | tee /tmp/xine-4.patch
hg diff -c 73b833e7fe356cd2d9490dda4ebc9bfe16fce958 | tee /tmp/xine-5.patch

and then applied them all to a freshly extracted copy of xine-lib-1.2.13, and then diffed it.

I'll test my patch and if it works I'll add it in later tonight.

[Douglas R. Reno]

I was able to get xine-lib to build with my patch and test it with xine-ui, and it seems to be working well.

[Douglas R. Reno]

xine-lib fixed at 24a668d4c1486691c9c7c6cae83b9dc3880c1e54