ffmpeg-7 causes other packages to fail

[Bruce Dubbs]

xine-lib - fixed
vlc - fixed

Add others and fixes here as we find them.

[Xi Ruoyao]

Also QtWebEngine (now we've worked around by using internal ffmpeg, but it's not a perfect solution)

[Bruce Dubbs]

mlt has been fixed to use ffmpeg-7 in mlt-7.24.0.

[Douglas R. Reno]

gst-libav fixed again at 1fc1afb4cfbf8625134c04731b61685fc1ee6218

[Douglas R. Reno]

For VLC, we might be able to use ​https://src.fedoraproject.org/rpms/vlc/raw/9a85bfff28de79454601ef1b24110cb78a8ddfef/f/0001-Add-compatibility-with-FFMPEG-7.0.patch

[Bruce Dubbs]

I tried that patch and it applied OK (along with the vlc-3.0.20-taglib-1.patch, but the build failed. I suspect though it is a gcc14 problem now:

export LUAC=/usr/bin/luac5.2 &&
export LUA_LIBS="$(pkg-config --libs lua52)" &&
export CPPFLAGS="$(pkg-config --cflags lua52)" &&

patch -Np1 -i $DIR/$PROGRAM-taglib-1.patch
patch -Np1 -i $DIR/$PROGRAM-fedora_ffmpeg7-1.patch

BUILDCC=gcc ./configure --prefix=/usr --disable-libplacebo &&
make

...

input/input.c: In function ‘InitTitle’:
input/input.c:910:19: error: assignment to ‘const input_title_t **’ from 
incompatible pointer type ‘input_title_t **’ [-Wincompatible-pointer-types]
  910 |     priv->title   = p_master->title;
      |                   ^

[Douglas R. Reno]

Replying to Bruce Dubbs:

I tried that patch and it applied OK (along with the vlc-3.0.20-taglib-1.patch, but the build failed. I suspect though it is a gcc14 problem now:

export LUAC=/usr/bin/luac5.2 &&
export LUA_LIBS="$(pkg-config --libs lua52)" &&
export CPPFLAGS="$(pkg-config --cflags lua52)" &&

patch -Np1 -i $DIR/$PROGRAM-taglib-1.patch
patch -Np1 -i $DIR/$PROGRAM-fedora_ffmpeg7-1.patch

BUILDCC=gcc ./configure --prefix=/usr --disable-libplacebo &&
make

...

input/input.c: In function ‘InitTitle’:
input/input.c:910:19: error: assignment to ‘const input_title_t **’ from 
incompatible pointer type ‘input_title_t **’ [-Wincompatible-pointer-types]
  910 |     priv->title   = p_master->title;
      |                   ^

Check this out for this: ​https://src.fedoraproject.org/rpms/vlc/blob/rawhide/f/4645.patch

[Bruce Dubbs]

Yes, that works. With

    patch -Np1 -i $DIR/$PROGRAM-taglib-1.patch
    patch -Np1 -i $DIR/$PROGRAM-fedora_ffmpeg7-1.patch
    patch -Np1 -i $DIR/$PROGRAM-gcc14-1.patch

the vlc build completes successfully. I have not tested it out though. There are 467 warnings.

[Xi Ruoyao]

xine-lib: ​https://src.fedoraproject.org/rpms/xine-lib/c/05b4a7f5965c5bf8b3918f8fb2b5e60a4fb0ba52

[Bruce Dubbs]

vlc has been fixed with two seds from fedora.

[Bruce Dubbs]

Added a sed to fix xine-lib. As far as I know that is the last ffmpeg-7 issue. Marking this as closed, but if we run into another ffmpeg-7, we should create another ticket.