Mozilla: Make ac_add_options --disable-sandbox automatic?

[Xi Ruoyao]

In the book we are saying:

# Sandboxing works well on x86_64 but might cause issues on other
# platforms. If not on x86_64, e.g. i686, it is recommended to
# uncomment the following switch.
#ac_add_options --disable-sandbox

And when I was analyzing ​lfs:#5487 it seemed on a 32-bit x86 with LFS Glibc configuration the sandbox will definitely blow up (due to the use of statx for stat-family functions to avoid y2038 issue, and --enable-kernel=4.19 which disables falling back to y2038-unsafe alternatives).

Maybe we can make it automatic, like

[ $(uname -m) != x86_64 ] && ac_add_options --disable-sandbox

?

[thomas]

I use the following sed in my script which let me use the mozconfig as provided in the book - just patching it after creating it via cat > mozconfig <<EOF...

if [ "$(uname -m)" == "i686" ]; then
    sed -e "/#ac_add_options --disable-sandbox/s/#//" -i mozconfig
fi

[Xi Ruoyao]

To me mozconfig is interpreted as a shell script and we can wire the logic directly into it instead of fixing it up.

[Douglas R. Reno]

Fixed at 5e1176ac87ff68373b966a4c7e2f3c025bde0134