ncftp-3.2.7 FTBFS with gcc14

[Joe Locash]

Use CFLAGS+="-std=gnu89" when building

[Xi Ruoyao]

But Fedora builds it fine with GCC 14.

And generally using -std=gnu89 is a bad thing unless the package is abandoned or the upstream explicitly uses it.

[Xi Ruoyao]

Alright, Fedora do use -std=gnu89 but in a cryptic way I didn't recognized.

[Xi Ruoyao]

It seems a better workaround is

sed 's/def HAVE_STDLIB_H/ 1/' -i configure

It seems HAVE_STDLIB_H comes nowhere.

[Xi Ruoyao]

sed '/extern select/extern int select/' -i configure
CPPFLAGS=-DHAVE_STDLIB_H CC=gcc ./configure --prefix=/usr --sysconfdir=/etc

works for me.

[Xi Ruoyao]

I've sent a report to the upstream but they don't have a public bug tracker.

[Joe Locash]

Replying to Xi Ruoyao:

sed '/extern select/extern int select/' -i configure
CPPFLAGS=-DHAVE_STDLIB_H CC=gcc ./configure --prefix=/usr --sysconfdir=/etc

works for me.

hmm, not for me:

$ sed '/extern select/extern int select/' -i configure
sh: line 1: xtern: command not found

a better sed might be:

sed -i 's/def HAVE_STDLIB_H/ 1/;s/extern select/extern int select/' configure

no other changes needed

[Xi Ruoyao]

Replying to Joe Locash:

Replying to Xi Ruoyao:

sed '/extern select/extern int select/' -i configure
CPPFLAGS=-DHAVE_STDLIB_H CC=gcc ./configure --prefix=/usr --sysconfdir=/etc

works for me.

hmm, not for me:

$ sed '/extern select/extern int select/' -i configure
sh: line 1: xtern: command not found

Oops, missing a "s".

[Douglas R. Reno]

Fixed at 51772cc6affd29203ceac05f2d5e80eec2f1ca14