llvm-19.1.0

[Bruce Dubbs]

New major version.

[Xi Ruoyao]

• [libcxx] Align __recommend() + 1 by __endian_factor
• [libc++][NFC] Rewrite function call on two lines for clarity

We don't install libc++ so we can skip the release or just do a stat change.

[Joe Locash]

Why not just update to .8? It doesn't need any changes and you could close 2 tickets? libclc being the other.

[Bruce Dubbs]

Replying to Joe Locash:

Why not just update to .8? It doesn't need any changes and you could close 2 tickets? libclc being the other.

Because the odds of a newer version before we go into package freeze around August 15 is relatively high. If so, we would need to do it twice. If not then we still only need to do it once.

[Joe Locash]

Replying to Bruce Dubbs:

Replying to Joe Locash:

Why not just update to .8? It doesn't need any changes and you could close 2 tickets? libclc being the other.

Because the odds of a newer version before we go into package freeze around August 15 is relatively high. If so, we would need to do it twice. If not then we still only need to do it once.

I don't understand? The only change would be to packages.ent That is updated daily.

We really need to test build it, run a few tests, update package.ent, changelog, and at least the md5sum in the llvm chapter. To me that cost in time is more than the benefit is worth.

[Joe Locash]

Replying to Bruce Dubbs:

Replying to Joe Locash:

Why not just update to .8? It doesn't need any changes and you could close 2 tickets? libclc being the other.

Because the odds of a newer version before we go into package freeze around August 15 is relatively high. If so, we would need to do it twice. If not then we still only need to do it once.

Hmm... The release date for llvm-19.1.0 is Sep 3.

[Xi Ruoyao]

Release notes:

• ​https://releases.llvm.org/19.1.0/docs/ReleaseNotes.html
• ​https://releases.llvm.org/19.1.0/tools/clang/docs/ReleaseNotes.html

[Xi Ruoyao]

As expected, rustc needs to be adapted:

warning: rustc_llvm@0.0.0: llvm-wrapper/RustWrapper.cpp: In function ‘LLVMOpaqueValue* LLVMRustGetInstrProfMCDCCondBitmapIntrinsic(LLVMModuleRef)’:
warning: rustc_llvm@0.0.0: llvm-wrapper/RustWrapper.cpp:1562:35: 错误：‘instrprof_mcdc_condbitmap_update’ is not a member of ‘llvm::Intrinsic’; did you mean ‘instrprof_mcdc_tvbitmap_update’?
warning: rustc_llvm@0.0.0:  1562 |       unwrap(M), llvm::Intrinsic::instrprof_mcdc_condbitmap_update));
warning: rustc_llvm@0.0.0:       |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
warning: rustc_llvm@0.0.0:       |                                   instrprof_mcdc_tvbitmap_update

error: failed to run custom build command for `rustc_llvm v0.0.0 (/home/xry111/sources/12.3/rustc-1.81.0-src/compiler/rustc_llvm)`

​https://github.com/rust-lang/rust/pull/127513

[Xi Ruoyao]

To be tested:

• SPIRV-LLVM-Translator-19.1.0
  • libclc-19.1.0
    • mesa-24.2.3 (NVK disabled)
• Rustc-1.81.0
  • librsvg-2.58.4
  • spidermonkey-128.0
  • snapshot-47.0.1
  • ruby-3.3.5
  • cbindgen-0.27.0
    • firefox-128.2.0
    • thunderbird-128.2.0
    • seamonkey
  • rust-bindgen-0.70.1
    • mesa (NVK compile test)

[Xi Ruoyao]

New Clang does not like seamonkey:

 1:03.84 /home/xry111/sources/12.3/seamonkey-2.53.18.2/js/src/threading/ExclusiveData.h:124:33: error: reference to non-static member function must be called
 1:03.85   124 |       : lock_(mozilla::Move(rhs.lock))
 1:03.85       |                             ~~~~^~~~
 1:04.19 1 error generated.

With 2.53.19 it's slightly different but still rejected:

 1:29.35 /home/xry111/sources/12.3/seamonkey-2.53.19/js/src/threading/ExclusiveData.h:124:29: error: reference to non-static member function must be called
 1:29.35   124 |       : lock_(std::move(rhs.lock))
 1:29.35       |                         ~~~~^~~~

[Xi Ruoyao]

• r12.2-192-g3e711549ea Update to libclc-19.1.0
• r12.2-191-ge5d0a32824 Update to SPIRV-LLVM-Translator-19.1.0
• r12.2-190-gd68c966868 Update to LLVM-19.1.0
• r12.2-189-gce271d7314 seamonkey: Fix a bug highlighted by Clang 19
• r12.2-188-ged84c58003 rust: Adapt for LLVM 19