samba-4.20.2

[Bruce Dubbs]

New point version.

[thomas]

Changes since 4.20.1

---

o Jeremy Allison <jra@…>

• BUG 15662: vfs_widelinks with DFS shares breaks case insensitivity.

o Douglas Bagnall <douglas.bagnall@…>

• BUG 13213: Samba build is not reproducible.
• BUG 15569: ldb qsort might r/w out of bounds with an intransitive compare function.
• BUG 15625: Many qsort() comparison functions are non-transitive, which can lead to out-of-bounds access in some circumstances.

o Andrew Bartlett <abartlet@…>

• BUG 15638: Need to change gitlab-ci.yml tags in all branches to avoid CI bill.
• BUG 15654: We have added new options --vendor-name and --vendor-patch- revision arguments to ./configure to allow distributions and packagers to put their name in the Samba version string so that when debugging Samba the source of the binary is obvious.

o Günther Deschner <gd@…>

• BUG 15665: CTDB RADOS mutex helper misses namespace support.

o Stefan Metzmacher <metze@…>

• BUG 13019: Dynamic DNS updates with the internal DNS are not working.
• BUG 14981: netr_LogonSamLogonEx returns NR_STATUS_ACCESS_DENIED with SysvolReady=0.
• BUG 15412: Anonymous smb3 signing/encryption should be allowed (similar to Windows Server 2022).
• BUG 15573: Panic in dreplsrv_op_pull_source_apply_changes_trigger.
• BUG 15620: s4:nbt_server: does not provide unexpected handling, so winbindd can't use nmb requests instead cldap.
• BUG 15642: winbindd, net ads join and other things don't work on an ipv6 only host.
• BUG 15659: Segmentation fault when deleting files in vfs_recycle.
• BUG 15664: Panic in vfs_offload_token_db_fetch_fsp().
• BUG 15666: "client use kerberos" and --use-kerberos is ignored for the machine account.

o Noel Power <noel.power@…>

• BUG 15435: Regression DFS not working with widelinks = true.

o Andreas Schneider <asn@…>

• BUG 15633: samba-gpupdate - Invalid NtVer in netlogon_samlogon_response.
• BUG 15653: idmap_ad creates an incorrect local krb5.conf in case of trusted domain lookups.
• BUG 15660: The images don't build after the git security release and CentOS 8 Stream is EOL.

[Tim Tassonis]

I get some errors in the idl part, for instance:

491/525] Processing librpc/idl/nbt.idl
librpc/idl/auth.idl:171: warning: helper() is pidl-specific and deprecated. Use `include' instead
librpc/idl/auth.idl:154: error: Unable to determine origin of type `struct cli_credentials'
librpc/idl/auth.idl:154: error: Unable to determine origin of type `struct cli_credentials'

and then:

517/525] Processing source3/librpc/idl/secrets.idl
source3/librpc/idl/open_files.idl:33: error: Unable to determine origin of type `struct timeval'
source3/librpc/idl/open_files.idl:33: error: Unable to determine origin of type `struct timeval'
source3/librpc/idl/open_files.idl:94: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:94: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:95: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:95: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:96: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:96: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:97: error: Unable to determine origin of type `struct timespec'
source3/librpc/idl/open_files.idl:97: error: Unable to determine origin of type `struct timespec'

and then:

source4/librpc/idl/irpc.idl:159: warning: [out] argument `info' not a pointer
source4/librpc/idl/irpc.idl:70: error: nbtd_information: [out] argument 'info' is not a pointer or array, skip client functions
source4/librpc/idl/irpc.idl:83: error: nbtd_getdcname: [out] argument 'dcname' is a pointer to a string type, skip client functions
source4/librpc/idl/irpc.idl:91: error: nbtd_proxy_wins_challenge: [out] argument 'num_addrs' is not a pointer or array, skip client functions
source4/librpc/idl/irpc.idl:113: error: kdc_check_generic_kerberos: [out] argument 'generic_reply' is not a pointer or array, skip client functions
source4/librpc/idl/irpc.idl:159: error: smbsrv_information: [out] argument 'info' is not a pointer or array, skip client functions

librpc/idl/winbind.idl:286: warning: [out] argument `validation' not a pointer
librpc/idl/winbind.idl:288: warning: [out] argument `authoritative' not a pointer
librpc/idl/winbind.idl:286: error: winbind_SamLogon: [out] argument 'validation' is not a pointer or array, skip client functions

[519/525] Processing source3/librpc/idl/leases_db.idl
source3/librpc/idl/smbXsrv.idl:60: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:60: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:83: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:83: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:109: error: Unable to determine origin of type `struct smbXsrv_client_table'
source3/librpc/idl/smbXsrv.idl:109: error: Unable to determine origin of type `struct smbXsrv_client_table'
source3/librpc/idl/smbXsrv.idl:110: error: Unable to determine origin of type `struct tevent_context'
source3/librpc/idl/smbXsrv.idl:110: error: Unable to determine origin of type `struct tevent_context'
source3/librpc/idl/smbXsrv.idl:111: error: Unable to determine origin of type `struct messaging_context'
source3/librpc/idl/smbXsrv.idl:111: error: Unable to determine origin of type `struct messaging_context'
source3/librpc/idl/smbXsrv.idl:120: error: Unable to determine origin of type `struct smbd_server_connection'
source3/librpc/idl/smbXsrv.idl:120: error: Unable to determine origin of type `struct smbd_server_connection'
source3/librpc/idl/smbXsrv.idl:125: error: Unable to determine origin of type `struct smbXsrv_session_table'
source3/librpc/idl/smbXsrv.idl:125: error: Unable to determine origin of type `struct smbXsrv_session_table'
source3/librpc/idl/smbXsrv.idl:129: error: Unable to determine origin of type `struct smbXsrv_tcon_table'
source3/librpc/idl/smbXsrv.idl:129: error: Unable to determine origin of type `struct smbXsrv_tcon_table'
source3/librpc/idl/smbXsrv.idl:135: error: Unable to determine origin of type `struct smbXsrv_open_table'
source3/librpc/idl/smbXsrv.idl:135: error: Unable to determine origin of type `struct smbXsrv_open_table'
source3/librpc/idl/smbXsrv.idl:142: error: Unable to determine origin of type `struct smbXsrv_connection'
source3/librpc/idl/smbXsrv.idl:142: error: Unable to determine origin of type `struct smbXsrv_connection'
source3/librpc/idl/smbXsrv.idl:145: error: Unable to determine origin of type `struct tevent_req'
source3/librpc/idl/smbXsrv.idl:145: error: Unable to determine origin of type `struct tevent_req'
source3/librpc/idl/smbXsrv.idl:146: error: Unable to determine origin of type `struct tevent_req'
source3/librpc/idl/smbXsrv.idl:146: error: Unable to determine origin of type `struct tevent_req'
source3/librpc/idl/smbXsrv.idl:151: error: Unable to determine origin of type `struct smbXsrv_pending_break'
source3/librpc/idl/smbXsrv.idl:151: error: Unable to determine origin of type `struct smbXsrv_pending_break'
source3/librpc/idl/smbXsrv.idl:248: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:248: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:250: error: Unable to determine origin of type `struct smbXsrv_connection'
source3/librpc/idl/smbXsrv.idl:250: error: Unable to determine origin of type `struct smbXsrv_connection'
source3/librpc/idl/smbXsrv.idl:256: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:256: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:275: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:275: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:277: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:277: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:279: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:279: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:281: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:281: error: Unable to determine origin of type `struct smb2_signing_key'
source3/librpc/idl/smbXsrv.idl:318: error: Unable to determine origin of type `struct smbXsrv_connection'
source3/librpc/idl/smbXsrv.idl:318: error: Unable to determine origin of type `struct smbXsrv_connection'
source3/librpc/idl/smbXsrv.idl:319: error: Unable to determine origin of type `struct gensec_security'
source3/librpc/idl/smbXsrv.idl:319: error: Unable to determine origin of type `struct gensec_security'
source3/librpc/idl/smbXsrv.idl:320: error: Unable to determine origin of type `struct smbXsrv_preauth'
source3/librpc/idl/smbXsrv.idl:320: error: Unable to determine origin of type `struct smbXsrv_preauth'
source3/librpc/idl/smbXsrv.idl:329: error: Unable to determine origin of type `struct smbXsrv_session_table'
source3/librpc/idl/smbXsrv.idl:329: error: Unable to determine origin of type `struct smbXsrv_session_table'
source3/librpc/idl/smbXsrv.idl:330: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:330: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:340: error: Unable to determine origin of type `struct smbXsrv_tcon_table'
source3/librpc/idl/smbXsrv.idl:340: error: Unable to determine origin of type `struct smbXsrv_tcon_table'
source3/librpc/idl/smbXsrv.idl:389: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:389: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:431: error: Unable to determine origin of type `struct smbXsrv_tcon_table'
source3/librpc/idl/smbXsrv.idl:431: error: Unable to determine origin of type `struct smbXsrv_tcon_table'
source3/librpc/idl/smbXsrv.idl:432: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:432: error: Unable to determine origin of type `struct db_record'
source3/librpc/idl/smbXsrv.idl:437: error: Unable to determine origin of type `struct connection_struct'
source3/librpc/idl/smbXsrv.idl:437: error: Unable to determine origin of type `struct connection_struct'
source3/librpc/idl/smbXsrv.idl:516: error: Unable to determine origin of type `struct smbXsrv_open_table'
source3/librpc/idl/smbXsrv.idl:516: error: Unable to determine origin of type `struct smbXsrv_open_table'
source3/librpc/idl/smbXsrv.idl:521: error: Unable to determine origin of type `struct files_struct'
source3/librpc/idl/smbXsrv.idl:521: error: Unable to determine origin of type `struct files_struct'

But afterwards, compilation runs fine, and samba then also seems to work fine. Are these normal/expected? Maybe they were there before, and I just missed them?

[Tim Tassonis]

Fixed in commit 89b9739af1