Opened 2 months ago

Closed 8 weeks ago

#20102 closed enhancement (fixed)

Port QtWebEngine to use system ffmpeg 7

Reported by: Xi Ruoyao Owned by: Douglas R. Reno
Priority: normal Milestone: 12.2
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

Change History (6)

comment:1 by Bruce Dubbs, 2 months ago

I'm not sure how it applies.

$ grep +++ ../qtwebengine-ffmpeg-7.patch
 .../clear_key_cdm/ffmpeg_cdm_audio_decoder.cc | 29 ++++++++++---------
 media/ffmpeg/ffmpeg_common.cc                 | 11 +++----
 media/filters/audio_file_reader.cc            |  9 +++---
 .../filters/audio_video_metadata_extractor.cc | 11 +++++--
 .../filters/ffmpeg_aac_bitstream_converter.cc |  7 +++--
 media/filters/ffmpeg_audio_decoder.cc         | 13 +++++----
+++ b/media/cdm/library_cdm/clear_key_cdm/ffmpeg_cdm_audio_decoder.cc
+++ b/media/ffmpeg/ffmpeg_common.cc
+++ b/media/filters/audio_file_reader.cc
+++ b/media/filters/ffmpeg_aac_bitstream_converter.cc
+++ b/media/filters/ffmpeg_aac_bitstream_converter_unittest.cc
+++ b/media/filters/ffmpeg_audio_decoder.cc
+++ b/media/filters/ffmpeg_video_decoder.cc
+++ b/media/filters/ffmpeg_video_decoder.h
+++ b/media/ffmpeg/ffmpeg_common.cc
+++ b/media/ffmpeg/ffmpeg_regression_tests.cc
+++ b/media/filters/audio_decoder_unittest.cc
+++ b/media/filters/audio_file_reader_unittest.cc
+++ b/media/filters/ffmpeg_video_decoder.cc
+++ b/media/filters/audio_file_reader.cc

I guess after extracting qtwebengine it needs:

pushd src/3rdparty/chromium/
patch -Np1 -i ../../../../qtwebengine-ffmpeg-7.patch
popd

At least that applied with some offsets and fuzz.

I have not tried building.

comment:2 by Xi Ruoyao, 2 months ago

patch -Np1 -d src/3rdparty/chromium < ../qtwebengine-ffmpeg-7.patch

should be easier. Note that using -i instead of < won't work.

in reply to:  2 ; comment:3 by Bruce Dubbs, 2 months ago

Replying to Xi Ruoyao:

patch -Np1 -d src/3rdparty/chromium < ../qtwebengine-ffmpeg-7.patch

should be easier. Note that using -i instead of < won't work.

Wouldn't the output then be to stdout?

in reply to:  3 comment:4 by Xi Ruoyao, 2 months ago

Replying to Bruce Dubbs:

Replying to Xi Ruoyao:

patch -Np1 -d src/3rdparty/chromium < ../qtwebengine-ffmpeg-7.patch

should be easier. Note that using -i instead of < won't work.

Wouldn't the output then be to stdout?

No, patch is not sed :).

comment:5 by Douglas R. Reno, 2 months ago

Owner: changed from blfs-book to Douglas R. Reno
Status: newassigned

comment:6 by Douglas R. Reno, 8 weeks ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.