x265-4.1

[Bruce Dubbs]

New major version.

[Xi Ruoyao]

Note that this will cause gst-plugins-bad and ffmpeg FTBFS.

[Xi Ruoyao]

For gst-plugins-bad: ​https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3808

[Douglas R. Reno]

This might get it for ffmpeg:

​https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/0458a86656b291c7e91564efe44e109f97f7032a

[Douglas R. Reno]

imlib2 doesn't use x265 anymore

We are missing a dependency on x265 in VLC though, and it does not build with x265-4.0. Going to look for a patch next.

[Douglas R. Reno]

No patch is available, and given that gst-plugins-bad is also still broken, let's wait on this. I was able to come up with a chunk of code for VLC that allowed it to build, however crashed when trying to encode an x265 file. Here's what upstream has to say about this: ​https://mailman.videolan.org/pipermail/x265-devel/2024-September/013945.html, and the API docs are at ​https://x265.readthedocs.io/en/master/api.html#encoder

Note that you will see an update commit and then a revert commit. I had updated it in my sandbox expecting to be able to use it, but this is unusable until ffmpeg/vlc/gst-plugins-bad are updated to use it. ffmpeg's patch does seem to build but I have not tested it.

[Douglas R. Reno]

It looks like gst-plugins-bad now has support, but VLC does not. I requested an account at VLC's gitlab instance to see if we can get a bug report filed there.

[Xi Ruoyao]

Replying to Douglas R. Reno:

It looks like gst-plugins-bad now has support, but VLC does not. I requested an account at VLC's gitlab instance to see if we can get a bug report filed there.

gst-plugins-bad still does not work.

[Douglas R. Reno]

​https://code.videolan.org/videolan/vlc/-/issues/28799 opened up with VLC

I had to get administrator approval from VideoLAN when creating the GitLab account, and it required MFA.

[Xi Ruoyao]

A temporary work around is -D x265=disabled for gst-plugins-bad. Note that the libgstx265 plugin can only encode x265 (i.e. it cannot decode) and most people don't ever need to encode x265.

[Douglas R. Reno]

There's now a pull request at VLC: ​https://code.videolan.org/videolan/vlc/-/merge_requests/6092

I'll give that a shot later and see how it works.

[Joe Locash]

Replying to Douglas R. Reno:

There's now a pull request at VLC: ​https://code.videolan.org/videolan/vlc/-/merge_requests/6092

I'll give that a shot later and see how it works.

It's been merged.

[Xi Ruoyao]

The upstream has reverted the change breaking downstream packages: ​https://bitbucket.org/multicoreware/x265_git/commits/78e5b703b1

[Bruce Dubbs]

Release notes are at ​https://x265.readthedocs.io/en/master/releasenotes.html

This may help: "Reverted the 4.0 api changes."

[Xi Ruoyao]

But gst-plugins-bad still FTBFS:

../ext/x265/gstx265enc.c: In function 'gst_x265_enc_init_encoder_locked':
../ext/x265/gstx265enc.c:951:54: error: assignment to expression with array type
  951 |       encoder->x265param.masteringDisplayColorVolume =
      |                                                      ^

[Xi Ruoyao]

Replying to Xi Ruoyao:

But gst-plugins-bad still FTBFS:

../ext/x265/gstx265enc.c: In function 'gst_x265_enc_init_encoder_locked':
../ext/x265/gstx265enc.c:951:54: error: assignment to expression with array type
  951 |       encoder->x265param.masteringDisplayColorVolume =
      |                                                      ^

​https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7968

[Bruce Dubbs]

I checked gst-plugins-bad with the patch and it built/tested fine.

However ffmpeg FTBFS:

libavcodec/libx265.c: In function ‘libx265_encode_frame’:
libavcodec/libx265.c:813:59: error: passing argument 5 of ‘ctx->api->encoder_encode’ from incompatible pointer type [-Wincompatible-pointer-types]
  813 |                                    pic ? &x265pic : NULL, x265pic_lyrptr_out);
      |                                                           ^~~~~~~~~~~~~~~~~~
      |                                                           |
      |                                                           x265_picture **
libavcodec/libx265.c:813:59: note: expected ‘x265_picture *’ but argument is of type ‘x265_picture **’
CC      libavcodec/lossless_videodsp.o
make: *** [ffbuild/common.mak:81: libavcodec/libx265.o] Error 1

I was able to get it you build with:

   sed -i '/, x265pic_lyrptr/s/x265pic/*&/' libavcodec/libx265.c

(No, it will not apply twice.)

Unfortunately, I do not know if this "does the right thing."

[Bruce Dubbs]

I should have looked upstream first. They have

sed -e 's/X265_BUILD >= 210/(X265_BUILD >= 210) \&\& (X265_BUILD < 213)/' \

-i libavcodec/libx265.c

Tested and build is OK.

[Xi Ruoyao]

Replying to Bruce Dubbs:

I should have looked upstream first. They have

sed -e 's/X265_BUILD >= 210/(X265_BUILD >= 210) \&\& (X265_BUILD < 213)/' \

-i libavcodec/libx265.c

Tested and build is OK.

You can simplify it to

 sed -e 's/X265_BUILD >= 210/(&) \&\& (X265_BUILD < 213)/' \
     -i libavcodec/libx265.c

[Bruce Dubbs]

Fixed at commit 7177ed5ce5.