Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#20681 closed enhancement (fixed)

Mesa-24.3.1

Reported by: zeckma Owned by: zeckma
Priority: normal Milestone: 12.3
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

New minor release.

Change History (23)

comment:1 by zeckma, 3 months ago

Release notes (from https://docs.mesa3d.org/relnotes/24.3.0.html):

New features

  • Expose Vulkan 1.3 on v3dv, both rpi4 and rpi5
  • VK_EXT_descriptor_buffer on nvk
  • VK_EXT_post_depth_coverage on nvk
  • VK_KHR_video_maintenance1 on radv
  • VK_EXT_legacy_vertex_attributes on nvk
  • GL_KHR_shader_subgroup on radeonsi
  • VK_KHR_maintenance7 on nvk
  • VK_KHR_dynamic_rendering_local_read on nvk
  • GL_ARB_timer_query on Panfrost
  • GL_EXT_disjoint_timer_query on Panfrost
  • VK_KHR_pipeline_binary on RADV
  • VK_KHR_compute_shader_derivatives on anv

...

Bug fixes

  • anv: Use-after-free detected by AddressSanitizer while running dEQP-VK
  • Confidential issue #11770
  • radv: DCC causes glitches in Red Dead Redemption 2
  • A5xx rendering issues with firefox
  • [ANV][Regression] Broken rendering in Flycast + Per-Pixel Alpha Sorting
  • vtn: OpTypeStruct in kernel parameters trigger assertion in glsl_types.h
  • anv: Assertion failure in dEQP-VK.image.extended_usage_bit_compatibility.image_format_list.s8_uint_optimal_transfer_src_bit
  • radv: Resident Evil 6 Benchmark Tool has artifacts on 7900 XTX when DCC is enabled, game launched on 4K monitor without scaling and with FullHD settings
  • [AMD RX 6700 XT] Artifacts while upscaling games in fullscreen mode
  • Distorted pixelated graphics with Radeon RX 7900 XT with some games
  • Total War Warhammer 2 Graphical Glitch
  • Glitching artifacts in tile shaped patterns on 6700 XT, when using upscaled fullscreen game on labwc

...

More for each category and all changes can be found at the link in the beginning.

comment:2 by Xi Ruoyao, 3 months ago

Summary: Mesa-23.3.0Mesa-23.3.0 (wait for 23.3.1)

The release note says:

Mesa 24.3.0 is a new development release. People who are concerned with stability and reliability should stick with a previous release or wait for Mesa 24.3.1.

That's why we consider all x.y.0 releases unstable for Mesa.

comment:3 by Xi Ruoyao, 3 months ago

Someone claimed:

with Mesa version 24.3, support for the DRI2 protocol was separated and made optional. To enable it, you need to specify legacy-x11=dri2.

Currently, in BLFS, there are no programs that directly depend on the DRI2 graphical interface, though I encountered the most issues with Steam. However, some problems I was having with Firefox were resolved after I recompiled Mesa with DRI2 support. Specifically, when using Firefox with Telegram Web, animated stickers weren't rendered, and, annoyingly, pasting an image appeared error-free, but once sent, the recipient only received a black box.

This is just one example of minor issues, but they could still justify retaining DRI2 support.

Is this true?

Last edited 3 months ago by Xi Ruoyao (previous) (diff)

in reply to:  2 comment:4 by zeckma, 3 months ago

Replying to Xi Ruoyao:

The release note says:

Mesa 24.3.0 is a new development release. People who are concerned with stability and reliability should stick with a previous release or wait for Mesa 24.3.1.

That's why we consider all x.y.0 releases unstable for Mesa.

I noticed the last two x.y.0 (x.y.1) mesa tickets said wait for x.y.1 but I didn't want to put (wait for 24.3.1) as I didn't know if it should apply to every x.y.0 release or was situational. Will keep this in mind if and when I report a new Mesa x.y.0 release in the future.

in reply to:  3 ; comment:5 by zeckma, 3 months ago

Replying to Xi Ruoyao:

Someone claimed:

with Mesa version 24.3, support for the DRI2 protocol was separated and made optional. To enable it, you need to specify legacy-x11=dri2.

Currently, in BLFS, there are no programs that directly depend on the DRI2 graphical interface, though I encountered the most issues with Steam. However, some problems I was having with Firefox were resolved after I recompiled Mesa with DRI2 support. Specifically, when using Firefox with Telegram Web, animated stickers weren't rendered, and, annoyingly, pasting an image appeared error-free, but once sent, the recipient only received a black box.

This is just one example of minor issues, but they could still justify retaining DRI2 support.

Is this true?

I can test this and do stress testing with Steam and Firefox to find the "issues" if any. If there are, I can try the suggested option and see if that makes the issues go away. If not, I don't think it's a major concern.

comment:6 by Xi Ruoyao, 3 months ago

If we need the option for now, I'd hope someone can report the issue to Mesa (or Firefox or Steam) as I've suggested in the reply to the original report.

in reply to:  6 comment:7 by zeckma, 3 months ago

Replying to Xi Ruoyao:

If we need the option for now, I'd hope someone can report the issue to Mesa (or Firefox or Steam) as I've suggested in the reply to the original report.

I will report it upstream if issues do come up.

in reply to:  5 ; comment:8 by zeckma, 3 months ago

Replying to zeckma:

Replying to Xi Ruoyao:

Someone claimed:

with Mesa version 24.3, support for the DRI2 protocol was separated and made optional. To enable it, you need to specify legacy-x11=dri2.

Currently, in BLFS, there are no programs that directly depend on the DRI2 graphical interface, though I encountered the most issues with Steam. However, some problems I was having with Firefox were resolved after I recompiled Mesa with DRI2 support. Specifically, when using Firefox with Telegram Web, animated stickers weren't rendered, and, annoyingly, pasting an image appeared error-free, but once sent, the recipient only received a black box.

This is just one example of minor issues, but they could still justify retaining DRI2 support.

Is this true?

I can test this and do stress testing with Steam and Firefox to find the "issues" if any. If there are, I can try the suggested option and see if that makes the issues go away. If not, I don't think it's a major concern.

So far, there does not appear to be any big issues except revolving around Zink w/ NVK which is not affected by the option (and it does indeed exist, specifically -D legacy-x11={none,dri2} (none by default)). I may have to test this when 24.3.1 releases so I can tell what is an issue caused by dri2 missing or is simply an issue with Mesa. Even while I write this, Firefox is flashing, with dri2 support compiled, and does the same without.

Steam however has absolutely zero hitches, so if the biggest issues showed up in Steam according to what that user claimed, and I found none so far, we probably don't need to go out of our way to add that support and shouldn't see anything major pop up with BLFS packages as a result.

in reply to:  8 comment:9 by Xi Ruoyao, 3 months ago

Replying to zeckma:

So far, there does not appear to be any big issues except revolving around Zink w/ NVK which is not affected by the option (and it does indeed exist, specifically -D legacy-x11={none,dri2} (none by default)). I may have to test this when 24.3.1 releases so I can tell what is an issue caused by dri2 missing or is simply an issue with Mesa. Even while I write this, Firefox is flashing, with dri2 support compiled, and does the same without.

I suggest to search in Mesa and Firefox issue trackers and make a report if there's none. If they don't ever know things are blowing up it's not likely the next release -will be fixed.

Last edited 3 months ago by Xi Ruoyao (previous) (diff)

comment:10 by zeckma, 3 months ago

Summary: Mesa-23.3.0 (wait for 23.3.1)Mesa-24.3.0 (wait for 24.3.1)

The new version is 24.3.0, not 23.3.0, which I got wrong when I made this ticket.

comment:11 by Joe Locash, 3 months ago

For 24.3.0 mesa-add_xdemos-3.patch needs to be updated for hunk 1.

This should do it:

diff -Nuarp mesa-24.3.0.orig/src/glx/meson.build mesa-24.3.0/src/glx/meson.build
--- mesa-24.3.0.orig/src/glx/meson.build        2024-11-21 11:27:38.000000000 -0500
+++ mesa-24.3.0/src/glx/meson.build     2024-11-25 14:54:33.119112557 -0500
@@ -145,3 +145,5 @@ libgl = shared_library(
   darwin_versions : '4.0.0',
   install : true,
 )
+
+subdir('xdemos')

in reply to:  8 comment:12 by zeckma, 3 months ago

Replying to zeckma:

So far, there does not appear to be any big issues except revolving around Zink w/ NVK which is not affected by the option (and it does indeed exist, specifically -D legacy-x11={none,dri2} (none by default)). I may have to test this when 24.3.1 releases so I can tell what is an issue caused by dri2 missing or is simply an issue with Mesa. Even while I write this, Firefox is flashing, with dri2 support compiled, and does the same without.

Steam however has absolutely zero hitches, so if the biggest issues showed up in Steam according to what that user claimed, and I found none so far, we probably don't need to go out of our way to add that support and shouldn't see anything major pop up with BLFS packages as a result.

I have done more testing. There are no issues I have come across with dri2 being axed. We shouldn't need to change instructions in that regard. It may have been an issue during development of 24.3, or the inherent nature of Mesa git. It isn't an issue anymore. Most things should have moved to DRI3 by now.

comment:13 by Douglas R. Reno, 3 months ago

Summary: Mesa-24.3.0 (wait for 24.3.1)Mesa-24.3.1

in reply to:  11 comment:14 by Xi Ruoyao, 3 months ago

Replying to Joe Locash:

For 24.3.0 mesa-add_xdemos-3.patch needs to be updated for hunk 1.

This should do it:

diff -Nuarp mesa-24.3.0.orig/src/glx/meson.build mesa-24.3.0/src/glx/meson.build
--- mesa-24.3.0.orig/src/glx/meson.build        2024-11-21 11:27:38.000000000 -0500
+++ mesa-24.3.0/src/glx/meson.build     2024-11-25 14:54:33.119112557 -0500
@@ -145,3 +145,5 @@ libgl = shared_library(
   darwin_versions : '4.0.0',
   install : true,
 )
+
+subdir('xdemos')

We already have this line but it fails to apply:

Hunk #1 FAILED at 165.
1 out of 1 hunk FAILED -- saving rejects to file src/glx/meson.build.rej

We need to fix that instead of just appending a hunk and cover up the issue.

comment:16 by zeckma, 3 months ago

My proposed fix for the flickering/flashing in FF+TB has not been put into Mesa-24.3.1 and has not been acknowledged yet. In GLFS, I'll make a patch for seizure prevention. The xdemos patch should not interfere with the seizure prevention patch, if it's decided that this behavior should be fixed in BLFS as well.

comment:17 by Bruce Dubbs, 3 months ago

zeckma, Why don't you put your patch into BLFS mesa as a recommended fix. Just explain why someone might want to use it.

in reply to:  17 comment:18 by zeckma, 3 months ago

Replying to Bruce Dubbs:

zeckma, Why don't you put your patch into BLFS mesa as a recommended fix. Just explain why someone might want to use it.

I will do that, then. Just got done with making the patch and working some other stuff out.

comment:19 by zeckma, 3 months ago

Owner: changed from blfs-book to zeckma
Status: newassigned

comment:20 by zeckma, 3 months ago

Resolution: fixed
Status: assignedclosed

comment:21 by Xi Ruoyao, 3 months ago

Hmm we generally don't take unreviewed patches. And in this case the code quality looks pretty bad: why true || x instead of just true?

Last edited 3 months ago by Xi Ruoyao (previous) (diff)

comment:22 by Xi Ruoyao, 3 months ago

The patch should be at least submitted upstream for review. Before submission please fix the true || x nonsense.

comment:23 by Xi Ruoyao, 3 months ago

I've taken out the patch for now. The commit message r12.2-789-g998d713794 contains enough reasons.

Note: See TracTickets for help on using tickets.