Opened 7 weeks ago
Closed 6 weeks ago
#21163 closed enhancement (fixed)
faac-1.31
Reported by: | Bruce Dubbs | Owned by: | Bruce Dubbs |
---|---|---|---|
Priority: | normal | Milestone: | 12.3 |
Component: | BOOK | Version: | git |
Severity: | normal | Keywords: | |
Cc: |
Description ¶
New minor version.
Change History (9)
comment:1 by , 7 weeks ago
comment:2 by , 7 weeks ago
Yes, the names are stupid, but there is not much we can do about it other than repackaging the tarballs and uploading to anduin. We could add a note something like:
Upstream is at <url>, but their package name and directory name are confusing, The BLFS editors have repackaged the tarball only changing the tarball name and top level directory name.
comment:3 by , 7 weeks ago
Repackaging adds editors' work and I'd not do that. I'm proposing to just use https://github.com/knik0/faac/archive/faac-1.31.tar.gz but document that you'll get a different name if you download via a browser (or anything parsing the HTTP header for file name), and document the extracted directory name will be different.
And then we can also switch back libxkbcommon, intel-media, etc. back to the "well" names.
follow-up: 5 comment:4 by , 7 weeks ago
Actually I wonder if this is an artifact of github. The upstream only has the github generated tarball. The site at github is '/knik0/faac/' and I think the release process is adding that initial faac so the tarball and the directory become faac-faac-1.31.tar.gz when the maintainer probably intended just a simple faac-1.31.tar.gz.
Just guessing, but if the user just said 1.31, then the result might be correct.
I'll create an issue.
comment:5 by , 7 weeks ago
Replying to Bruce Dubbs:
Actually I wonder if this is an artifact of github. The upstream only has the github generated tarball. The site at github is '/knik0/faac/' and I think the release process is adding that initial faac so the tarball and the directory become faac-faac-1.31.tar.gz when the maintainer probably intended just a simple faac-1.31.tar.gz.
Just guessing, but if the user just said 1.31, then the result might be correct.
Yes it will be correct if they rename the tag.
I'll create an issue.
But when I (and another guy) complained this to libxkbcommon the upstream refuses to listen: https://github.com/xkbcommon/libxkbcommon/issues/657.
Another option is creating forks for the problematic packages under https://github.com/lfs-book/ with a GitHub action daily pulling tags from the upstream and creating tags with a better name.
comment:6 by , 7 weeks ago
I just released sysmon3-3.0.1 on gitgub. I named the release 'sysmon3-3.0.1' and sure enough github named the generated tarball 'sysmon3-sysmon3-3.0.1.tar.gz'. In this case though I also uploaded a properly constructed and named tarball.
I guess the trick is to 'name' the release with just a version number and let the tarball name be taken from the project.
comment:7 by , 7 weeks ago
Milestone: | 12.4 → 12.3 |
---|---|
Owner: | changed from | to
Status: | new → assigned |
comment:8 by , 7 weeks ago
FAAC 1.31
- updated Visual Studio projects to VS 2019
- main.c : progress report keeps alignment when encoding a large file
- project/msvc : cleanup, fixes and changes
- frontend: fix out-of-root build
- add a pkg-config file
- avoid division by zero
- Remove #pragma pack from faacEncStruct
- Reduce memory
- Remove BwpInfo bwpInfo from struct CoderInfo
- Remove nextSampleBuff[] and next2SampleBuff[] from struct faacEncStruct
- tns: Initialize rArray[] variable
- update autoconf.ac and friends
- do not pass add-stdcall-alias option to clang
- always build both the regular and the DRM library
- fix cppcheck warnings
- add some basic CI
- fix compilation with clang on Windows
- Append INSTALL to README
- Add album artist and various sort order MP4 tags
- set libfaac library name to "faac" rather than "libfaac"
- Error C2065 (add #define _USE_MATH_DEFINES)
- Allow genre-id up to 255
comment:9 by , 6 weeks ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed at commits
2d5be80cc5 Update to faac-1.31. db10d461c5 Update to gi_docgen-2025.3 (Python module). 99edc7b299 Update to sphinx-8.2.1 (Python module). ed97668fd9 Update to fltk-1.4.2. e41f02790a Update to bind9 and bind-utilities-9.20.6.
Another stupid file name issue. https://github.com/knik0/faac/archive/faac-1.31.tar.gz gives faac-faac-1.31.tar.gz if downloading via a browser, and it extracts into faac-faac-1.31 anyway (via browser or wget).
To make a "consistent" file name we'd have to use https://github.com/knik0/faac/archive/faac-1.31/faac-faac-1.31.tar.gz.
I think I've had enough of this. Should we just use our own "rational" file names and add a note like "please download via wget or curl"?