Opened 19 months ago
Closed 19 months ago
#21269 closed enhancement (fixed)
gnome-system-monitor-48.0
| Reported by: | Bruce Dubbs | Owned by: | Douglas R. Reno |
|---|---|---|---|
| Priority: | normal | Milestone: | 12.4 |
| Component: | BOOK | Version: | git |
| Severity: | medium | Keywords: | |
| Cc: |
Description
New major version.
Change History (6)
comment:1 by , 19 months ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 19 months ago
comment:3 by , 19 months ago
This one is a bit more complex than I expected. Upstream added a couple of unit tests two months ago, but they require an external dependency called "catch2". Looking at Arch, the only thing that uses it that we carry is gnome-system-monitor. They can't be disabled with an option, which would make catch2 a required dependency.
I've found a way to remove the dependency via two seds, which disable building the unit tests:
find . -name meson.build | xargs sed -i -e '/catch2/d' sed -i '152,162d' src/meson.build
That being said, do we want to add the package to the book, or use the seds? I'm personally leaning towards the seds but that does carry the added problem of having to check src/meson.build to adjust the numbers for the deletion. I have no problem adding catch2 to the book if we think it's necessary though.
comment:4 by , 19 months ago
We do not want to add packages for tests. Either adjust the test procedure or skip test completely.
comment:6 by , 19 months ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |

48.alpha
48.beta
48.rc
48.0