Opened 14 months ago

Closed 12 months ago

Last modified 8 months ago

#22020 closed enhancement (fixed)

llvm/libclc-21.1.2

Reported by: Bruce Dubbs Owned by: Xi Ruoyao
Priority: normal Milestone: 13.0
Component: BOOK Version: git
Severity: medium Keywords:
Cc:

Description

New minor version.

Change History (12)

comment:1 by Xi Ruoyao, 14 months ago

Owner: changed from blfs-book to Xi Ruoyao
Status: new → assigned

comment:2 by martyj19, 14 months ago

I experience a failure to compile a few seconds in and I find I need

ln -sfv ../../third-party-$(VERSION).src/siphash/include/siphash llvm-$(VERSION)/include

and the sed for third-party didn't do anything to help. Be interesting to see if others can confirm. Other than that no issues with llvm/clang/cmake/third-party 21.1.0, SPIRV-LLVM-Translator 21.1.0, libclc 21.1.0, mesa 25.2.1 rebuild. It should be noted I cut down the build to the minimum needed by that mesa dependency.

Last edited 14 months ago by martyj19 (previous) (diff)

comment:3 by Xi Ruoyao, 14 months ago

I cannot reproduce it. The only two references to SipHash headers are

projects/compiler-rt/lib/builtins/aarch64/emupac.cpp:#include "siphash/SipHash.h"
lib/Support/SipHash.cpp:#include "siphash/SipHash.h"

We are not building aarch64 compiler-rt so the first one does not matter. For the second one there's clearly

target_include_directories(LLVMSupport SYSTEM
  PRIVATE
  ${LLVM_THIRD_PARTY_DIR}/siphash/include
  )

in lib/Support/CMakeLists.txt, and our sed sets LLVM_THIRD_PARTY_DIR correctly, thus this should work fine.

Last edited 14 months ago by Xi Ruoyao (previous) (diff)

comment:4 by Xi Ruoyao, 14 months ago

In rustc there are 3 additional test failures indicating a layout mismatch for the amdgpu target, and 2 additional ones triggered by some minor code generation change in x86.

I'm finding patches for them.

comment:6 by Xi Ruoyao, 13 months ago

Summary: llvm/libclc-21.1.0 → llvm/libclc-21.1.0 (wait for new Vulkan SDK release)

We need a new vulkan sdk release before updating spirv-llvm-translator, that libclc requires.

comment:7 by Xi Ruoyao, 13 months ago

Summary: llvm/libclc-21.1.0 (wait for new Vulkan SDK release) → llvm/libclc-21.1.1 (wait for new Vulkan SDK release)

Now 21.1.1.

comment:8 by Xi Ruoyao, 12 months ago

Summary: llvm/libclc-21.1.1 (wait for new Vulkan SDK release) → llvm/libclc-21.1.2

comment:9 by Xi Ruoyao, 12 months ago

llvm-21.1.3 may be released tomorrow but I'll update to 21.1.2 anyway. We'll wait until the last 21.1.z release then.

comment:11 by Xi Ruoyao, 12 months ago

Resolution: → fixed
Status: assigned → closed

Fixed:

Firefox builds fine (with nasm-3.01-rc3).

comment:12 by Bruce Dubbs, 8 months ago

Milestone: 12.5 → 13.0

Milestone renamed

Note: See TracTickets for help on using tickets.