Opened 12 months ago

Closed 10 months ago

Last modified 8 months ago

#22231 closed defect (fixed)

libreoffice-25.8.3.2

Reported by: Joe Locash Owned by: Bruce Dubbs
Priority: normal Milestone: 13.0
Component: BOOK Version: git
Severity: medium Keywords:
Cc:

Description

Seeing these errors when building:

/tmp/build/libreoffice-25.8.1.1/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:220:78: error: no matching function for call to 'std::optional<GooString>::optional(GooString*&)'
  220 |                                    std::optional<GooString>(pOwnerPasswordStr),
      |                                                                              ^
/tmp/build/libreoffice-25.8.1.1/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:221:77: error: no matching function for call to 'std::optional<GooString>::optional(GooString*&)'
  221 |                                    std::optional<GooString>(pUserPasswordStr)));
      |                                                                             ^

Attachments (2)

libreoffice-25.8.2.2-poppler_25.10-1.patch​ (2.6 KB ) - added by martyj19 12 months ago.
Address build failure with poppler-25.10
libreoffice-25.8.2.2-poppler_25.10-2.patch​ (1.3 KB ) - added by martyj19 12 months ago.
Poppler 25.10 correction via Arch

Download all attachments as: .zip

Change History (16)

comment:1 by Douglas R. Reno, 12 months ago

Owner: changed from blfs-book to Douglas R. Reno
Status: new → assigned

I'll take this for now, but as far as I can tell there's been no changes upstream yet for it quite yet

comment:2 by Douglas R. Reno, 12 months ago

Summary: LibreOffice FTBFS with poppler-25.10.0 → LibreOffice FTBFS with poppler-25.10.0 (and update to libreoffice-25.8.2.1)

A new version of Libreoffice is available but I don't see any Poppler related fixes in here yet

comment:3 by martyj19, 12 months ago

The proper new version is 25.8.2.2. It took much longer than normal to get uploaded after the version was announced. I did not see it on the download site until October 10. I did see that Arch put up 25.8.2.1 which is RC1. I have been holding back on addressing the Poppler change until the release.

comment:4 by Douglas R. Reno, 12 months ago

Summary: LibreOffice FTBFS with poppler-25.10.0 (and update to libreoffice-25.8.2.1) → LibreOffice FTBFS with poppler-25.10.0 (and update to libreoffice-25.8.2.2)

Thank you Marty, looking forward to seeing what you come up with!

by martyj19, 12 months ago

Address build failure with poppler-25.10

comment:5 by Joe Locash, 12 months ago

Builds fine here with Marty's patch.

comment:6 by martyj19, 12 months ago

It would be helpful if someone looked that patch over who is more conversant with std::optional and std::make_unique. At this point GooString is approximately equal to std::string. I am suspicious that the myStringToStdString are no longer needed. I have not tested the code flow through the patch beyond seeing that it compiles. The uses I make of Libreoffice work normally.

Last edited 12 months ago by martyj19 (previous) (diff)

comment:7 by Douglas R. Reno, 12 months ago

I'll take a look at it in a little while and try loading a password-protected PDF file that I have

by martyj19, 12 months ago

Poppler 25.10 correction via Arch

comment:8 by martyj19, 12 months ago

Updated with patch from Arch. My -1 version probably should be disregarded.

comment:9 by Joe Locash, 10 months ago

There are no tickets for these yet but libreoffice-25.8.3.2 builds fine with poppler-25.11.0.

comment:10 by Bruce Dubbs, 10 months ago

Summary: LibreOffice FTBFS with poppler-25.10.0 (and update to libreoffice-25.8.2.2) → LibreOffice FTBFS with poppler-25.10.0 (and update to libreoffice-25.8.3.2)

comment:11 by Douglas R. Reno, 10 months ago

Owner: changed from Douglas R. Reno to Bruce Dubbs
Status: assigned → new
Summary: LibreOffice FTBFS with poppler-25.10.0 (and update to libreoffice-25.8.3.2) → libreoffice-25.8.3.2

comment:12 by Bruce Dubbs, 10 months ago

Status: new → assigned

comment:13 by Bruce Dubbs, 10 months ago

Resolution: → fixed
Status: assigned → closed

Fixed at commit ab25232dea.

comment:14 by Bruce Dubbs, 8 months ago

Milestone: 12.5 → 13.0

Milestone renamed

Note: See TracTickets for help on using tickets.