Vorbis Tools 1.1.1 Fixes

[Ag. Hatzimanikas]

Please check this (1) ticket first,for the issue. This is easy fixable with a simple sed.

sed -i '/CURLOPT_MUTE/d' ogg123/http_transport.c

A patch will be attached also,if you prefer the fix,as a patch.

I am not sure about the milestone,so feel free to change it. Same goes for curl #2041,which the update is targeted for the 6.2.1.

1. ​https://trac.xiph.org/ticket/1101

[Ag. Hatzimanikas]

Attached the diff to the book to fix the issue. I used the sed instead of the patch. Please update.

[Ag. Hatzimanikas]

Please Dan, there is also a problem while linking against flac-1.1.4 (it needs to be updated too, by the way) (1).

Also autoconf needs to be run after applying the patch. So at first, this patch and flac-1.1.4 goes together.

I will try to attach the mentioned patch from arch.org (some headers needed).

And a quick note. For ogg123 to be built, curl and libao are prerequisites, as it is in our book now. If the configure script finds them both, it will try to built it, unless we explicitly use "--disable-ogg123". If we do this, it would be very complicated, in an already complicated page in a rather simple package. I think the sed it doesn't harm at all, so I would suggest to apply it either way and forget the "--disable-ogg123" switch. If someone has culr and libao (especially libao) already installed, he probably expects ogg123.

1. ​http://linuxfromscratch.org/pipermail/blfs-dev/2007-May/017238.html

[Ag. Hatzimanikas]

Linking against flac-1.1.4

[Randy McMurchy]

Here's a quick summary and the required changes to the book:

First the book changes: ================================================== sed -i '/CURLOPT_MUTE/d' ogg123/http_transport.c & patch -Np1 -i ../vorbis-tools-1.1.1-flac-1.patch & autoconf & ==================================================

The patch can be found here: ​http://www.linuxfromscratch.org/patches/downloads/vorbis-tools/vorbis-tools-1.1.1-flac-1.patch

The note about the ogg123 program being built isn't relevant as we are adding the sed unconditionally to the book. Everything else should stay the same.

Bumping the priority of this as FLAC has been updated in the book and as is, Vorbis Tools is broken.

[Randy McMurchy]

I just noticed that apparently the patch breaks $mandir and all the man pages get installed under /man/man1 (root of the disk). This is not good. I'll see what needs to be done.

[Ag. Hatzimanikas]

Patching the sources with the attached patch, the man pages seems to get installed at the right place.

See:

root:root	644	1405	/usr/share/man/man1/ogginfo.1	
root:root	644	6984	/usr/share/man/man1/ogg123.1	
root:root	644	2636	/usr/share/man/man1/oggdec.1	
root:root	644	11395	/usr/share/man/man1/oggenc.1	
root:root	644	1908	/usr/share/man/man1/vorbiscomment.1	

Strange, I will try to built it with your patch and reproduce the problem...

Okey, sorry I am stupid. First: Yes I can reproduce it. The man pages, yes, goes under the /man/man1.

Second: Sorry that I wasn't able to report it, because I couldn't see the error in my logs. And this for the simple silly reason that in my script, while I am applying the patch, but I missing to run autoconf, and the binaries installed without flac support actually. So much time I had it wrong. Error.

Third: When I am running autoconf and trying then to configure the package, at the end I can see messages, like :

config.status: WARNING:  Makefile.in seems to ignore the --datarootdir setting

Now, the switch --mandir=/usr/share/man seems (an easy way to fix ) to respects the hierachy.

[Randy McMurchy]

--mandir

yes, great idea.

I wouldn't worry about the warnings. They don't affect the build (could this be why man pages are screwed up?).

Everything should be set, as all issues seem to be taken care of now. Hopefully, Dan can tear himself away from LFS and knock this one out soon.

[Ag. Hatzimanikas]

Replying to randy@linuxfromscratch.org:

I wouldn't worry about the warnings. They don't affect the build (could this be why man pages are screwed up?).

Oh yes, here is the configure --help:

 --mandir=DIR           man documentation [DATAROOTDIR/man]

[dnicholson@…]

Randy, you're way ahead of me here. I haven't done anything local for this ticket. Feel free to take the ticket since you're rocking right now :)

[Randy McMurchy]

Following changes were applied to the Vorbis Tools instructions:

1. Add a sed to fix the cURL issue
2. Add a patch (and run autoconf) to fix the FLAC issue
3. Add --mandir parameter to configure for the man page issue