gdk-pixbuf change breaks the build of gtkmm-3

[Joe Locash]

With the recent change to gdk-pixbuf I now see this when building gtkmm-3:

[267/351] Generating demos/gtk-demo/demo-resources_c with a custom command
FAILED: [code=1] demos/gtk-demo/demo-resources.c 
/usr/bin/glib-compile-resources ../demos/gtk-demo/demo.gresource.xml --sourcedir /tmp/build/gtkmm-3.24.10/demos/gtk-demo --sourcedir ../demos/gtk-demo --internal --generate --target demos/gtk-demo/demo-resources.c --dependency-file demos/gtk-demo/demo-resources.c.d
failed to load "/tmp/build/gtkmm-3.24.10/demos/gtk-demo/gnome-fs-directory.png": Couldn’t recognize the image file format for file “/tmp/build/gtkmm-3.24.10/demos/gtk-demo/gnome-fs-directory.png”
../demos/gtk-demo/demo.gresource.xml: Child process exited with code 1.

Removing -D png=disabled from gdk-pixbuf resolves it.

[Xi Ruoyao]

I cannot see how. Glycin is enough to recognize the png file and it's a recommended dependency, i.e. a configuration w/o glycin is unsupported.

[Xi Ruoyao]

And if glycin is enabled the png loader is simply useless, as gdk-pixbuf won't even try it.

[Xi Ruoyao]

I tried this command locally (with a gdk-pixbuf built w/o png):

$ /usr/bin/glib-compile-resources ../demos/gtk-demo/demo.gresource.xml --sourcedir ../demos/gtk-demo --internal --generate --target demos/gtk-demo/demo-resources.c 
WARNING: Glycin running without sandbox.
WARNING: Glycin running without sandbox.

There are two warnings but demos/gtk-demo/demo-resources.c is successfully generated.

[Bruce Dubbs]

Milestone renamed