xfce4-terminal-1.2.0 (wait for 1.2.1)

[Douglas R. Reno]

New minor version

Release notes for 1.2.0
=======================
- build: Rename POTFILES.in to POTFILES
- build: Make xsltproc dependency optional
- Fix previous commit
- Delay tab title update on contents changed to avoid high cpu usage
- cleanup: Move function and set static qualifier
- Do not escape non-ASCII characters in dnded uris
- build: Add 'doc' configure option
- Escape special characters in dnded uris
- build: Fix typo in optimization level
- doc: Add "bugs" section to man page
- search: Shift+Enter for Next; remove throttling
- wayland: dropdown: Handle output disconnection
- I18n: Update po/LINGUAS list
- Allow handling middle click event by terminal applications
- Fix shift + right click propagation to terminal apps
- README.md: Add uninstall info
- Fix hyperlink-related leaks in terminal_widget_get_link
- Remove autotools build
- Use XfceNotebook from libxfce4ui
- Fix "Copy link address" on kwin_wayland
- prefs-dialog: Expose hidden setting 'misc-highlight-urls'
- cleanup: Remove '== (TRUE|FALSE)'
- Update README after switchover to meson
- Adjust include order for FreeBSD
- meson-build: Fix manpage install dir
- Translation Updates:

[Joe Locash]

I'm seeing a build failure:

../terminal/terminal-window-dropdown.c: In function ‘terminal_window_dropdown_fi
nalize’:
../terminal/terminal-window-dropdown.c:570:15: error: ‘TerminalWindowDropdown’ {aka ‘struct _TerminalWindowDropdown’} has no member named ‘set_monitor_idle_id’
  570 |   if (dropdown->set_monitor_idle_id != 0)
      |               ^~
../terminal/terminal-window-dropdown.c:571:30: error: ‘TerminalWindowDropdown’ {aka ‘struct _TerminalWindowDropdown’} has no member named ‘set_monitor_idle_id’
  571 |     g_source_remove (dropdown->set_monitor_idle_id);
      |                              ^~
../terminal/terminal-window-dropdown.c:573:15: error: ‘TerminalWindowDropdown’ {aka ‘struct _TerminalWindowDropdown’} has no member named ‘monitor_removed_idle_id’
  573 |   if (dropdown->monitor_removed_idle_id != 0)
      |               ^~
../terminal/terminal-window-dropdown.c:574:30: error: ‘TerminalWindowDropdown’ {aka ‘struct _TerminalWindowDropdown’} has no member named ‘monitor_removed_idle_id’
  574 |     g_source_remove (dropdown->monitor_removed_idle_id);
      |                              ^~

There is no failure when gtk-layer-shell (not in the book) is installed.

[Bruce Dubbs]

Yes, I created a ticket: ​https://gitlab.xfce.org/apps/xfce4-terminal/-/issues/383

[Bruce Dubbs]

It looks like they may have missed something. There are a lot of instances of

#ifdef HAVE_GTK_LAYER_SHELL

These are in terminal/terminal-window-dropdown.c and terminal/terminal-util.c

[Joe Locash]

I was able to get it to build with this patch I created:

diff -Nuar xfce4-terminal-1.2.0.orig/terminal/terminal-window-dropdown.c xfce4-terminal-1.2.0/terminal/terminal-window-dropdown.c
--- xfce4-terminal-1.2.0.orig/terminal/terminal-window-dropdown.c	2026-03-08 07:12:45.000000000 -0400
+++ xfce4-terminal-1.2.0/terminal/terminal-window-dropdown.c	2026-03-08 15:24:42.603490530 -0400
@@ -567,11 +567,13 @@
   if (dropdown->animation_timeout_id != 0)
     g_source_remove (dropdown->animation_timeout_id);
 
+#ifdef HAVE_GTK_LAYER_SHELL
   if (dropdown->set_monitor_idle_id != 0)
     g_source_remove (dropdown->set_monitor_idle_id);
 
   if (dropdown->monitor_removed_idle_id != 0)
     g_source_remove (dropdown->monitor_removed_idle_id);
+#endif
 
   if (dropdown->status_icon != NULL)
     g_object_unref (G_OBJECT (dropdown->status_icon));

[Bruce Dubbs]

OK, I got it to work.

sed -e '570i #ifdef HAVE_GTK_LAYER_SHELL' \
    -e '574a #endif'                      \
    -i  terminal/terminal-window-dropdown.c

I do not like the line numbers, but they work for this version.

[Bruce Dubbs]

LOL. Brilliant minds think alike!

[Bruce Dubbs]

I got a response from upstream. I'll wait a couple of days to see if we get a point release.

[Douglas R. Reno]

I commented about it being related to gtk-layer-shell, and reformatted the patch so it's actually readable. Also offered to make a PR, will wait to see if upstream would like me to prior to making one.

[Joe Locash]

Good work. A MR is in: ​https://gitlab.xfce.org/apps/xfce4-terminal/-/merge_requests/112

Looks familiar ;)

[Joe Locash]

Merged upstream: ​https://gitlab.xfce.org/apps/xfce4-terminal/-/commit/b07d9546a08a3cd70b7e9aaad7a86256fbe32b8b

[Bruce Dubbs]

Fixed at commits

e188359b38 Update to xfce4-terminal-1.2.0.
367404b2af Update to vim-9.2.0161 (Sync with LFS).
3040bd1657 Update to unix-tree-2.3.2.
53ab59343b pdate to ruby-4.0.2.
50245496a8 Update to ghostscript-10.07.0.