Opened 6 months ago

Closed 6 months ago

#23211 closed enhancement (fixed)

x265-4.2

Reported by: zeckma Owned by: SecurityAdvisory
Priority: elevated Milestone: 13.1
Component: BOOK Version: git
Severity: medium Keywords:
Cc:

Description

New minor version.

This release fixes a memory leak, and fails to build for 32-bit, both for multilib and on i?86.

The fix for the 32-bit issue is quite simple:

diff '--color=auto' -Naur x265_4.2.orig/source/common/x86/cpu-a.asm x265_4.2/source/common/x86/cpu-a.asm
--- x265_4.2.orig/source/common/x86/cpu-a.asm	2026-04-19 00:29:17.000000000 -0600
+++ x265_4.2/source/common/x86/cpu-a.asm	2026-04-28 14:13:19.668692866 -0600
@@ -177,7 +177,7 @@
 %if WIN64
     lea rax, [intel_cpu_indicator_init]
     call rax
-%elif FORMAT_ELF
+%elif UNIX64 && FORMAT_ELF
     call [rel intel_cpu_indicator_init wrt ..plt]
 %else
     call intel_cpu_indicator_init

UNIX64 in the code was switched to FORMAT_ELF to adjust for MacOS. But now the code doesn't check what the architecture is, which is important since i?86 cannot do PLT, which the condition goes through if true. So both the architecture and format needs to be checked. With this change, both 64-bit and 32-bit compiles fine.

The issue covering this build failure is discussed here: ​https://bitbucket.org/multicoreware/x265_git/issues/1030/42-build-fails-on-i686-elf-format-cannot.

Change History (4)

comment:1 by Xi Ruoyao, 6 months ago

The sed and -D CMAKE_POLICY_VERSION_MINIMUM=3.5 are now unneeded.

comment:2 by Joe Locash, 6 months ago

Owner: changed from blfs-book to Joe Locash
Status: new → assigned

comment:3 by Joe Locash, 6 months ago

Owner: changed from Joe Locash to SecurityAdvisory
Status: assigned → new

See ​https://x265.readthedocs.io/en/master/releasenotes.html for changes.

Fixed at 4a92faafdf.

Leaving open for SA.

comment:4 by Douglas R. Reno, 6 months ago

Resolution: → fixed
Status: new → closed

SA-13.0-062 issued.

Note: See TracTickets for help on using tickets.