Opened 4 months ago

Closed 3 months ago

#23382 closed enhancement (fixed)

Recheck tests for mutter-50.1 and gnome-shell-50.2

Reported by: Bruce Dubbs Owned by: blfs-book
Priority: normal Milestone: 13.1
Component: BOOK Version: git
Severity: medium Keywords:
Cc:

Description

I had several test failures in these packages that need to be reviewed by someone with a different gnome build. Those book pages may need to be updated depending on results.

Change History (8)

comment:1 by pierre, 4 months ago

Looks like gnome-shell FTBFS with latest libical version:

../src/calendar-server/gnome-shell-calendar-server.c: In function ‘get_ical_star
t_time’:
../src/calendar-server/gnome-shell-calendar-server.c:172:32: error: passing argument 4 of ‘get_time_from_property’ from incompatible pointer type [-Wincompatible-pointer-types]
  172 |                                i_cal_property_get_dtstart,
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                |
      |                                ICalTime * (*)(const ICalProperty *)
../src/calendar-server/gnome-shell-calendar-server.c:119:39: note: expected ‘ICalTime * (*)(ICalProperty *)’ but argument is of type ‘ICalTime * (*)(const ICalProperty *)’
  119 |                         ICalTime * (* get_prop_func) (ICalProperty *prop),
      |                         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Last edited 4 months ago by pierre (previous) (diff)

in reply to:  1 comment:2 by Bruce Dubbs, 4 months ago

Replying to pierre:

Looks like gnome-shell FTBFS with latest ical version:

I wonder what changed. From my log:

Sun May 17 12:25:06 CDT 2026 /usr/src/libical/libical-4.0.1.tar.gz
...
Fri May 29 12:43:16 CDT 2026 /usr/src/gnome-shell/gnome-shell-50.2.tar.xz

I have not tested with libical-4.0.2 though.

comment:3 by Bruce Dubbs, 4 months ago

Double checking my gnome-shell script, it looks like I forgot to add:

    sed -e '/(ICalProperty/s/ICalProperty/const &/' \
        -i src/calendar-server/gnome-shell-calendar-server.c &&

Try that.

in reply to:  3 comment:4 by pierre, 4 months ago

Replying to Bruce Dubbs:

Double checking my gnome-shell script, it looks like I forgot to add:

    sed -e '/(ICalProperty/s/ICalProperty/const &/' \
        -i src/calendar-server/gnome-shell-calendar-server.c &&

Try that.

Yes, i builds

comment:5 by pierre, 3 months ago

Tests passed for me in a gnome session in a VM:

  • Mutter
    Ok:            259
    Expected Fail: 5
    Fail:          9
    
  • Gnome-shell:
    Ok:            23
    Fail:          0
    

comment:6 by pierre, 3 months ago

Note that I have neither Xvfb-run nor zenity, but I only have wayland support anyway.

comment:7 by pierre, 3 months ago

I rerun the tests in a plasma wayland session (still in a VM). Same result for mutter. One failure for gnome-shell. I'd tend to close this ticket, unless something new comes.

comment:8 by Bruce Dubbs, 3 months ago

Resolution: → fixed
Status: new → closed

OK, thanks for checking. Closing.

Note: See TracTickets for help on using tickets.