#2408 closed defect (fixed)
killproc killing children first
| Reported by: | DJ Lucas | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Bootscripts | Version: | SVN |
| Severity: | major | Keywords: | |
| Cc: |
Description
Just a reminder so it's not forgotten, labeled as a blocker. I don't see the errors because I use contrib bootscripts (and homegrown). Currently reported are httpd and samba scripts. Adding -p $PIDFILE to the killproc line is reported as a working solution.
Change History (10)
comment:1 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 16 years ago
So, I found out a little later that the LFS bootscripts are buggy when passing "-p $pidfile". The problem is that if there's a stale pid file hanging around, loadproc will bail out. This becomes a big problem if you've had to hard reboot and have a lot of stale pid files. In that case, you have to go and manually remove all the stale pid files or you won't get any services you might need.
The right way to fix this is to teach the *proc functions what to do in the face of a stale pid file. However, any fixes will be on LFS trunk (I do plan on doing this since it bites me frequently). Since we're targeting LFS-6.3, I'm going to back out r7122. I'll leave the samba fix in r7121 there since it fixes a bigger issue.
Does that sound alright?
comment:3 by , 16 years ago
| Milestone: | 6.3 → 7.0 |
|---|
Backed out the changes in r7265. Changing the milestone to 7.0 when we can depend on a proper fix in the LFS bootscripts. See LFS #2160 (http://wiki.linuxfromscratch.org/lfs/ticket/2160).
comment:4 by , 16 years ago
| Milestone: | 7.0 → future |
|---|---|
| Severity: | blocker → major |
Simply changing the Milestone to 'Future' as we don't know when LFS-7.0 is going to appear (there could be a BLFS-6.3.1 after BLFS-6.3?).
Additionally, there are only one or two flagged as 7.0 so marking it future makes it easier to use the filters.
Also changing the "Blocker" as that conflicts with it not being a 6.3 bug.
comment:5 by , 15 years ago
| Milestone: | future → 6.4 |
|---|---|
| Owner: | changed from to |
| Status: | assigned → new |
| Type: | task → defect |
comment:9 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Closing. LFS-7 now uses /run for pid files so there will be none in a reboot situation.
Reopen as necessary.
Committed a fix for samba in r7121. Note that httpd is OK because we use the apachectl script, which knows how to handle httpd correctly (I think). r7122 has a few more scripts where I know that referencing the pid file in /var/run works. I just fixed that ones that are currently running on my system. Feel free to add more.
Leaving this open for now in case anyone else spots scripts where this process handling is not correct. I tend to think that anything that puts creates a pidfile should be calling the *proc functions with that info.