Opened 12 years ago

Closed 12 years ago

Last modified 5 years ago

#3010 closed task (fixed)

Procmail's getline() conflicts with glibc getline().

Reported by: Ag. Hatzimanikas Owned by: Ag. Hatzimanikas
Priority: high Milestone: x-future
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

Procmail is one of the many packages that fails to build, because as of 2.10 glibc has its own getline() function, since is defined in POSIX 2008. For procmail a simple sed can be used:

sed -i '/getline/get_line/' src/*.[ch]

This renames the getline function to get_line to the fields.c, formail.c formisc.c and formisc.h in the src directory.

Is it ok to use the sed or should I make a patch for it?

Change History (4)

comment:1 by Ag. Hatzimanikas, 12 years ago

Owner: changed from blfs-book@… to Ag. Hatzimanikas
Status: newassigned

A small correction,

sed -i 's/getline/get_line/' src/*.[ch]

comment:2 by bdubbs@…, 12 years ago

I feel seds are preferable to patches. They are more visible and don't require a separate download. When we get to a point where several seds are required, then it's a judgment call when to transition to a patch.

comment:3 by Ag. Hatzimanikas, 12 years ago

Resolution: fixed
Status: assignedclosed

Thanks.

Fixed in r8199.

comment:4 by bdubbs@…, 5 years ago

Milestone: futurex-future

Milestone renamed

Note: See TracTickets for help on using tickets.