libdiscid required for libmusicbrainz3

[Pierre Labastie]

According to libmusicbrainz3.pc:

prefix=/usr
exec_prefix=/usr
libdir=/usr/lib
includedir=/usr/include

Name: libmusicbrainz3
Description: The Musicbrainz Client Library.
URL: http://musicbrainz.org/doc/libmusicbrainz
Version: 3.0.3
Requires.private: neon >= 0.25, libdiscid

Libs: -L/usr/lib -lmusicbrainz3
Cflags: -I/usr/include

Actually, I have built libmusicbrainz3 and not libdiscid, because it is only an optional dependency. But when trying to build sushi, configure tests the presence of several files, including libmusicbrainz3 by issuing

pkg_cv_SUSHI_CFLAGS=`$PKG_CONFIG --cflags "glib-2.0 >= $GLIB_MIN_VERSION
                  gobject-introspection-1.0 >= $GOBJECT_INTROSPECTION_MIN_VERSION
                  gjs-1.0 >= $GJS_MIN_VERSION
                  gjs-dbus-1.0 >= $GJS_MIN_VERSION
                  gobject-2.0 >= $GLIB_MIN_VERSION
                  clutter-1.0 >= $CLUTTER_MIN_VERSION
                  clutter-x11-1.0 >= $CLUTTER_MIN_VERSION
                  gtk+-3.0 >= $GTK_MIN_VERSION
                  clutter-gtk-1.0 >= $CLUTTER_GTK_MIN_VERSION
                  clutter-gst-1.0
                  gstreamer-0.10
                  gstreamer-pbutils-0.10
                  gstreamer-tag-0.10
                  libmusicbrainz3
                  evince-document-3.0
                  evince-view-3.0
                  gtksourceview-3.0
                  webkitgtk-3.0" 2>/dev/null`

This incorrectly reports SUSHI_CFLAGS=' ' instead of throwing an error, so that the build fails later.

Sorry for being so long, but I think the conlusion should be at least to say that libdiscid is a required dep of libmusicbrainz3 if you plan to build sushi.

[Armin K]

Well, if packages fail to build against libmusicbrainz when libdiscid is not present, I guess libdiscid is required dependency since even pkg-config file states that. Fixed in r10207

[bdubbs@…]

Milestone current deleted