Opened 19 years ago

Closed 19 years ago

Last modified 8 years ago

#358 closed defect (fixed)

compface fails to link due to problem with including errno.h

Reported by: aireland@… Owned by: tushar@…
Priority: high Milestone:
Component: BOOK Version: ~CVS
Severity: normal Keywords:
Cc:

Description

As per the CVS book, I checked CVS-2003-09-24 compface-1.4 is compiled with ./configure --prefix=/usr make && make install

Make faile for me at the link stage.

If you edit configure.in to adee errno.h to AC_CHECK_HEADERS AC_CHECK_HEADERS(fcntl.h strings.h errno.h) Run autoconf

edit cmain.c and uncmain.c to include #ifdef HAVE_ERRNO_H #include <errno.h> #endif

it compiles fine and installs. I am not sure if this is the best waw to fix this. But it seems to work for me.

Attachments (1)

compface-1.4-errno.patch (631 bytes ) - added by tushar@… 19 years ago.
errno patch

Download all attachments as: .zip

Change History (8)

comment:1 by aireland@…, 19 years ago

I have placed a patch for compfile to fix this at http://homepage.eircom.net/~aireland/compface-1.4-errno.patch

it is included by the usual patch -Np1 -i ../compface-1.4-errno.patch

comment:2 by tushar@…, 19 years ago

The patch is huge (because configure.in was patched and configure was regenerated). Why not just patch the *.c files to include errno.h instead of the #ifdef. The patch to configure.in and *.c files should be submitted upstream. The patch headers should mention that the patch is only applicable for gcc-3.3.x.

comment:3 by aireland@…, 19 years ago

The patch is TOO big all right. I did not know that the patch was specific for gcc-3.3.1 I did try to compile without any changes with gcc-2.95.3 but it did not work.

An alternative would be to make a patch with the changes in configure.in cmain.c and uncmain.c and ask the user to run autoconf as part of the installation.

What do you mean by submitting the patches upstream? I will make a smaller patch and put it http://homepage.eircom.net/~aireland/compface-1.4.errno.2.patch

comment:4 by tushar@…, 19 years ago

The patch is TOO big all right. I did not know that the patch was specific for gcc-3.3.1 I did try to compile without any changes with gcc-2.95.3 but it did not work.

Oops, I meant glibc-2.3.x.

An alternative would be to make a patch with the changes in configure.in cmain.c and uncmain.c and ask the user to run autoconf as part of the installation.

Just patch the .c files (as per the patch I will be attaching next). Since current release of BLFS will be compatible with the current release of LFS, the patch will be applied for most users.

What do you mean by submitting the patches upstream? I will make a smaller patch and put it http://homepage.eircom.net/~aireland/compface-1.4.errno.2.patch

Upstream is the compface developers.

by tushar@…, 19 years ago

Attachment: compface-1.4-errno.patch added

errno patch

comment:5 by tushar@…, 19 years ago

Owner: changed from blfs-book@… to tushar@…

comment:6 by tushar@…, 19 years ago

Resolution: fixed
Status: newclosed

comment:7 by bdubbs@…, 8 years ago

Milestone: old

Milestone old deleted

Note: See TracTickets for help on using tickets.