Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#3814 closed enhancement (fixed)

libpng 1.6.1

Reported by: rt Owned by: Armin K
Priority: normal Milestone:
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

http://sourceforge.net/projects/libpng/files/

Creating a new ticket, since replacing version 1.5 with 1.6 seems to break alot of packages. We should problably wait until all packages support this version.

Change History (9)

comment:2 by rt, 11 years ago

Summary: libpng 1.6libpng 1.6 series

comment:3 by ken@…, 11 years ago

Do you have a list of what is known to break ?

So far, I've only built as far as xulrunner/firefox with 1.6.1 (the apng patch came out a few hours ago). The only thing I've so far broken is libtheora-1.1.1 which is fixed by

sed -i 's/png_\(sizeof\)/\1/g' examples/png2theora.c

That's based on a b0rken link google found, which said to replace any users of png_sizeof() by sizeof().

I agree that you might not want to do that for 1.5 ( dunno - it's only in examples/, nobody is likely to use it ;-) and I'm sure there are probably other things in my "minimal" desktop build which are going to be broken by it, but we're supposed to be bleeding edge, aren't we ?

Maybe I should add that this is on LFS-7.3, not LFS-svn.

comment:4 by Armin K, 11 years ago

Owner: changed from blfs-book@… to Armin K
Priority: lownormal
Status: newassigned
Summary: libpng 1.6 serieslibpng 1.6.1

I'm finishing libpng 1.5 -> libpng 1.6 rebuild and everything works so far. Only gdk-pixbuf build produces a warning which can be easily fixed with a sed.

I'll check libtheora, too.

comment:5 by rt, 11 years ago

When I replaced libpng 1.5 with 1.6, several packages including Qt and all of its dependencies broke. I did not try recompiling the packages with libpng 1.6.

comment:6 by Armin K, 11 years ago

I've rebuilt everything, including Qt, Gdk-Pixbuf, librsvg, LibreOffice, MPlayer, VLC, Firefox, Thunderbird, etc and almost everything works fine except one issue with nm-applet icon which I was just about to ask on libpng mailing list. One minor issue appears to be with animated png (the firefox "loading" icon - rotating one" seems to be "blinking").

The only issue I got is

WARNING **: Icon nm-signal-100 missing: (0) Fatal error reading PNG image file: Decompression error in IDAT

I have no idea why I get that. It worked fine with libpng 1.5.

comment:7 by Armin K, 11 years ago

Also, png.h header doesn't include string.h anymore, so we have to watch for "implicit declarations" in package which need string.h but rely on it to be included via png.h - as it was done in Gdk-Pixbuf (which I fixed).

comment:8 by Armin K, 11 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r11138

comment:9 by bdubbs@…, 10 years ago

Milestone: current

Milestone current deleted

Note: See TracTickets for help on using tickets.