Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4553 closed defect (fixed)

qemu-1.7.0 won't build with libcap-2.24

Reported by: Wayne Blaszczyk Owned by: Fernando de Oliveira
Priority: normal Milestone:
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

The following error occurs during make

  LINK  qemu-io
  CC    fsdev/virtfs-proxy-helper.o
In file included from /usr/include/sys/capability.h:30:0,
                 from fsdev/virtfs-proxy-helper.c:15:
/usr/include/sys/xattr.h:31:3: error: expected identifier before numeric constant
   XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
   ^
make: *** [fsdev/virtfs-proxy-helper.o] Error 1

Removing the line: include <linux/xattr.h> from /usr/include/sys/capability.h fixes the issue, but I'm not sure if this is the correct way of fixing it. i.e. why was this line inserted since the previous release?

Change History (8)

comment:1 by Fernando de Oliveira, 8 years ago

Owner: changed from blfs-book@… to Fernando de Oliveira
Status: newassigned

Wayne, have never built qemu. To do it, needed to recompile the kernel in my host. Then, there was a new Nvidia driver, a new VMPlayer, and only today I got courage to do it all and at the same time use the occasion to update the kernel.

This host is LFS7.1,not 7.4.

Apparently it is a problem that could affect other packages, and has to do, believe me, with the order in which the headers are placed:

https://bugs.archlinux.org/task/38387

Solved, by moving the header position with:

      sed -e '/#include <sys\/capability.h>/ d' \
          -e '/#include "virtio-9p-marshal.h"/ i#include <sys\/capability.h>' \
          -i fsdev/virtfs-proxy-helper.c

I will fix the book immediately, but would be much grateful if you could confirm that it indeed solves your problem.

comment:2 by Fernando de Oliveira, 8 years ago

The mailer breaks the line. Please copy from/paste from the ticket in the web

comment:3 by Fernando de Oliveira, 8 years ago

Fixed at r12607.

Close after Wayne confirms it is fixed.

in reply to:  1 comment:4 by ken@…, 8 years ago

Replying to fo:

Wayne, have never built qemu. To do it, needed to recompile the kernel in my host. Then, there was a new Nvidia driver, a new VMPlayer, and only today I got courage to do it all and at the same time use the occasion to update the kernel.

Just a note that _building_ qemu shouldn't need kernel changes, but _running_ it might (or, indeed, might need a more capable CPU).

comment:5 by Fernando de Oliveira, 8 years ago

Thanks, ĸen. Didn't know.

comment:6 by Wayne Blaszczyk, 8 years ago

I can confirm that the fix does work.

Thanks, Fernando.

comment:7 by Fernando de Oliveira, 8 years ago

Resolution: fixed
Status: assignedclosed

Glad it worked for you and for the book.

Thank you very much for replying.

Cheers,

Last edited 8 years ago by Fernando de Oliveira (previous) (diff)

comment:8 by bdubbs@…, 8 years ago

Milestone: current

Milestone current deleted

Note: See TracTickets for help on using tickets.