Opened 10 years ago

Closed 10 years ago

#4921 closed enhancement (fixed)

Fix xine-ui to build with readline 6.3

Reported by: Pierre Labastie Owned by: ken@…
Priority: normal Milestone: 7.6
Component: BOOK Version: SVN
Severity: normal Keywords:


Error (reported by Robin, on BLFS-support):

network.c: In function ‘main’:
network.c:1258:39: error: ‘CPPFunction’ undeclared (first use in this function)
   rl_attempted_completion_function = (CPPFunction *)completion_function;
network.c:1258:39: note: each undeclared identifier is reported only
once for each function it appears in
network.c:1258:52: error: expected expression before ‘)’ token
   rl_attempted_completion_function = (CPPFunction *)completion_function;
network.c: At top level:
network.c:884:15: warning: ‘completion_function’ defined but not used
 static char **completion_function(const char *text, int start, int end) {

I suppose the sed to use is:

sed -i s/CPPFunction/rl_completion_func_t/ src/xitk/network.c

Change History (7)

comment:1 by ken@…, 10 years ago

Patch from upstream (against 0.99.8, but applies to 0.99.7) is already in -patches.

comment:2 by bdubbs@…, 10 years ago

The change is one line. A sed is better when practical. It gives better transparency in the book.

comment:3 by Pierre Labastie, 10 years ago

I suggest the change proposed by Fernando is better (with slight change in the regexp, but just a matter of taste):

sed -i 's/(CPPFunction[^)]*)//' src/xitk/network.c

BTW, sorry for not seeing that ĸen was taking care of xine-ui update.

comment:4 by Fernando de Oliveira, 10 years ago

I don't remember suggesting anything releated to xine and relatives. I believe ĸen did in


comment:5 by Pierre Labastie, 10 years ago

I think I suddenly understand why I always think Fernando did something. In the message on BLFS-book, there is:

 Reporter:  fo           |       Owner:  ken@…

and then

Comment (by ken@…):

And somehow, I attribute it to the "Reporter". Apologies to everybody I have mistaken...

comment:6 by ken@…, 10 years ago

Owner: changed from blfs-book@… to ken@…
Status: newassigned

I seem to get in a mess with parentheses in sed. Yes, pierre's version works and is clearer.

I'll attend to 0.99.8 now.

comment:7 by ken@…, 10 years ago

Resolution: fixed
Status: assignedclosed

done in r12942.

Note: See TracTickets for help on using tickets.