Opened 10 years ago

Closed 10 years ago

#4974 closed enhancement (fixed)

nmap-6.46

Reported by: Fernando de Oliveira Owned by: Fernando de Oliveira
Priority: normal Milestone: 7.6
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

http://nmap.org/dist/nmap-6.46.tar.bz2

http://nmap.org/changelog.html

Nmap 6.46 [2014-04-18]

o [NSE] Made numerous improvements to ssl-heartbleed to provide
  more reliable detection of the vulnerability.

o [Zenmap] Fixed a bug which caused this crash message:
     IOError: [Errno socket error] [Errno 10060] A connection attempt failed
     because the connected party did not properly respond after a period of
     time, or established connection failed because connected host has
     failed to
     respond
  The bug was caused by us adding a DOCTYPE definition to Nmap's XML
  output which caused Python's XML parser to try and fetch the DTD
  every time it parses an XML file.  We now override that DTD-fetching
  behavior. [Daniel Miller]

o [NSE] Fix some bugs which could cause snmp-ios-config and
  snmp-sysdescr scripts to crash
  (http://seclists.org/nmap-dev/2014/q2/120) [Patrik Karlsson]

o [NSE] Improved performance of citrixlua library when handling large XML
  responses containing application lists. [Tom Sellers]

Change History (3)

comment:1 by Fernando de Oliveira, 10 years ago

Owner: changed from blfs-book@… to Fernando de Oliveira
Status: newassigned

comment:2 by Fernando de Oliveira, 10 years ago

Every time, the same tests fail. Identical results either as root or regular user.

Now, I can understand that two of them are wrong and I can fix them. First, zenmap_check, by removing a "dot" in Makefile.in. Second, ndiff_check, by removing attribute "StringIO" from "StringIO" in ndiff/ndifftest.py (whatever that means).

Five "subtests" from ncat_check are expected to fail, but don't do it. I cannot say that I understand enough to state that they are wrong. But I can just remove 5 "expect_fail" addresses from ncat/test/test-addrset.sh.

Thus, "make check" can be run without error, with the patch:

diff -Naur nmap-6.46.orig/Makefile.in nmap-6.46/Makefile.in
--- nmap-6.46.orig/Makefile.in	2014-02-21 20:11:41.000000000 -0300
+++ nmap-6.46/Makefile.in	2014-04-18 14:32:16.931394444 -0300
@@ -401,7 +401,7 @@
 	@cd $(NSOCKDIR)/src && $(MAKE) check
 
 zenmap_check:
-	@cd $(ZENMAPDIR) && $(PYTHON) -m unittest discover build/lib.* '*.py'
+	@cd $(ZENMAPDIR) && $(PYTHON) -m unittest discover build/lib* '*.py'
 
 check: @NCAT_CHECK@ @NSOCK_CHECK@ @ZENMAP_CHECK@ @NSE_CHECK@ @NDIFF_CHECK@
 
diff -Naur nmap-6.46.orig/ncat/test/test-addrset.sh nmap-6.46/ncat/test/test-addrset.sh
--- nmap-6.46.orig/ncat/test/test-addrset.sh	2013-12-03 16:11:12.000000000 -0300
+++ nmap-6.46/ncat/test/test-addrset.sh	2014-04-18 14:33:59.224924093 -0300
@@ -247,23 +247,18 @@
 google.com
 EOF
 
-expect_fail "."
 expect_fail "-"
 expect_fail ","
 expect_fail "1.2.3.4,"
 expect_fail ",1.2.3.4"
-expect_fail "1.2.3.4.5"
 expect_fail "1:2:3:4:5:6:7:8:9"
 expect_fail "11::22::33"
 
-expect_fail "256.256.256.256"
 expect_fail "FFFFF::FFFFF"
 
 # Backwards range.
-expect_fail "10-5.2.3.4"
 
 expect_fail "*10.10.10.10"
-expect_fail "5-10-15.10.10.10"
 expect_fail "-10-15.10.10.10"
 expect_fail "10-15-.10.10.10"
 expect_fail ",.6.7.8"
diff -Naur nmap-6.46.orig/ndiff/ndifftest.py nmap-6.46/ndiff/ndifftest.py
--- nmap-6.46.orig/ndiff/ndifftest.py	2014-01-10 17:43:32.000000000 -0300
+++ nmap-6.46/ndiff/ndifftest.py	2014-04-18 14:32:25.144197136 -0300
@@ -697,7 +697,7 @@
         a.load_from_file("test-scans/empty.xml")
         b = Scan()
         b.load_from_file("test-scans/simple.xml")
-        f = StringIO.StringIO()
+        f = StringIO()
         self.scan_diff = ScanDiffXML(a, b, f)
         self.scan_diff.output()
         self.xml = f.getvalue()

Is it worth to include this patch in the build?

I will not update this today. Will leave for tomorrow.

comment:3 by Fernando de Oliveira, 10 years ago

Resolution: fixed
Status: assignedclosed

Fixed at r12979.

Note: See TracTickets for help on using tickets.