Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#4982 closed defect (fixed)

Fontsproto-2.1.3 breaks libXfont-1.4.7

Reported by: Miklos Karacsony Owned by: Fernando de Oliveira
Priority: normal Milestone: 7.6
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

Heres's what I've got, when I tried to build it: 

patcache.c:130:1: error: conflicting types for 'CacheFontPattern'
 CacheFontPattern (FontPatternCachePtr cache,
 ^
In file included from /scratch/x11/libXfont/work/.buildlink/include/X11/fonts/fontstruct.h:28:0,
                 from patcache.c:35:
/scratch/x11/libXfont/work/.buildlink/include/X11/fonts/font.h:141:18: note: previous declaration of 'CacheFontPattern' was here
 extern void      CacheFontPattern (
                  ^
patcache.c:176:1: error: conflicting types for 'FindCachedFontPattern'
 FindCachedFontPattern (FontPatternCachePtr cache,
 ^
In file included from /scratch/x11/libXfont/work/.buildlink/include/X11/fonts/fontstruct.h:28:0,
                 from patcache.c:35:
/scratch/x11/libXfont/work/.buildlink/include/X11/fonts/font.h:151:21: note: previous declaration of 'FindCachedFontPattern' was here
 extern FontPtr      FindCachedFontPattern (
                     ^

Attachments (1)

libXfont-1.4.7-fontsproto-fix-1.patch​ (938 bytes ) - added by Miklos Karacsony 10 years ago.
This patch will fix the build

Download all attachments as: .zip

Change History (15)

comment:1 by Miklos Karacsony, 10 years ago 

patcache.c:176:1: error: conflicting types for 'FindCachedFontPattern'
 FindCachedFontPattern (FontPatternCachePtr cache,
 ^
In file included from /usr/include/X11/fonts/fontstruct.h:28:0,
                 from patcache.c:35:
/usr/include/X11/fonts/font.h:151:21: note: previous declaration of 'FindCachedFontPattern' was here
 extern FontPtr      FindCachedFontPattern (
                     ^

comment:2 by Miklos Karacsony, 10 years ago

libXfont-1.4.7 not libXft-1.4.7 sorry.

by Miklos Karacsony, 10 years ago

Attachment: libXfont-1.4.7-fontsproto-fix-1.patch​ added

This patch will fix the build

comment:4 by Fernando de Oliveira, 10 years ago

Owner: changed from blfs-book@… to Fernando de Oliveira
Status: new → assigned

in reply to:  3 comment:5 by Fernando de Oliveira, 10 years ago

Replying to Krejzi:

​http://cgit.freedesktop.org/xorg/lib/libXfont/commit/?id=d279ffa49284b5e5f787f76edbe8c52226534a64

This is official upstream fix.

Thanks, Armin, but it did not seem to work.

comment:6 by Fernando de Oliveira, 10 years ago

Thanks Miklos,

The patch worked.

comment:7 by Fernando de Oliveira, 10 years ago

Summary: Fontsproto-2.1.3 breaks LibXft-1.4.7 → Fontsproto-2.1.3 breaks libXfont-1.4.7

comment:8 by Fernando de Oliveira, 10 years ago

Thanks Miklos K. for reporting and fixing, and Armin K. for confirming.

Fixed at r12990.

comment:9 by Fernando de Oliveira, 10 years ago

Resolution: → fixed
Status: assigned → closed

comment:10 by Armin K, 10 years ago

You may need more patches from git repo than the one I linked to. I believe I applied more than one to check which one will fix the build.

comment:11 by Fernando de Oliveira, 10 years ago

Sorry, I was not precise.

The one you linked to just failed to patch: chunk rejected.

comment:12 by Armin K, 10 years ago

Works here, make sure you apply it on clean source. It does however also require this patch in addition to the first one:

​http://cgit.freedesktop.org/xorg/lib/libXfont/commit/?id=a96cc1f032a059da89319ceccb6659c8edd446fb

comment:13 by Fernando de Oliveira, 10 years ago

Seems I did not form the patch from upstream correctly. Trying again.

comment:14 by Fernando de Oliveira, 10 years ago

Problem was the patch was not properly formed by me.

Modifying the book to use upstream fixes.

Thanks, Armin.

Fixed at r12991.

Note: See TracTickets for help on using tickets.